Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp756241lqo; Thu, 16 May 2024 23:57:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVi2i6PbLLMC1MxVHaTuBAgvXm4WCrYnPd+3xpCE2XM9Yu0WwkkjQd2kH+10hky5a1jidBfUnlz2V/HOu0LB8tVcglr4QVNrj4iGekfig== X-Google-Smtp-Source: AGHT+IHeg0dbcTGcYfYsoTf12Aeu6ph4MnrWteRD5IU7Xxxe00UMEq0fQ3c8SoLk+TVGhkR2vJVA X-Received: by 2002:a17:902:ce86:b0:1e9:43c:d176 with SMTP id d9443c01a7336-1ef43c0cf35mr254329885ad.12.1715929045561; Thu, 16 May 2024 23:57:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1715929045; cv=pass; d=google.com; s=arc-20160816; b=vw8YdKCi1wOVgkhlobQextCVkbx9HVMxEq7GgRE1/DXLABP598cxHRWyYHB/pToKsw hoQjCc9Bk9A1nmayWvABGVIg4IHk4o4fnqlpeW6yHZwncrIWpvgKiJd00AHILioLYwHV VavO/6rYKh7qq/mg12CV+zUd6VfuEbFxqiorHGmswZ/wx5vQj9Lf2MsOhhxtptqMBGGe n94+7gbB1Mn93sXXubbATEu+Q+61pEwrRL/ChrWUUa9jVKWCXsH7tOJmO6OMI6lzfqzU GDdxpnKRDIg8WOGLnL/lJgm5jG5gpbVGUiSjSSIGMhX8UG0ZlqctoGaTfO82wjqXl8WT lOLg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=o5vraI/wJe/M9PMp/iXSwY70gFGzbtWCZo7KHleB8Kw=; fh=Jk6m7CXRxVrI6bhAhKDFAVrH8YqM64JRKqQS8KcSWPs=; b=s5TshATKbjnPjZLtsYpro8NZa7lvL0A+f7gd0kJcZu6dp0hibPbNRtS9j4ChRYHX6D P3fT9D23wnMyfhKEj8JVgvvVRlXnJU/z91yoMZzDIqJIukPhg6neLgfbrWhESYHcmscc sx0ppXi4V/QAixvNPfpORzfJD9pqJ+83UqfY+1ZUWuUGzqq0/f4qWNIQMfduSy7F1Q/Q 5/eBShAzWZFdhiqh6ZaoqKk9VKX2n7YOdjIxa1fiC8KeLVh+xufgDag/N5yePmzru/3L UCJEAOcwNgxLV03/UOAduXgtzGXJtjq2SNX8kwhPKbfa6JNebwVydSZj2N+nNuaak1Yu QD3Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dsPen7Af; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7768-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7768-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1ef0c26a161si179230275ad.601.2024.05.16.23.57.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 May 2024 23:57:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7768-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dsPen7Af; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7768-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7768-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id EB72228352D for ; Fri, 17 May 2024 06:57:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 41FF814A99; Fri, 17 May 2024 06:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dsPen7Af" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E11B14A8D for ; Fri, 17 May 2024 06:57:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715929042; cv=none; b=sSruBD/jAZBy9Kx/rq+m1gsK88+9N8CpSxXEU5FemMBC8HvKM9PUdN+iaqKVcw1FovlDdarhr4/xkfuEZN0khYTVLdkH4/Ybby6xy8XeXUtyIdPFOuAfQSQHS0ierbGNeQmsqoPvvpyqFIJeTaXz8t/LXRe3oojxDcldISIDLCI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715929042; c=relaxed/simple; bh=WDA8FD2lgGijxh27XqYTzwf8c0PDnanf6CKK2mQJuds=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=Q6eDT33yHJa1A2en7h+o1QeNSpvO7gA0vjLp93QeYOfKDMZR5Tpo+jr3Ja+FqZH0pc8kB28vL6/atS7cFDr72ch8+jY6Bq+nSOby+++YWqmPYN939oh+Yd9IC81jOFcT+dLANq+5qbhYFbD5skwytxbvuFx1f9SXmni47GMHkWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dsPen7Af; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA7FEC2BD10; Fri, 17 May 2024 06:57:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715929041; bh=WDA8FD2lgGijxh27XqYTzwf8c0PDnanf6CKK2mQJuds=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=dsPen7AfMkuRv7H/6osZ+V1ItRq1GHa0yMGAualYKjEV6K+1hXkUTDQa3pqN7vZUE lARigiQ232AoFUiJpvNrNeD+RGOFvdXRGDRkS4iSyfYLbX6ZzAPuzOGBDQV0P1lAuZ xowQCuPw/AktFkJks/B9s83XcWVuaKde/XaXrmp5KxgvAFVqIqqBY6ny8Reg5Rmn+u MmrTTnGVwbCkDKUvp6XWMamTeiwM7y9R3pEe8DHAKi2B/JZ2AbEjB/2UVckBs6v06b F5+M9kWfUaAeOFwEZEYMKdBR7Hji9kJxfhTEPmsrrMyi3mlEYP1B0WDaaTsRRYpE1c 3HSbWG/umt32w== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath12k: fix the issue that calculation of ack signal strength From: Kalle Valo In-Reply-To: <20240511030917.65811-1-quic_lingbok@quicinc.com> References: <20240511030917.65811-1-quic_lingbok@quicinc.com> To: Lingbo Kong Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171592903908.3197586.10319031507353572437.kvalo@kernel.org> Date: Fri, 17 May 2024 06:57:20 +0000 (UTC) Lingbo Kong wrote: > Currently, the calculation of ack signal strength is incorrect. > > This is because before calculating the ack signal strength, ath12k need > to determine whether the hardware and firmware support db2dbm. If the > hardware and firmware support db2dbm, do not need to add noise floor, > otherwise, need to add noise floor. > > Besides, the value of ack_rssi passed by firmware to ath12k should be a > signed number, so change its type to s8. > > This patch affects QCN9274 and WCN7850 because they have the same issue. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Lingbo Kong > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. ed61863debb2 wifi: ath12k: fix ack signal strength calculation -- https://patchwork.kernel.org/project/linux-wireless/patch/20240511030917.65811-1-quic_lingbok@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches