Received-SPF: pass (google.com: domain of linux-wireless+bounces-7774-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 17 May 2024 10:13:12 +0200
From: Francesco Dolcini <francesco@dolcini.it>
To: Kalle Valo <kvalo@kernel.org>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	Brian Norris <briannorris@chromium.org>,
	Rafael Beims <rafael.beims@toradex.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	tsung-hsien.hsieh@nxp.com, David Lin <yu-hao.lin@nxp.com>,
	stable@vger.kernel.org,
	Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: Re: [v1] wifi: mwifiex: Fix interface type change
Message-ID: <20240517081312.GA7974@francesco-nb>
References: <20240510110458.15475-1-francesco@dolcini.it>
 <171593306296.3274748.4179889716794962474.kvalo@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <171593306296.3274748.4179889716794962474.kvalo@kernel.org>

On Fri, May 17, 2024 at 08:04:24AM +0000, Kalle Valo wrote:
> Francesco Dolcini <francesco@dolcini.it> wrote:
> 
> > From: Rafael Beims <rafael.beims@toradex.com>
> > 
> > When changing the interface type we also need to update the bss_num, the
> > driver private data is searched based on a unique (bss_type, bss_num)
> > tuple, therefore every time bss_type changes, bss_num must also change.
> > 
> > This fixes for example an issue in which, after the mode changed, a
> > wireless scan on the changed interface would not finish, leading to
> > repeated -EBUSY messages to userspace when other scan requests were
> > sent.
> > 
> > Fixes: c606008b7062 ("mwifiex: Properly initialize private structure on interface type changes")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> 
> BTW I removed the Reviewed-by from the commit message, I don't see the need to
> have both Reviewed-by and s-o-b.

Sure, I was in doubt about this, in the end I added it because I have seen
this done in other subsystems, e.g. commit 6a4020b4c639 ("drm/bridge:
tc358768: fix PLL parameters computation").

Thanks
Francesco