Received-SPF: pass (google.com: domain of linux-wireless+bounces-7775-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Kalle Valo <kvalo@kernel.org>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Brian Norris <briannorris@chromium.org>,  Rafael Beims
 <rafael.beims@toradex.com>,  linux-wireless@vger.kernel.org,
  linux-kernel@vger.kernel.org,  tsung-hsien.hsieh@nxp.com,  David Lin
 <yu-hao.lin@nxp.com>,  stable@vger.kernel.org,  Francesco Dolcini
 <francesco.dolcini@toradex.com>
Subject: Re: [v1] wifi: mwifiex: Fix interface type change
References: <20240510110458.15475-1-francesco@dolcini.it>
	<171593306296.3274748.4179889716794962474.kvalo@kernel.org>
	<20240517081312.GA7974@francesco-nb>
Date: Fri, 17 May 2024 12:32:44 +0300
In-Reply-To: <20240517081312.GA7974@francesco-nb> (Francesco Dolcini's message
	of "Fri, 17 May 2024 10:13:12 +0200")
Message-ID: <87zfsog4w3.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Francesco Dolcini <francesco@dolcini.it> writes:

> On Fri, May 17, 2024 at 08:04:24AM +0000, Kalle Valo wrote:
>
>> Francesco Dolcini <francesco@dolcini.it> wrote:
>> 
>> > From: Rafael Beims <rafael.beims@toradex.com>
>> > 
>> > When changing the interface type we also need to update the bss_num, the
>> > driver private data is searched based on a unique (bss_type, bss_num)
>> > tuple, therefore every time bss_type changes, bss_num must also change.
>> > 
>> > This fixes for example an issue in which, after the mode changed, a
>> > wireless scan on the changed interface would not finish, leading to
>> > repeated -EBUSY messages to userspace when other scan requests were
>> > sent.
>> > 
>> > Fixes: c606008b7062 ("mwifiex: Properly initialize private
>> > structure on interface type changes")
>> > Cc: stable@vger.kernel.org
>> > Signed-off-by: Rafael Beims <rafael.beims@toradex.com>
>> > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
>> 
>> BTW I removed the Reviewed-by from the commit message, I don't see the need to
>> have both Reviewed-by and s-o-b.
>
> Sure, I was in doubt about this, in the end I added it because I have seen
> this done in other subsystems, e.g. commit 6a4020b4c639 ("drm/bridge:
> tc358768: fix PLL parameters computation").

Heh, yeah we all do things a bit differently :) In my view s-o-b implies
that you have reviewed it as well but clearly not everyone think the
same. I'm fine either way, this is cosmetics anyway.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches