Received-SPF: pass (google.com: domain of linux-wireless+bounces-7779-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <8b50e09b-560a-4a16-b9e7-7535ba5eedf8@intel.com>
Date: Fri, 17 May 2024 12:20:49 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] [thermal] adding check if the thermal firmware is running
To: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>,
	<miriam.rachel.korenblit@intel.com>, <kvalo@kernel.org>,
	<daniel.lezcano@linaro.org>, <johannes.berg@intel.com>, <dmantipov@yandex.ru>
CC: <linux-wireless@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240516200555.33982-1-trintaeoitogc@gmail.com>
Content-Language: en-US
From: "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
In-Reply-To: <20240516200555.33982-1-trintaeoitogc@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZzZ5MUExRjBBS2lNaHVKSHpHQ0dlRFZoK21abDc3cEdZakRtL3hNMkxzeEcv?=
 =?utf-8?B?OVVlNW1zQTNPTHdkZ2phellOZEJGVFlGQlBMbGVTN2tidTBlRythb2hMRnd0?=
 =?utf-8?B?b1pHVWtCc3kvczRDTnB6YXNBcVhkVEhNM0tZVXNSdXcySjhWbGJoNldGcVpU?=
 =?utf-8?B?WUtiQ2NOR2ZGa2d0Q29nc2ZpdTdsS2VGMmJpN1pwUHNpNnFGR0VxRHc5MG1S?=
 =?utf-8?B?Z0wzcWZFcjNqckNrVFNTQ0VpNnlOMlFoN080SGJGVklqalBnMG5PNE85ZFg1?=
 =?utf-8?B?L3hDZ29FbTIrUExSdDFXNlFKbzJkbEFBUVdHeUYwa3VvaVVuS05QK0ZkSnVO?=
 =?utf-8?B?UVVSc1k5OEJ4Q3FnTk5PbVpyTWJ1KzJ4Z21ueUk0c016dDEyMWNVNGp2ZWNz?=
 =?utf-8?B?bnZZek5CaFh1WlgvNmd3UkREQUlKYUZKdWUyR3Q0VEZlTjU0cUlYdVNUTFBi?=
 =?utf-8?B?Q0ZpOWNOTUtxNkdXai9kd3N5aitSK2dPNnhESzBxZjluMktJU2VkeDdHMmwz?=
 =?utf-8?B?YnB4MW5uNzFqYnlxV2dZalBwd0gzQ1dlVDVTOU04emFaaGJWTjdpcmJzUUdl?=
 =?utf-8?B?dHZWUGFRcno4b2dpZEpzNlltTE5sckxoNjMxeFdhdk00YlNMZkxobG9TUnNh?=
 =?utf-8?B?VlpjSEFHQXppV2ovMFdVNDRuUzQrcWlXWWt2cGJDd0MydGhscUdYMmttQ1RW?=
 =?utf-8?B?UWVoSHBoTktERXNHdGFrdGw2bFlIS0xxSk1rQlYzZTBIc01NaWthR3l6d3pF?=
 =?utf-8?B?MUFSVzl0UVJBWHRyZDlsTEJzam80U0g4OWFka0s0aERNbjRiNGp1T2gxdkxQ?=
 =?utf-8?B?UU8wNjE0cEtkVmFKSWVoOUlrUzAvTE51SGtsbUVpWjk2anBrT0xrT01TeTRJ?=
 =?utf-8?B?RWMxQ3BaaFJMbzJwRjFVRHJYVVFhMDMzTmVZRmdHa1FxRFRzTDRtYUhWeHRk?=
 =?utf-8?B?R0gydFRKRUVjcnJvdGMybG1yVDd6dC9ZNW9MY25obW9kUm4xYTF6SkZOOHFp?=
 =?utf-8?B?ajVuMmQ5bE0zeHN3MXV0ZzdWU1FZWXExTlNTaGtNTS8xN0dGUzliNFRjZkNT?=
 =?utf-8?B?SmhFS0FpakViUEV1dzFwbFFleGpJZ0ZHcXpPSXdmNFBGbVRJTjVRdDdacVli?=
 =?utf-8?B?M1hKNWZORjByVndtdVV4ZTdGemNNd01NYXk4ZXVNRUxQbzdZYWFyZ0RBSHl4?=
 =?utf-8?B?cmRiY0dJZlhxc09hMnQ2dGp4aUlTc2t5RGo4NVVEMGRlQ0RDVlFHdFUzcmph?=
 =?utf-8?B?N0FMenBLb1ZNWWdIMWY1V1FmMHQrRTdpMkJNSWpXY0wvWFVBUnErM3VIUG1O?=
 =?utf-8?B?YWlTb0RkdG9pbWFuVHVQVVhzNnVmSHlOY01FcVVQMmozN0hTZmROZXhYeWpy?=
 =?utf-8?B?OWkrNjNXWGNUUVVjY3R1VmR2RkJRVWVMK0JpcHo5bWJ1NDdHWVAyaTMzaDVj?=
 =?utf-8?B?S3BjeEcrT0h1OUFGWFZtdDVaV1ZzOSt5Tm82WFBiMkxaTlFnUGxHUU5oQ3R4?=
 =?utf-8?B?L1ZGVWxQdEU5d3ZucFpIOUVlb1Q2ZjJzamJKSkkzcDVtOGZXYnVrN0dTWDdz?=
 =?utf-8?B?b0JabDN5UEQrVkc2Uit5NE9PVnRpNVBvSmVTM0VOdHVINSttTmNhT0hJd3dw?=
 =?utf-8?B?SEttaStQc1BnLysxYnY1Mi9lVHlLRmJQNHo4YnJkL1V4V1dKYW8yT044VUZB?=
 =?utf-8?B?VTJVb3hoOEVWTU0vdTl3NVN4T2NTSWxRQ0poRGdNMXZzYTFoN3dWTU91aW94?=
 =?utf-8?B?eUdNajJUVEdQYW0rcE9XdHNZU2NHQlVoYTd4ZE1Bams4R2pDcmViQS9jZm16?=
 =?utf-8?B?RW1aL2hYRjJEMkFrMzJtRTdpNW92L2p6dnBGbWZxbVhGQS9yVVNJYmpIUWVN?=
 =?utf-8?B?UGR4RVhvM1VMS1hZc0JRZDZQeitnQ2pHeFVxakNON0M4MGpHS0REQ1lZUkhh?=
 =?utf-8?B?UGVVeUdudEpOazMxMy9WUWpFOWszVGJNR2VzK0ptQXg2MzdCMm5sZWpuZUEw?=
 =?utf-8?B?OXdoL2FrSnhSVUNHbnVPZ0lUZTkxL3lGNXNCNldtcGl3b2c0R3VBelZNUTlS?=
 =?utf-8?B?MGFWaUszcTUyK1draEcyY25qdUNZUHZTakQ4YzhJRzJENFBNOWU4V3JpYjVn?=
 =?utf-8?B?RUJwSkFQNGtTYnZHNGx0WWNsT0hxSVkvUVY1L2JQM0xzRDhLQkZaakZrWURn?=
 =?utf-8?B?TFE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5033740f-3775-4e4d-c4b2-08dc765b08ea
X-MS-Exchange-CrossTenant-AuthSource: MW5PR11MB5810.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2024 10:20:54.6692
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QaFuYBWOwmiUEdRBbwsTAV7P8OUTrrZyI1Zr+3dHi4ReU/kl4IEeAtWdhDGXkhf2BzMwfESBV/bR8ALYeZTmcDSFHBDGs8GZaFOv5JXkCQI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4866
X-OriginatorOrg: intel.com


On 5/16/2024 10:05 PM, Guilherme Giacomo Simoes wrote:
> in the dmesg is showing the message "failed to read out thermal zone"
> as if the temperature read is failed by don't find the thermal zone.
>
> After researching and debugging, I see that this specific error is
> occurrence because the thermal try read the temperature when is started,
> but the firmware is not running yet.
>
> For more legibiliti i create the NOTLOAD error code in the errno-base.h,
> and in the iwl_mvm_tzone_get_temp() on tt.c i check if firmware is
> running and I set the NOTLOAD code for ret variable and goto out.
>
> After this, in the update_temperature() in the thermal_code.c i received
> the return of thermal_zone_get_temp() and check if return is NOTLOAD,
> because if it is, I print the warning message "firmware yet not load"
> and return for caller
>
> The thermal_core.c i think that is generic for any thermal drivers and
> not only used for tt.c of course.
> But if this ipotetic driver not check if firmware is running before read
> the temperature, the thermal_code.c is work as a before this change.
>
> After this change, in my computer I compile and install kernel in /boot
> and in my dmesg the message "failed to read out thermal zone" is not
> show any more. In your place the warning messafe "Firmware yet not
> load" is showing.
>
> I would like to thank you in advance for any contribution, suggestion
> or criticism of my patch suggestion.
> ---
>   drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 10 ++++++++--
>   drivers/thermal/thermal_core.c              | 10 +++++++---
>   include/uapi/asm-generic/errno-base.h       |  1 +
>   3 files changed, 16 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> index 8083c4b2ab6b..dd5725db06d2 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> @@ -620,8 +620,14 @@ static int iwl_mvm_tzone_get_temp(struct thermal_zone_device *device,
>   
>   	mutex_lock(&mvm->mutex);
>   
> -	if (!iwl_mvm_firmware_running(mvm) ||
> -	    mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
> +	const int res = iwl_mvm_firmware_running(mvm);
> +
> +	if (!res) {
> +		ret = -NOTLOAD;
> +		goto out;
> +	}
> +
> +	if (mvm->fwrt.cur_fw_img != IWL_UCODE_REGULAR) {
>   		ret = -ENODATA;
>   		goto out;
>   	}
> diff --git a/drivers/thermal/thermal_core.c b/drivers/thermal/thermal_core.c
> index 34a31bc72023..4116d312d4a1 100644
> --- a/drivers/thermal/thermal_core.c
> +++ b/drivers/thermal/thermal_core.c
> @@ -414,10 +414,14 @@ static void handle_thermal_trip(struct thermal_zone_device *tz,
>   
>   static void update_temperature(struct thermal_zone_device *tz)
>   {
> -	int temp, ret;
> -
> -	ret = __thermal_zone_get_temp(tz, &temp);
> +	int temp;
> +	int ret = __thermal_zone_get_temp(tz, &temp);
>   	if (ret) {
> +		if (ret == -NOTLOAD) {
> +			pr_warn("Firmware yet not load");
> +			return;
> +		}
> +

The thermal core doesn't need to be modified for this.

Please print the new message from the driver and you may as well return 
-EAGAIN from it in all cases when the issue is expected to be 
intermittent to prevent the core from printing the (existing) warning 
message.

Thanks!


>   		if (ret != -EAGAIN)
>   			dev_warn(&tz->device,
>   				 "failed to read out thermal zone (%d)\n",
> diff --git a/include/uapi/asm-generic/errno-base.h b/include/uapi/asm-generic/errno-base.h
> index 9653140bff92..8b92c41f7993 100644
> --- a/include/uapi/asm-generic/errno-base.h
> +++ b/include/uapi/asm-generic/errno-base.h
> @@ -36,5 +36,6 @@
>   #define	EPIPE		32	/* Broken pipe */
>   #define	EDOM		33	/* Math argument out of domain of func */
>   #define	ERANGE		34	/* Math result not representable */
> +#define	NOTLOAD		35	/* Firmware yet not load */
>   
>   #endif