Received-SPF: pass (google.com: domain of linux-wireless+bounces-7781-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <38abf8474852d1f9b890e1a346f750b7b7b7682a.camel@sipsolutions.net>
Subject: Re: iw: alignment issue in print_he_capability() on arm926
From: Johannes Berg <johannes@sipsolutions.net>
To: admin LI <admin@hifiphile.com>, linux-wireless@vger.kernel.org
Date: Fri, 17 May 2024 13:22:33 +0200
In-Reply-To: <CA+GyqeZ976F6Zbcr5oo2_f_ECiy4tqb0vTjtSNtPexO07N-H4A@mail.gmail.com>
References: 
	<CA+GyqeZ976F6Zbcr5oo2_f_ECiy4tqb0vTjtSNtPexO07N-H4A@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-05-17 at 12:30 +0200, admin LI wrote:
> Hello, I'm using iw 5.16 with Yocto kirkstone 4.0.13, kernel 6.1.55 on
> SAM9G25 cpu.
>=20
> When I execute `iw wlan0 scan` kernel report many Alignment traps, looks =
like:
> Alignment trap: iw (6376) PC=3D0x00461ff8 Instr=3D0xe1f720b2
> Address=3D0x0048e771 FSR 0x001
> Alignment trap: iw (6376) PC=3D0x00461ff8 Instr=3D0xe1f720b2
> Address=3D0x0048e773 FSR 0x001
> Alignment trap: iw (6376) PC=3D0x004631c8 Instr=3D0xe1d420b0
> Address=3D0x0048e771 FSR 0x001
> Alignment trap: iw (6376) PC=3D0x00463190 Instr=3D0xe1d420b0
> Address=3D0x0048e771 FSR 0x001
>=20

Is that kind of thing not fixed up there? Does it even matter?

But I guess if we want to fix it, we'd really want something like
get_unaligned_le*() like in the kernel, not manually memcpy() in all the
code.

johannes