Received: by 2002:ab2:6816:0:b0:1f9:5764:f03e with SMTP id t22csp2397343lqo; Mon, 20 May 2024 04:53:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXBJqurP3vLqMRw6LIRJtL/RGCVjRKr5wg9Ej1/oLTe19ywe6BZV6WQRGCLvNAogncvyMAl45IkmR8HQi1yLB/bBjp7caN7VLdaCmNkUQ== X-Google-Smtp-Source: AGHT+IE+93r4pN/6QISyzkSebyncrqw7vQ+HKkP2vJzsh6QcKpS5EOHfb9W2tFUTLL1kAJwN///Z X-Received: by 2002:a05:6102:3ece:b0:47e:5c2e:5695 with SMTP id ada2fe7eead31-48077e45cc6mr28895554137.23.1716206037639; Mon, 20 May 2024 04:53:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716206037; cv=pass; d=google.com; s=arc-20160816; b=SW3uWYAXpmSqGme1qhO87Ot8uwHgjrVQAB/Q+LxXFLS9MJett48tta4w9DBob2F/9B eBS3dJti3nefBdq6/6Hi67J0N5aCc4MSGgeG5wxVwz9wTqSzalz/fLCZGPAoTZ0zJ3Gs 2vp2sa9QtYR79pqi+OrghbCqhr+s6yk4JDZmbWx9gFsk3dGAvKq1+31BmZ1syIXPdA22 UG2NqjRsoJuRoiOipejVO8LLsZQghpb3xHgUy3n0LjFS/TDdQgzS/RLfWLoE8lnDMD4s I/sxO4y0SVKAfJ3/ApFOLu9r4o2owqdE/pdnlGOAQm7pqhJoo5CPw7BnQpvBzR4dUZIo a30g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=l0Ec5iz9gumfwzfet9wOhb0ysPpkBmaxasJ9jxZiL3c=; fh=ydpKj2zZmvGdFfPpAFImtaLbrvlU9nC8QvxeZVQ9veg=; b=UrG5Y6mqn9J1mJXPz1LzyA1ruJlx7IXiRUZN6rl5lugRx1i9ZXCCQlKc1fBO99WKYS 3cDdUJ4T1O+RHeugrd/lsKrZ6C4gTeIK/mlHQXNU6uUCyksX8LGYKIj0GdWidTr8dpaK S9YP6gcnNiuhi4EeMFSqEgQcjh2TO43cjn5P+LQuBPHr7juVM5l3JHDD3wLfio5aJCbn pSAZO3JIKLDtwKXqtJ/G0otMNDDXJtWM2bDSCEe2KPb8nSeOdwWkrSXYMlT/w5JIDSjo GbekKlHDqdogbKS7I9NSv1sGKTOW27GaabnQxC6G6xmLQhNbc6eB/oVQl7IABop8ewk8 6PpA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fETqUVCP; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7842-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7842-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id d75a77b69052e-43df56dcd12si47718281cf.733.2024.05.20.04.53.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 04:53:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7842-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=fETqUVCP; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7842-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7842-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 48E281C20F32 for ; Mon, 20 May 2024 11:53:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AF39247F7A; Mon, 20 May 2024 11:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fETqUVCP" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83EB42744A; Mon, 20 May 2024 11:53:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716206033; cv=none; b=PcqQqjZdddnYgLzJBuqGiSuEqpet1ObGjYE/nwu9djhIzRETagSvXxdLKg4sFjCZtumjdVg3l5KEEYF+Uk8Dncc3vrAMKjOMDuaiZPMBMidku8SWWmZQR0kNeFl2uaNzjqHWJstKeIpD4j01pr+fyglR6OeG/tkCakYypFR9LdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716206033; c=relaxed/simple; bh=2WwHBbsRsDH0dHOTZXtm084FWAB/MmhOE+E7Q3OpKjs=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=b7Q6wWf2SSnN/GyBEY8F2EXy5EbYeDVd9nsM4wJR+TUNigOPJRGJg9hRw0DD143R+Km96XIoONl0o6pHebWQJ0J6mDrlDyYEfR/6Y5oS3G8XvquHPvGUsjrHOjLEfyPmITGYUd638v5pHSStM+WrojYhY9Hw/4fCSkfprCFmvkI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fETqUVCP; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 585C4C32786; Mon, 20 May 2024 11:53:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716206033; bh=2WwHBbsRsDH0dHOTZXtm084FWAB/MmhOE+E7Q3OpKjs=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=fETqUVCPRuxgPfRzBudNAVaSdOqbxPlZfQlxuTvVBHVaa1dcu8pLOoCY1ZA3U0DBu w7Gp1mhLekdmLP9UsT4dXD3YSHmSA8XD8GT0qTyzcfSOeC3L/m+L8QgORrherbCGFN TVcVE14YFlQ+pr59tR6z5tjhF2MiRZbdWFdOUiCL6v0xvtDEMLcGfCu8I1SvRlc521 5pcoIpFJPwDFsiny3XgqIAuQs0oRZOPu91GbyszpI6ypnbSZPNk4bhl1i73cDA+NP2 pCRyyYevtGZO4wlM+KDUN1tf3SM9HdNx/5evmynHsjLJT8ANMJwJAhwLC2pyOhNkX6 /+pRS7xnOQVPw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath10k: fix QCOM_RPROC_COMMON dependency From: Kalle Valo In-Reply-To: <20240511-ath10k-snoc-dep-v1-1-9666e3af5c27@linaro.org> References: <20240511-ath10k-snoc-dep-v1-1-9666e3af5c27@linaro.org> To: Dmitry Baryshkov Cc: Jeff Johnson , Stephen Boyd , Rakesh Pillai , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171620602925.3753090.14163848910895303019.kvalo@kernel.org> Date: Mon, 20 May 2024 11:53:51 +0000 (UTC) Dmitry Baryshkov wrote: > If ath10k_snoc is built-in, while Qualcomm remoteprocs are built as > modules, compilation fails with: > > /usr/bin/aarch64-linux-gnu-ld: drivers/net/wireless/ath/ath10k/snoc.o: in function `ath10k_modem_init': > drivers/net/wireless/ath/ath10k/snoc.c:1534: undefined reference to `qcom_register_ssr_notifier' > /usr/bin/aarch64-linux-gnu-ld: drivers/net/wireless/ath/ath10k/snoc.o: in function `ath10k_modem_deinit': > drivers/net/wireless/ath/ath10k/snoc.c:1551: undefined reference to `qcom_unregister_ssr_notifier' > > Add corresponding dependency to ATH10K_SNOC Kconfig entry so that it's > built as module if QCOM_RPROC_COMMON is built as module too. > > Fixes: 747ff7d3d742 ("ath10k: Don't always treat modem stop events as crashes") > Cc: stable@vger.kernel.org > Signed-off-by: Dmitry Baryshkov > Signed-off-by: Kalle Valo Patch applied to ath-current branch of ath.git, thanks. 21ae74e1bf18 wifi: ath10k: fix QCOM_RPROC_COMMON dependency -- https://patchwork.kernel.org/project/linux-wireless/patch/20240511-ath10k-snoc-dep-v1-1-9666e3af5c27@linaro.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches