Received-SPF: pass (google.com: domain of linux-wireless+bounces-7846-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <daf3e4248061c21db623be84136f3da1da5de513.camel@sipsolutions.net>
Subject: Re: [WARNING] memcpy: detected field-spanning write (size 1005) of
 single field "&out_cmd->cmd.payload" at
 drivers/net/wireless/intel/iwlegacy/common.c:3173 (size 320)
From: Johannes Berg <johannes@sipsolutions.net>
To: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: Kees Cook <keescook@chromium.org>, "Gustavo A. R. Silva"
	 <gustavoars@kernel.org>, Xose Vazquez Perez <xose.vazquez@gmail.com>, 
	linux-wireless@vger.kernel.org, linux-hardening@vger.kernel.org
Date: Mon, 20 May 2024 17:10:18 +0200
In-Reply-To: <20240520150857.GA709412@wp.pl>
References: <2c534d01-449a-43f4-9216-eacdb3b35577@gmail.com>
	 <20240518092939.GA643846@wp.pl> <202405181033.6399B7E416@keescook>
	 <20240520073210.GA693073@wp.pl>
	 <95f3e147de837b4833e6cf6eb67108f96640af4e.camel@sipsolutions.net>
	 <20240520150857.GA709412@wp.pl>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-05-20 at 17:08 +0200, Stanislaw Gruszka wrote:
> >=20
> > I don't think this is right, now the raw comes after
> > DEF_CMD_PAYLOAD_SIZE? You want it to be a union with payload, I'd think=
.
>=20
> Not sure if I understand. I think we have union with payload with=20
> the patch. The structure looks like this:
>=20
> struct il_device_cmd {
> 	struct il_cmd_header hdr;	/* uCode API */
> 	union {
> 		u32 flags;
> 		u8 val8;
> 		u16 val16;
> 		u32 val32;
> 		struct il_tx_cmd tx;
> 		u8 payload[DEF_CMD_PAYLOAD_SIZE];
> 		DECLARE_FLEX_ARRAY(u8, raw);
> 	} __packed cmd;
> } __packed;
>=20

Oh, sorry, my bad. I confused the tx_cmd and the cmd_header.

johannes