Received-SPF: pass (google.com: domain of linux-wireless+bounces-7856-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <b6b23a29-78ef-4e4f-8042-e13833fcb1ec@quicinc.com>
Date: Tue, 21 May 2024 09:52:06 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] wifi: ath11k: move power type check to ASSOC stage
 when connecting to 6 GHz AP
To: Kalle Valo <kvalo@kernel.org>
CC: <ath11k@lists.infradead.org>, <linux-wireless@vger.kernel.org>,
        <regressions@lists.linux.dev>
References: <20240424064019.4847-1-quic_bqiang@quicinc.com>
 <87wmo0k71i.fsf@kernel.org>
 <3dc28f34-45cc-4e14-b9ea-1f7b78a6a591@quicinc.com>
 <87h6esebu8.fsf@kernel.org>
Content-Language: en-US
From: Baochen Qiang <quic_bqiang@quicinc.com>
In-Reply-To: <87h6esebu8.fsf@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 5/20/2024 11:34 PM, Kalle Valo wrote:
> Baochen Qiang <quic_bqiang@quicinc.com> writes:
> 
>> On 5/11/2024 5:54 PM, Kalle Valo wrote:
>>> Baochen Qiang <quic_bqiang@quicinc.com> writes:
>>>
>>>> With commit bc8a0fac8677 ("wifi: mac80211: don't set bss_conf in parsing")
>>>> ath11k fails to connect to 6 GHz AP.
>>>>
>>>> This is because currently ath11k checks AP's power type in
>>>> ath11k_mac_op_assign_vif_chanctx() which would be called in AUTH stage.
>>>> However with above commit power type is not available until ASSOC stage.
>>>> As a result power type check fails and therefore connection fails.
>>>>
>>>> Fix this by moving power type check to ASSOC stage, also move regulatory
>>>> rules update there because it depends on power type.
>>>>
>>>> Tested-on: WCN6855 hw2.0 PCI
>>>> WLAN.HSP.1.1-03125-QCAHSPSWPL_V1_V2_SILICONZ_LITE-3.6510.30
>>>>
>>>> Fixes: bc8a0fac8677 ("wifi: mac80211: don't set bss_conf in parsing")
>>>> Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com>
>>>
>>> Oh, this fell through the cracks. Commit bc8a0fac8677 was introduced in
>>> v6.9-rc1 so I should have sent this to v6.9 but it's too late now. I'll
>>> need to queue this for v6.10 via wireless tree.
>>>
>>> Adding the regression also to regzbot:
>>>
>>> #regzbot introduced: bc8a0fac8677
>>> #regzbot title: ath11k: connection to 6 GHz AP fails
>>>
>> Hi Kalle, with an upcoming patch this regression is expected to be fixed:
>>
>> https://lore.kernel.org/all/20240506214536.310434f55f76.I6aca291ee06265e3f63e0f9024ba19a850b53a33@changeid/#t
>>
>> So here the ath11k fix would not be needed any more once above patch got merged.
> 
> What happens if we apply both patch 'wifi: ath11k: move power type check
> to ASSOC stage when connecting to 6 GHz AP' and patchset 'wifi:
> mac80211: build TPE handling'? In other words, do they conflict from
> functionality point of view?
No functional conflict, 6 GHz AP connection would also succeed with both of them applied.

> 
> I ask because I suspect Johannes is planning to take patchset 'wifi:
> mac80211: build TPE handling' to v6.11 but we should fix the ath11k bug
> in v6.10.
> 
>> But I don't have time to test this, so suggest keeping it pending. We
>> could drop it once above analysis got verified.
> 
> BTW for some this patch wasn't in the pending branch but it's there now.
>