Received-SPF: pass (google.com: domain of linux-wireless+bounces-7939-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 22 May 2024 01:54:24 -0700
From: Breno Leitao <leitao@debian.org>
To: michael.nemanov@ti.com
Cc: Kalle Valo <kvalo@kernel.org>, Johannes Berg <johannes.berg@intel.com>,
	Justin Stitt <justinstitt@google.com>,
	Kees Cook <keescook@chromium.org>, linux-wireless@vger.kernel.org,
	linux-kernel@vger.kernel.org, Sabeeh Khan <sabeeh-khan@ti.com>
Subject: Re: [PATCH 07/17] Add boot.c, boot.h
Message-ID: <Zk2ywFQQ2SuXvPiE@gmail.com>
References: <20240521171841.884576-1-michael.nemanov@ti.com>
 <20240521171841.884576-8-michael.nemanov@ti.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240521171841.884576-8-michael.nemanov@ti.com>

Hello Michael,

On Tue, May 21, 2024 at 08:18:31PM +0300, michael.nemanov@ti.com wrote:
> From: Michael Nemanov <Michael.Nemanov@ti.com>

> +static u8 *fetch_container(struct cc33xx *cc, const char *container_name,
> +			   size_t *container_len)
> +{
> +	u8 *container_data = NULL;
> +	const struct firmware *container;
> +	int ret;
> +
> +	ret = request_firmware(&container, container_name, cc->dev);
> +
> +	if (ret < 0) {
> +		cc33xx_error("could not get container %s: (%d)",
> +			     container_name, ret);
> +		return NULL;
> +	}
> +
> +	if (container->size % 4) {
> +		cc33xx_error("container size is not word-aligned: %zu",
> +			     container->size);
> +		goto out;
> +	}
> +
> +	*container_len = container->size;
> +	container_data = vmalloc(container->size);


I got the following error when compiling it:


	drivers/net/wireless/ti/cc33xx/boot.c: In function ‘fetch_container’:
	drivers/net/wireless/ti/cc33xx/boot.c:76:26: error: implicit declaration of function ‘vmalloc’; did you mean ‘kmalloc’? [-Werror=implicit-function-declaration]
	   76 |         container_data = vmalloc(container->size);
	      |                          ^~~~~~~
	      |                          kmalloc
	drivers/net/wireless/ti/cc33xx/boot.c:76:24: warning: assignment to ‘u8 *’ {aka ‘unsigned char *’} from ‘int’ makes pointer from integer without a cast [-Wint-conversion]
	   76 |         container_data = vmalloc(container->size);