Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp229030lqp; Wed, 22 May 2024 02:48:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWT3hZVG57/pt1shlg1902uUMy6dQGAnPTME8IIFU7Vf8BfzmMTU8L+LoLABMpOnyhOCrt/uzOgIIVQaU3LeadZZIDxsykrPAxXiNFLLQ== X-Google-Smtp-Source: AGHT+IEhw1Fhx6x1clNij7MA/AU1VqIbknhWs+ewDrMB9cEYHZSDbKs9eza+kF08sELrUoYdPOAK X-Received: by 2002:a05:6358:ce30:b0:18a:6074:90d1 with SMTP id e5c5f4694b2df-19791f23c3cmr109980155d.19.1716371315943; Wed, 22 May 2024 02:48:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716371315; cv=pass; d=google.com; s=arc-20160816; b=DL4aatpRWHCcn5sPZyxBZyoabsKXT6e0UbcL7fzhyIHftUMnaWwJKSv/rpQD5vPsQy SU+5q2KOc7ZatwB4B86O6gDSjxW53dV4uCtWpYsnnURkDbUDh/aABoCA1DfvhaSYGeEc Loj0NYBps6KLY1I9Te4EN9C/kPXpNNtLXOt5va0DqrEaODNNFhXZ2pdeXmJTUAt92ExQ lJhUrZpBWIH3mAu7PYSjqlWA0aHrhgHBhv4dacMvtlOu3a90doJ881T9A0k/fsRapixm N/dcF5Sswckz8ZP/A1IjIO1DNRCSItu0GfDUtv9/HI0UO2UudNnJcfxwGjekXOPfHloP WJxA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=nojNmPJuMDSnDj5VFW6or962lMELlYx6jIZEtw6/yIU=; fh=im08E34AWLD5qd+vL1UkCr2ikDiGGNzKmHMFHETFq44=; b=nAcTMlmZXlPyLilBQTGAidHO30F6PtYgYDYAIT7/1Cw+vPOm/DSkM6Z8D2b1817wGK 6eW/GKkPKItGVP9HxzHOj8hbIjbAX8zRP6woV6mnmQ4Jl9kYcO6f9NifGKWfCAVL/RBC xVvuXQdmDS76/1eydbAgQYqNRfdQ2/zsD10Ybb6DYTYT2RO1I7Jq1vsL2+C5P4Y2bHfX tbYVBDmRxFjFHaGt9QgjsnCDgP1B7MeDyznPDisAscy0QcS+PBW8hGmX/F9wCpbwwRdB nWDIWDuKy4DKessnf9hlEsRJuWKrPF1O2pcSr3BLVn6v4cOI7Wwq2Ww8dLFEtQOf1qfB aLlQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FbSdrfix; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7944-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7944-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6340a06c019si2135039a12.53.2024.05.22.02.48.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 02:48:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7944-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FbSdrfix; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7944-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7944-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 052A6B21542 for ; Wed, 22 May 2024 09:48:33 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7344E81205; Wed, 22 May 2024 09:48:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FbSdrfix" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47F927FBC4; Wed, 22 May 2024 09:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716371306; cv=none; b=iRU6DDoVYLapvhzBd0gZ9j/BN6AKdR6qkUbjgcOCWMvgUV7X4hCESA0KCuhnaaLeC8gj8SXyXize8zE4+B8Rci05bG8J78dlYVlHWO6MlYdDLezmt4zxljuJGVpyDXKqLl19ZeJcdfH9YEjAYpy4UDPmvyW0F+iwqoUVt4u3LWk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716371306; c=relaxed/simple; bh=/A+2rEaKBi9epBCJjIefmjc41BvDF/ytebGMy2XwfzM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RiXt+jHcA15092HP+X1UvowuTQV+zAMRMyA/NP9Cybdv3gbyjEN1TI0pELCLZlEdCbTp/XCFszF3BGuOITKI6uF8BLLGnygAC9g77LQIWEkIoCRsdFfrHuUs23276JfPpySX8QSR90lmlqF+AUQE5VGCWRFKi2J/8ESko4AlhSI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FbSdrfix; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71EDCC2BD11; Wed, 22 May 2024 09:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716371305; bh=/A+2rEaKBi9epBCJjIefmjc41BvDF/ytebGMy2XwfzM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FbSdrfixTttm+tOs/ketpEpf1ff3r+YRWOBKeJjDzHPUkvo3/hLXme5WpzQX4nF0G q60MNy+2mJOTbBCdhsPQwZykaZVf7XG1smUm5TlEdKf5qh+5Tt8071Xg4oOArKXnmM 9OG1iQPGhPaTd5j0YxPYZSpmho8g7O9IlpP5cAEWiE6r6zBl/lwE0LmeULvsLnIWMq 5qlTCIWHUmAz2z5GFEXVwo2MH8FyMfZF/5IIlDI4sm6xmIKKtoe3daTnB6KUfObf2v 5w0WxTQSTz7LAA+BNkG5kUcEKGtRCHdIWA4iH0aukwD9vJZIk2m6v8XVEZFlP51yDc l0fW7bAHI9WaA== Message-ID: <9ba9d156-ce38-47ba-b0fb-63e6174c3094@kernel.org> Date: Wed, 22 May 2024 11:48:20 +0200 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/17] Add conf.h To: michael.nemanov@ti.com, Kalle Valo , Johannes Berg , Breno Leitao , Justin Stitt , Kees Cook , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Sabeeh Khan References: <20240521171841.884576-1-michael.nemanov@ti.com> <20240521171841.884576-14-michael.nemanov@ti.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240521171841.884576-14-michael.nemanov@ti.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/05/2024 19:18, michael.nemanov@ti.com wrote: > From: Michael Nemanov > > Various HW / FW / Driver controls unique for the CC33xx that > can be set by OEMs. > > Signed-off-by: Michael Nemanov > --- > drivers/net/wireless/ti/cc33xx/conf.h | 1246 +++++++++++++++++++++++++ So you are adding one file by another? This does not help review. Add logical chunks, e.g. users of header after the header. Or all headers together. Or some features incrementally, like basic working driver and then feature foo and bar. Best regards, Krzysztof