Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp598932lqp; Wed, 22 May 2024 13:42:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUbNhy/Wto3bYvGFe1tSv57lOvp+2pVhKYyjLxwi9HQHcbwRbqbCyI+Wf3Y4nXph2b7NyzLIPetHoBPA51QS4Pz+JHBDj4kR0mF2U6d4w== X-Google-Smtp-Source: AGHT+IGMp7wCgd4rZzZWaWT+3JUMDYSHY+0pwgajNbnUJUmHE5nX6Q9307cD1095ScV/ofkGTivZ X-Received: by 2002:a05:6a21:3949:b0:1af:b1c0:c9eb with SMTP id adf61e73a8af0-1b1f8a21f46mr3888466637.45.1716410570940; Wed, 22 May 2024 13:42:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716410570; cv=pass; d=google.com; s=arc-20160816; b=FC6YetQcTLsPnrGFdafdZznTiRuMblF/8EGDko6zxlU0HtVwt1JeTMwVwV4aUSAorW n7hjB+R+8csmf6K0q3nZYdImg/gVABGbAyGMqyHwZaUzTJ0LJXlwqb6IwYandhskm9x3 mTVIex2mFUn76Ynk358Gb6nUT6WY/B6OGlHJ45qPfGpat/RuQp5JB8Coac/0x+nsbd8i AC+/jCefEP207GnecvdE0kSY7Ax+BuPw1Mxg9lFUAuR94q9HUan8i1p1mCB4mHp0EMhk smSUZ3g+Z+2C6db1jliwDF2h3u7mebcZxBXJA2h3+RKEuN+FP+wIV138cg0HV15Izdiy 3UaQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=PCB4Xldgcwvrmyw7KvTXZs/6ZjPvLBzZXr/4OPpupIs=; fh=tCarsZjPnZPKmHEg+MbRzPcpUHKy4U7Q7uWXrY2ggg4=; b=MEHlQIqW0RNoekdio8H9SGvSclVJdvJi+SZLDINvNizvXB5BXGJNB+pOuV5MqTIXmz Rm0GdQuF+nGS0XxPjIWY8M5Wzd7MJgZAGdGwJSmskdQmTT6jhVyTvOin/3iLn9urRWKN aPNU1Jhx9KFen/S3PFJ0h9oEpQMoFNPZC2agcmVYNCZu1s0HE28LyCDKwfUz86Cs6PIg /NiMlWmiCKaK/t5y5hSOwaZuF/LzaRqbMq+zBkJ1PJDctdzZeVhDW6Sg3zZdLuQSlO3i XqoMO7CQEL/2xydsKG4yG7vIs2dAs8Q5JgdkpSLx4vUUeZztoIDUU4/AOb+Xb+dL2U4/ 8hDg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KTU6CVYL; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-wireless+bounces-7966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7966-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f33d2ca98dsi229475ad.323.2024.05.22.13.42.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 13:42:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=KTU6CVYL; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-wireless+bounces-7966-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7966-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 42E21282E1E for ; Wed, 22 May 2024 20:42:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 434D81465A2; Wed, 22 May 2024 20:42:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KTU6CVYL" X-Original-To: linux-wireless@vger.kernel.org Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 763627E777 for ; Wed, 22 May 2024 20:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716410566; cv=none; b=kLLc4s+79a15cdthFURpfniavkwHaZ6dJoB3c9OZaem6XsmLTRN1K1y8DaPawileNwwV/IFY0CKQ+CgKqIhPKaqh2braJvRdNxpcnTcxQX0yH5aIae+DsI0hVd+fZwI06a5dYPh2Df2wcXlGAxbxP9L3gIMmOVBarv+xM8cQnto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716410566; c=relaxed/simple; bh=GH8a9YWFjmrvE5LV9apSXfEDSz8b8pwNnV3zU4znXIk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=a+WpimIL63abD8kIcaYtnV7zqVcsOwBKMaR1jgm5U5MT8NiEeHry57l/k5i9slW/dG/IzB8CAiBM9Zokh/lk+fsHmCkBNFUzHbZi3JZbRMs9V9yICQItvODz0/mlxhJhRGREV3eguQZ1ZOTeM6/ZM+yu4Qdafyx8u1x4lBlhXw0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KTU6CVYL; arc=none smtp.client-ip=209.85.128.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-620390308e5so16470497b3.3 for ; Wed, 22 May 2024 13:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1716410563; x=1717015363; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PCB4Xldgcwvrmyw7KvTXZs/6ZjPvLBzZXr/4OPpupIs=; b=KTU6CVYLyEATrzqPoDlRe81jkONpUZQfTqrSHK+794YzxEiXFuG2VTSG/evcZ9AtpZ HtJg8yrNyGIwW4JAgHPO29fq8j6oFQAV3QkC8NYFmw/b+OkVADUboLNUa1HbkKu/PWgv Ua0LW5MCUBFLdrIqSXkd3Ex4qmiYk9r9T05IFZmcYqYA2wGCk+FDZIu/hEzCqEYhhXyX 4zp8Y/60Pmyoq04o0buvOjwRx5LPqnXLOUHBFhUl6XIBC2mHQPdLA/JzBo48KA5aMXbL 4kSaUrpqvT2m1iDdjhibZGEFMIZNQ7uckR+8bvAY/sdUNBKBI7IpSjq7Is3JuaOe9M96 Ig4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716410563; x=1717015363; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PCB4Xldgcwvrmyw7KvTXZs/6ZjPvLBzZXr/4OPpupIs=; b=e8qRW9b+THphsgHs7EkSDdiOH37bEUQwDso3R1szSRMINzUoG/MB64WZn44Gvn6LxK cCekwCsE2JDtAkJF6l51T617UyDBu+n+o1w6Z98oQXVoQs0W20MyX3tAt8AqZHBxTF4s KgZGNyhiRgPNAhiHGdLUSZ2HPTzUCyhKjw1H0CYJ78LFcMTxFcb1IhJMTsIeT/nypW2x rfw6cxQ0bVc1hhGe+mU4rZx99bsAN6p+c+R0nu80MQ0qKdina3mhwEoUnk8DN/rddIV4 kH+JvLBrztPLYPx6HzefroRmA7piqiCb0P+hE9AOkoGFtNk/0iREcnA3isSBjoIiqYYD YUqA== X-Forwarded-Encrypted: i=1; AJvYcCUioav5qczesTck6SEU0/egalTwy5obK/YjH38F6QUPTzHsCN10jH/DKieyUSSJcUC3sky6IUK3nfdIoxoyctkEue+g0CGNuI7NI9Sx3GU= X-Gm-Message-State: AOJu0YwbxvaXwxKyI30vTTZZvTK8nZ1KfxjQDqZCoNEGRIHUgQ0ztbvw MzIFtwOFoWDughoU3cY5CavvbtRzIkJebcyVIUK/O74EmWI0p7VW9t1uKWnqBz8Gvw81DEeOYCU nY+lmuPYcs4HDcWP+LitQWb/bi5POa/+t8kMY3w== X-Received: by 2002:a05:690c:f07:b0:61b:e643:58c7 with SMTP id 00721157ae682-627e472b21fmr40846087b3.28.1716410562525; Wed, 22 May 2024 13:42:42 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240521-qcom-firmware-name-v1-0-99a6d32b1e5e@linaro.org> <20240521-qcom-firmware-name-v1-9-99a6d32b1e5e@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Wed, 22 May 2024 23:42:31 +0300 Message-ID: Subject: Re: [PATCH 09/12] remoteproc: qcom_wcnss: make use of QCOM_FW_HELPER To: Jeff Johnson Cc: Bjorn Andersson , Konrad Dybcio , Loic Poulain , Kalle Valo , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Arnd Bergmann Content-Type: text/plain; charset="UTF-8" On Wed, 22 May 2024 at 22:22, Jeff Johnson wrote: > > On 5/21/2024 2:45 AM, Dmitry Baryshkov wrote: > > Make the driver use qcom_fw_helper to autodetect the path to the > > calibration data file. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/remoteproc/qcom_wcnss.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/drivers/remoteproc/qcom_wcnss.c b/drivers/remoteproc/qcom_wcnss.c > > index 421a3943a90d..45fc578ae30b 100644 > > --- a/drivers/remoteproc/qcom_wcnss.c > > +++ b/drivers/remoteproc/qcom_wcnss.c > > @@ -23,6 +23,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > > > @@ -555,8 +556,13 @@ static int wcnss_probe(struct platform_device *pdev) > > if (ret < 0 && ret != -EINVAL) > > return ret; > > > > + fw_name = qcom_get_board_fw(fw_name); > > + if (!fw_name) > > + return -ENOMEM; > > + > > rproc = devm_rproc_alloc(&pdev->dev, pdev->name, &wcnss_ops, > > fw_name, sizeof(*wcnss)); > > + kfree(fw_name); > > if (!rproc) { > > dev_err(&pdev->dev, "unable to allocate remoteproc\n"); > > return -ENOMEM; > > > > can you cleanly bisect to this patch? seems it depends upon patch 10. > should 09 & 10 be swapped, or perhaps squashed? Yes. I think I got this mixed during rebasing and squashing of the changes. For v2, if the approach is found to be generally acceptable, I'll squash them. -- With best wishes Dmitry