Received-SPF: pass (google.com: domain of linux-wireless+bounces-7982-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Ping-Ke Shih <pkshih@realtek.com>, <linux-wireless@vger.kernel.org>
CC: <gary.chang@realtek.com>, <phhuang@realtek.com>
Subject: Re: [PATCH v2] wifi: rtw89: fix HW scan not aborting properly
In-Reply-To: <20240517013350.11278-1-pkshih@realtek.com>
References: <20240517013350.11278-1-pkshih@realtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain
Message-ID: <1c6bb047-c474-43d5-8d0c-37bc2657e2f2@RTEXMBS04.realtek.com.tw>
Date: Thu, 23 May 2024 11:32:27 +0800

Ping-Ke Shih <pkshih@realtek.com> wrote:

> From: Po-Hao Huang <phhuang@realtek.com>
> 
> There is a length limit on the commands we send to firmware, so
> dividing to two commands is sometimes required when scanning.
> When aborting scan, we should not send second scan command to
> firmware after the first one is finished. This could cause some
> unexpected errors when we cannot receive firmware events
> (e.g. in suspend).
> 
> Another case is scan happens before suspending, ieee80211_do_stop() is
> called to abort scan and driver indicate scan completion by
> ieee80211_scan_completed(), which queues event to scan work. But scan work
> might be late to execute after ieee80211_do_stop(). To correct this, driver
> indicates ieee80211_scan_completed() before returning, so that
> ieee80211_do_stop() can flush scan work properly.
> 
> Fixes: bcbefbd032df ("wifi: rtw89: add wait/completion for abort scan")
> Cc: stable@vger.kernel.org
> Co-developed-by: Chih-Kang Chang <gary.chang@realtek.com>
> Signed-off-by: Chih-Kang Chang <gary.chang@realtek.com>
> Signed-off-by: Po-Hao Huang <phhuang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

669b692247d4 wifi: rtw89: fix HW scan not aborting properly

---
https://github.com/pkshih/rtw.git