Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp815231lqp; Thu, 23 May 2024 00:08:59 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVfRxMlNRCCxlclQaV++MuH601x6/27gH8KAj7+yhYSzsib06jPT/kLWSN+/3s16hP+nmw6dhTFjdANaNqyw8VzKTwWAxlcj0K+TMcp8g== X-Google-Smtp-Source: AGHT+IFL8XmGx8+m3UkSLzJeCbcfMGaliVMDOqYl1fORNOoxKzlp296jLrgbyBNx9bHV8FwJ6cas X-Received: by 2002:a50:a6ce:0:b0:56e:10d3:85e3 with SMTP id 4fb4d7f45d1cf-57832a4a1fcmr3164938a12.13.1716448139631; Thu, 23 May 2024 00:08:59 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716448139; cv=pass; d=google.com; s=arc-20160816; b=ZX+csNC5ORs1VS3mJrlEDGppuCdQtx6u6V8g5tiphsH9FVugRyhSb4IfPFgyJft+k8 zDIaYFNtExe+JwBVZpu3NMKkxQEz1VoivU0UO8CeGI6l/t9ndnqT8hK7uIbFTomQpOeo cUEZUuzfhq23PszDJSmq4w8mp0Rrk3WILC+OB88zj/tlZOwzHTvf82+vCmyKEMVt8l5W fzTysgIAEvdwC9cEs3A4CxUnc63Kcpd2ShQZZB+7SMkmLl7FUaf0SVSI+WOGDpWW1jq/ bYk87qtFezOgjoSbmb7xEReBt1+nXAYgiqDYnxJhu70eJ5l+OWj4tlXyeVn7iMMkAPgB vhaw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=3CG++QfVBQwmCxoxuz6KmV8osmhJ/Zqo56H3LVrUhH8=; fh=VxF4AbtdcIT2xjy1mEkYp8Zdz38fuGhCGBFWle9qH6A=; b=PwwxUSUeEGYoxqp9gE/M2KRTjxJhDfm/o+Ommi0EsPj+sj6GH3E8Z2exNoFM7MFtFq 6IOIskNosUifiJATP4F0LO0HAQ6ceZsb5l0q7mp0sRRNK9l2JZXOhJTrfxcTy71nut6E Akd5AdB5llAc1Pp8IllgysQPG8Gi4yyxTqQegY8YDtAPyM7L9UeanWEOVPiA1vwU6F/6 9txSYxzRWpKiBcwpCwrqNTbQz+BPlmfpa05ChiszwVrTJzZ4Hp6ndRAbPgg24s72r8eu NQbs/GjnYhYdbaZ2qIqBXChQ4YAim1tmiRPKTRpp619oqC55v5VngrWEuNreJWwnU4n6 w/lw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l63V8xgk; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7985-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7985-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57827a67ffcsi2056428a12.494.2024.05.23.00.08.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 00:08:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7985-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=l63V8xgk; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7985-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7985-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5D1351F21B66 for ; Thu, 23 May 2024 07:08:59 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DC7C113C9C4; Thu, 23 May 2024 07:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="l63V8xgk" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B238613C9BE; Thu, 23 May 2024 07:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716448134; cv=none; b=YK2jwV045KlG/wMNdB2H9I7szHsengGnLSoiF184YnNKtH1fONKK/ImQgcQMau4xZrrNScH8li8HQO/RsvSaIW65WwpKI2xwKu6Z44TIs627jPaB4zpEo5pBel5vfRVdwhATSMLAHh33a813YNKfHNjWzW4BYd0k21H9Mx3RKo4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716448134; c=relaxed/simple; bh=elwm805QhpZ+JSQ57a0ibr5IqKEmbzKJWPEUZdsebmw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=dK/zOTtfqIItIVOoziYH/CGqvXkppJfF0j6Zos4aKV+7eZ+XoI1UVSBGT7yyIM8++JhqEZ8ioUjC5zf6RBsnIaBUc1dGM8Y/VDqNf2Ns6+nn3UILF+hc/181y0/bJJtHCPorNj7fsnzbi4kTzOFVFaHyDCuSiMy1d51RQFSy1qw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=l63V8xgk; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 410BBC2BD10; Thu, 23 May 2024 07:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716448134; bh=elwm805QhpZ+JSQ57a0ibr5IqKEmbzKJWPEUZdsebmw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=l63V8xgkLsin9j/UsHEcUmVjXnzjfiGdErSNS+oVeeGFrpFugjuh4UK37h6Yjhlxj czy4pMnIc5RnMYPB8rnUWVCWz2JX+rz4intjIUALmpK+Yvpu/so8YbEsj5ZUeXjeAS qLJGbkxNKx/5U1LTfOE5f0HkFBiXKJJfRTTWsD2DtrqJ6kh76BD01V1c8taxtSRy/f 4aVWLboQd530xEOtCGW3J8tnW5+MCR+hX1xuvQwkSXDqFmNGF6M1AndjXKhMiPFfcA mfMarDezHDRT7DMqueb1K9eH6I8OXkqcDStKYF7qsCAx02JHxHERSP+z+9oRXFwGm0 jPe0MsPjYGyPw== From: Kalle Valo To: Krzysztof Kozlowski Cc: michael.nemanov@ti.com, Johannes Berg , Breno Leitao , Justin Stitt , Kees Cook , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Sabeeh Khan Subject: Re: [PATCH 13/17] Add conf.h References: <20240521171841.884576-1-michael.nemanov@ti.com> <20240521171841.884576-14-michael.nemanov@ti.com> <9ba9d156-ce38-47ba-b0fb-63e6174c3094@kernel.org> Date: Thu, 23 May 2024 10:08:50 +0300 In-Reply-To: <9ba9d156-ce38-47ba-b0fb-63e6174c3094@kernel.org> (Krzysztof Kozlowski's message of "Wed, 22 May 2024 11:48:20 +0200") Message-ID: <87r0dtattp.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Krzysztof Kozlowski writes: > On 21/05/2024 19:18, michael.nemanov@ti.com wrote: >> From: Michael Nemanov >> >> Various HW / FW / Driver controls unique for the CC33xx that >> can be set by OEMs. >> >> Signed-off-by: Michael Nemanov >> --- >> drivers/net/wireless/ti/cc33xx/conf.h | 1246 +++++++++++++++++++++++++ > > So you are adding one file by another? This does not help review. > > Add logical chunks, e.g. users of header after the header. Or all > headers together. Or some features incrementally, like basic working > driver and then feature foo and bar. For new wireless drivers my recommendation has been to submit for review one file per patch but the final driver to be commited would be just one patch: https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#new_driver -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches