Received: by 2002:ab2:7855:0:b0:1f9:5764:f03e with SMTP id m21csp817788lqp; Thu, 23 May 2024 00:15:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUvLGjnAu3YxUmvAnBj4JF5u7vN0w3dkefd2asbSLTK0DN8Z+0/1YwP8B77xH0K82xpwC9CPko/TV7pFKgfmsFJJ67CkvJMFGWUNMkFQA== X-Google-Smtp-Source: AGHT+IErOM7ECJMN67Kh4NxgS0Ed05Z7JA8YBLkx93qSqZikwurawIXa8TAgwXYTI+VxX6WlnK63 X-Received: by 2002:a25:213:0:b0:df4:d689:bd23 with SMTP id 3f1490d57ef6-df4e0a891ebmr4272413276.13.1716448541369; Thu, 23 May 2024 00:15:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716448541; cv=pass; d=google.com; s=arc-20160816; b=Q6kVsJ/qJMfcwc6zpVMNlhlE93vXbpzCHKP/Vhusy7MgHAw3BGmeIHtr3Ej6zRErgg AcXHBRLS1QoloEhbi+5s4M+3pdy+UDoPZEX5Uf86Ke+vbW5Q6uLjRPHrQJyJ73WY7VtG Uj7OoWJjr3NGdV8n/jgdKaRuHPC9Dlx8DBqogpwBUI6dc4/kDY9t5jk4xmb7MipA7eab vefqqc18qUpOygzpKbbNq76xrkGXY5c+0PTZZDKptWAo1TXVl/ML2y6sVpb7s0pvtEAO uyBLpiz0gawWKCIpLF6mirTV86LbIhsZ79SZ1Xq2+3ZYUsFbHBqqcpEyMJKNsWhTSs/Q qOoA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=C0UZ12xaIHseSzUHKtLZ9K1EgyOvt6zDleEQ7TfkDU8=; fh=FgE+5TQ/WZtuM/oZ/Mn++wdg7InnCPaHcKi5txpJIew=; b=WQ89ZX+zNrcH/Kc1gGLsYkebfkd1Li6k/IUoOfHVdmgcYTACMX+Ru8pS2Efb/3YLWl 0jTcXkQEptekBEgWtK5HwLMe1xu3XkdBt1xWsNyuL1YOr4oRfiavWFsEP8HDa9bTVGpt 0VPO7yQdF7eebNt62DtGJF4llMnd7fDaD57ccJ0SkfhyJXXuI3KaKtWy94jLdnzvRHAi xZpL0bajcRM2SMNgFgKbQoe1wFn28suTdJIOCJc4DJWI5EhcviB0CbVLS58ehcxX2l3Y e/F38VsVvqH9lWr6eerL+g5fSLwTCl3hihpySxQTV10fF2+5YeoRkil2DBQuUR+5pgKW uv+A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AacDWEb3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7987-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7987-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 6a1803df08f44-6a15f2ff9b1si323194566d6.538.2024.05.23.00.15.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 00:15:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-7987-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=AacDWEb3; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-7987-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-7987-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BAEEC1C21110 for ; Thu, 23 May 2024 07:15:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CACF013A879; Thu, 23 May 2024 07:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AacDWEb3" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2C791E535; Thu, 23 May 2024 07:15:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716448537; cv=none; b=TTo2fL8fdyNj3AFRHGrMi5D6Jw4vKHqHzvphwEoRfR70SpOsuOgLgVXlTY7h2QUuKGH7xQfAVIyA5xw52wMm/DmZ+kXnWVhBzrE6iAUHgIJlhceAEjCnCGT7bvNuqiZ5/pYnn+Ua3VJ9zNS6lX5C0bVBz8aWYwpCvKwva7RujlY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716448537; c=relaxed/simple; bh=pEQWtK3bCrqEX/gNjxkAEOCoAJCQsEno4zkmSpPLoZw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=b5v5IaufMa4zc3KZ3GieN8e9mSTbn0b0/8dbxZ0Twn1lbxyqFON2xtb+6DAEfRJWa3awq5NUWh7qMmRiJaadrvwaf75m02oTzRoOMBHHGfVIDgmMrSXZcq90JYlZDzW9Uo11HmQLtxmEDyQdr2Qcdr2FyqJ2GYzT1cHCcx0aNzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AacDWEb3; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6541FC2BD10; Thu, 23 May 2024 07:15:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716448537; bh=pEQWtK3bCrqEX/gNjxkAEOCoAJCQsEno4zkmSpPLoZw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=AacDWEb3OQIMF3pc/zEkwhcbeCvJjNVAUtTeV/QGcyT5FQG1au493A6b0+ouQVaXU yjKVgieoGIRXZ5QSG/jnfO5LUQwnY0h9NncRDNPxsidzpvYA8qdlHogyLKdPi6Qtqg oWgJthhSixz6YvWGflmgROZx4rDbxE8PD2hFRL0PHPJCMzJTC8fVn0//0Hmcn3Fg89 A1VlG0u28q+XxLN2tWC0OQd6ZGoDCI2ZmeuQOqtESHjHeRemlHsAxELaW1RAMVPfKA w8Y76zdqahAkxW77ncJscaDGrVwAd8BetQZCdu7PXy4+4xajYbFJoPzKlMfkMPCmfY bLLU/I2CIpxAw== From: Kalle Valo To: Cc: Johannes Berg , Breno Leitao , Justin Stitt , Kees Cook , , , Sabeeh Khan Subject: Re: [PATCH 00/17] wifi: cc33xx: Add driver for new TI CC33xx wireless device family References: <20240521171841.884576-1-michael.nemanov@ti.com> Date: Thu, 23 May 2024 10:15:33 +0300 In-Reply-To: <20240521171841.884576-1-michael.nemanov@ti.com> (michael nemanov's message of "Tue, 21 May 2024 20:18:24 +0300") Message-ID: <87msohatii.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain writes: > From: Michael Nemanov > > Hello everyone, > > This series adds support for CC33xx which is a new family of WLAN > IEEE802.11 a/b/g/n/ax and BLE 5.4 transceivers by Texas Instruments. > These devices are 20MHz single spatial stream enabling STA > (IEEE802.11ax) and AP (IEEE802.11n only) roles as well as both roles > simultaneously. Communication to the CC33xx is done via 4-bit SDIO > with two extra GPIOs: Enable and Interrupt. > > Data sheet: https://www.ti.com/lit/gpn/cc3301 > > This driver's architecture is a soft-MAC and derivative of existing > wl18xx + wlcore code [1]. It has been tested with the AM335x, AM625x, > and i.MX8-MP evaluation kits. > > All code passes sparse and checkpatch with very few pragmatic exceptions. > > Known gaps to be addressed in following patches: > 1. BLE support > > Test log: > https://0x0.st/XPUd.log > > Change log: > v1: > * Added dt-bindings > * Removed debugfs to ease review > * Fix build issue with CONFIG_CFG80211_CERTIFICATION_ONUS > * Fix multiple build warnings found with Clang 18 and W=12 > > RFC: https://lore.kernel.org/linux-wireless/20240512183247.2190242-1-michael.nemanov@ti.com/ > > > [1] It was considered implementing CC33xx as another user of wlcore > but The differences in HW, host interface, IRQ functionality, Rx/Tx > behavior and supported features were too significant so this was > abandoned. The community (myself included) has been frustrated that TI has dropped the ball on their existing wireless drivers: https://docs.kernel.org/process/maintainers.html#ti-wilink-wireless-drivers This kind of behaviour is not exactly building trust. So how is this driver going to be any different? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches