Received-SPF: pass (google.com: domain of linux-wireless+bounces-7988-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: michael.nemanov@ti.com,  Johannes Berg <johannes.berg@intel.com>,  Breno
 Leitao <leitao@debian.org>,  Justin Stitt <justinstitt@google.com>,  Kees
 Cook <keescook@chromium.org>,  linux-wireless@vger.kernel.org,
  linux-kernel@vger.kernel.org,  Sabeeh Khan <sabeeh-khan@ti.com>
Subject: Re: [PATCH 13/17] Add conf.h
References: <20240521171841.884576-1-michael.nemanov@ti.com>
	<20240521171841.884576-14-michael.nemanov@ti.com>
	<9ba9d156-ce38-47ba-b0fb-63e6174c3094@kernel.org>
	<87r0dtattp.fsf@kernel.org>
	<735594c5-5f50-49b0-b84c-e41efbb834b0@kernel.org>
Date: Thu, 23 May 2024 10:18:24 +0300
In-Reply-To: <735594c5-5f50-49b0-b84c-e41efbb834b0@kernel.org> (Krzysztof
	Kozlowski's message of "Thu, 23 May 2024 09:13:14 +0200")
Message-ID: <87ikz5atdr.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Krzysztof Kozlowski <krzk@kernel.org> writes:

> On 23/05/2024 09:08, Kalle Valo wrote:
>
>> Krzysztof Kozlowski <krzk@kernel.org> writes:
>> 
>>> On 21/05/2024 19:18, michael.nemanov@ti.com wrote:
>>>> From: Michael Nemanov <Michael.Nemanov@ti.com>
>>>>
>>>> Various HW / FW / Driver controls unique for the CC33xx that
>>>> can be set by OEMs.
>>>>
>>>> Signed-off-by: Michael Nemanov <michael.nemanov@ti.com>
>>>> ---
>>>>  drivers/net/wireless/ti/cc33xx/conf.h | 1246 +++++++++++++++++++++++++
>>>
>>> So you are adding one file by another? This does not help review.
>>>
>>> Add logical chunks, e.g. users of header after the header. Or all
>>> headers together. Or some features incrementally, like basic working
>>> driver and then feature foo and bar.
>> 
>> For new wireless drivers my recommendation has been to submit for review
>> one file per patch but the final driver to be commited would be just one
>> patch:
>> 
>> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#new_driver
>
> Understood.

Michael, it would be good to explain that in the cover letter so that
people don't get confused about these multiple patches. Maybe even
include the link?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches