Received-SPF: pass (google.com: domain of linux-wireless+bounces-8009-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: Lingbo Kong <quic_lingbok@quicinc.com>
Cc: Ramya Gnanasekar <quic_rgnanase@quicinc.com>,
  <ath12k@lists.infradead.org>,  <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 3/5] wifi: ath12k: Fix Pdev id in HTT stats request
 for WCN7850
References: <20240510050806.514126-1-quic_rgnanase@quicinc.com>
	<20240510050806.514126-4-quic_rgnanase@quicinc.com>
	<87pltfd2bt.fsf@kernel.org>
	<667cea80-9b62-4ca4-9d28-c5940582832a@quicinc.com>
Date: Thu, 23 May 2024 15:55:24 +0300
In-Reply-To: <667cea80-9b62-4ca4-9d28-c5940582832a@quicinc.com> (Lingbo Kong's
	message of "Thu, 23 May 2024 20:34:51 +0800")
Message-ID: <87ed9sbscj.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Lingbo Kong <quic_lingbok@quicinc.com> writes:

>>> +struct ath12k_vif *ath12k_mac_get_vif_up(struct ath12k_base *ab)
>>> +{
>>> +	struct ath12k *ar;
>>> +	struct ath12k_pdev *pdev;
>>> +	struct ath12k_vif *arvif;
>>> +	int i;
>>> +
>>> +	for (i = 0; i < ab->num_radios; i++) {
>>> +		pdev = &ab->pdevs[i];
>>> +		ar = pdev->ar;
>>> +		list_for_each_entry(arvif, &ar->arvifs, list) {
>>> +			if (arvif->is_up)
>>> +				return arvif;
>>> +		}
>>> +	}
>>> +
>>> +	return NULL;
>>> +}
>> I'm not seeing any protection here, is that on purpose?
>
> you means there need to add lockdep_assert_held(&ar->conf_mutex)?

I mean what's the locking design here? Is it safe to concurrectly access
ab->pdevs and arvif->is_up?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches