Received-SPF: pass (google.com: domain of linux-wireless+bounces-8042-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: David Lin <yu-hao.lin@nxp.com>
To: Brian Norris <briannorris@chromium.org>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"kvalo@kernel.org" <kvalo@kernel.org>, "francesco@dolcini.it"
	<francesco@dolcini.it>, Pete Hsieh <tsung-hsien.hsieh@nxp.com>, Francesco
 Dolcini <francesco.dolcini@toradex.com>
Subject: RE: [EXT] Re: [PATCH v10 1/2] wifi: mwifiex: add host mlme for client
 mode
Thread-Topic: [EXT] Re: [PATCH v10 1/2] wifi: mwifiex: add host mlme for
 client mode
Thread-Index: AQHakVadTJiKH7Fbwkii2Ljo0AqkAbGkNJ4AgAIC2FA=
Date: Fri, 24 May 2024 09:46:00 +0000
Message-ID:
 <PA4PR04MB9638DC958102D07A7B7084B6D1F52@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <20240418060626.431202-1-yu-hao.lin@nxp.com>
 <20240418060626.431202-2-yu-hao.lin@nxp.com> <Zk6TklTIbxZxIWyb@google.com>
In-Reply-To: <Zk6TklTIbxZxIWyb@google.com>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?8nj3fNGArDw9hqhlgN7IwIpKB+KN/l9dfRD1KVlVhe4bOusoGT83PjsHW3hf?=
 =?us-ascii?Q?KAx1RPqTcpWGv0SMyW+NSq40TMYua9HVnfMZspx1FpcnYPSmxRaTvebvAMRi?=
 =?us-ascii?Q?fsl993hlA7q8WWnOTyZFZFS8FBFXD3Pvx7/xpcUUr49CESuHY+iMvl9h4RnS?=
 =?us-ascii?Q?p6f/mzCYiWbx4YHnZ8N/VgbHy61U7atQLD0345ugycCTre9OOVH6ybQIUEOA?=
 =?us-ascii?Q?SUlLj8EYomNnl3nuGPvEah2hs8LkFRJSlzpO8YKG9lzlHLHX3TY3Z28lFnEp?=
 =?us-ascii?Q?8CCc3MsDF4fwp7nGYNTxU7EKFN0E5o4/ni4ga5FW9MhMQWya7fqFL0YWjQjJ?=
 =?us-ascii?Q?14b06E3Ukf5+YRiDHH5Q0QB6fLJ7iDf1H6C8xOgLKUnVTSgRozMbCDRfLrUZ?=
 =?us-ascii?Q?tIhmliWPVdFngCdWkmsNnBVx6ZnoWtGPzpKyulcLdGpyhQhb2qVnTRkysgfA?=
 =?us-ascii?Q?cleuDELyM7D/yWydzc+S6VNOc6ZMWpg8wLa5si9Wknu1mJyGaVMSD/GxfJHZ?=
 =?us-ascii?Q?Xg46ixHQRM1hSUE0rGpjLu2qnehkBrGZsbfEwGrDxYMnineRYamF6Iq+H95w?=
 =?us-ascii?Q?84SecN1hzAXxzgDJZZ2ap4uqxEySc/eRAb4W/ZbaeZ2joRimUCAphz7Le91v?=
 =?us-ascii?Q?7m3TvAHrQbH4y1yGkhyNWUBEZ23lXE9/u83WHL9eG31qcSphHen5jn13tqA3?=
 =?us-ascii?Q?EkznhPY1MeO3Xt39SLFfg4lovQc0Y0c4z+G1XD/1+V9ixobRfjBz+hilLpF5?=
 =?us-ascii?Q?MNsEEOKXg4p6KL+FAs04HDnXMw07UM0aM+cM8HI2yEQrxSxkDz9KGZ4h2knj?=
 =?us-ascii?Q?BEurCrfyVMPQAi8G5f2lxa1wmkmcoOeNWoCilaMOboQZRssYKJ3+MIDU+tlv?=
 =?us-ascii?Q?crgC+f3nYPid/DEGI96Q1syilUNnmonbDtiFeHfYorxFCFloX2/t+7s0bess?=
 =?us-ascii?Q?wpe5mNFmswAqU0uZeiQR4M0/q0YKA5lsuj7yyuSrnyfeBKBD1JPwoFJ1FQRh?=
 =?us-ascii?Q?7khwzyD/9IlsCiBiWAV6AnYicyosKVt14Q2PTSlLbmaRnTf8oL1VTi4H5ZMw?=
 =?us-ascii?Q?UoIQTLd5VLrQaGCwS9oFfzWHQsRMvtZ2PXib3b8rT24q1lLguFJOwvhU7aty?=
 =?us-ascii?Q?xhrOudXCcc8nEFcx7pnxzHBfHoU0cPkX0fg1cotB9+JSyEPuWUWHDW5Z33rQ?=
 =?us-ascii?Q?yJYHlJMClO07yL+OBYH7v9gTL9upjTZtOkohJ1Q1TfK5LhZJ/mhP+sBka4V+?=
 =?us-ascii?Q?Qd0pfch/hqbeuQ86ZG73qPQDiqPWPIwaZ4xabeuXMEyoArMMLvKKa3uArRyf?=
 =?us-ascii?Q?33nZ9zBE0IsR8YX/nDw8ELj7fUOM8Kvo4k2NFDwXyxCuRYSumT7nRgaZ34RA?=
 =?us-ascii?Q?S1W8wgnk/1mXX2uDWyVoVnih8drNR3SPSC2Gr51R6cvD6c3D55H3IbC8VfSs?=
 =?us-ascii?Q?msngB5RdEeJ7O06fxyxr7WnmW6AchlgUkdzjTidAK2dlsETaCpTWwqq/by7A?=
 =?us-ascii?Q?FcuHXpzsPCeDtTQHQlbzniwNpR9OwPzxMzu4WoERrKMmhSCz8Hdur14dZQkn?=
 =?us-ascii?Q?L3tgy6FWmhUq7QxMfMhHhyYb1id9c56u9tpR6X9U?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 387c7a38-a729-4f67-6496-08dc7bd651ce
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 May 2024 09:46:00.4925
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: RFX7qDoJ/W/fDHAw93z8irJlwZdDIAhC1ezLsis+pyt418lkY/zLT4mbauAd3KeXyvdzX+3P4Vw87/Vx+z21Gw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU2PR04MB8597

Hi Brian,

> From: Brian Norris <briannorris@chromium.org>
> Sent: Thursday, May 23, 2024 8:54 AM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> kvalo@kernel.org; francesco@dolcini.it; Pete Hsieh
> <tsung-hsien.hsieh@nxp.com>; Francesco Dolcini
> <francesco.dolcini@toradex.com>
> Subject: [EXT] Re: [PATCH v10 1/2] wifi: mwifiex: add host mlme for clien=
t
> mode
>
> On Thu, Apr 18, 2024 at 02:06:25PM +0800, David Lin wrote:
> > +static int
> > +mwifiex_cfg80211_probe_client(struct wiphy *wiphy,
> > +                           struct net_device *dev, const u8 *peer,
> > +                           u64 *cookie) {
> > +     return -EOPNOTSUPP;
> > +}
> > +
>
> > +             mwifiex_cfg80211_ops.probe_client =3D
> > +                     mwifiex_cfg80211_probe_client;
>
> For the record, I feel like this question was not adequately handled from=
 v8.
> That thread is:
>
> https://lore.kern/
> el.org%2Fall%2FCA%2BASDXM1PEMRyxRpBryJ7G6e7yzG8Ku%2Bg2_qpHN3g5d
> jFpAWkw%40mail.gmail.com%2F&data=3D05%7C02%7Cyu-hao.lin%40nxp.com%
> 7C0b65f7e4a5fc46c8bdbc08dc7ac2c9ff%7C686ea1d3bc2b4c6fa92cd99c5c301
> 635%7C0%7C0%7C638520224227876720%7CUnknown%7CTWFpbGZsb3d8eyJ
> WIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7
> C0%7C%7C%7C&sdata=3DMpqW1U4yTgDcM0g20DRSAxEnHkNNkd2hwsZrVAxg8p
> w%3D&reserved=3D0
> Re: [EXT] Re: [PATCH v8 1/2] wifi: mwifiex: add host mlme for client mode
>
> Brian

The difference with and without hooking probe_client() is that "poll_comman=
d_supported" of hostapd will be set or not.
If "poll_command_supported" is not set (won't hook probe_client), it will l=
et hostapd to set "use_monitor" and client can't
connect to AP.

Maybe I can put following comments:

Hook probe_client to avoid hostapd to set "poll_command_supported" as 0 and=
 set "use_monitor" to 1.

David