Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp1922555lqb; Mon, 27 May 2024 01:48:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVSAYmGbZT1JQqTs+S4epYLKDTW/Svi5KLA2o7Gnk6RnfcTHifsFBJ3dYfbjFQ/xwrnh6/p3Y7UmFid/XLYzxoxEWYh6nhS7bCY2d+ppw== X-Google-Smtp-Source: AGHT+IF6R8g3oRTs+DmynJ+ZjbnkGcccoo+j8pF74zFoC5PmForm2sULiGnwnhL9qGUr+Dr9+IWa X-Received: by 2002:a05:6512:3107:b0:51b:528e:ce7d with SMTP id 2adb3069b0e04-52966005b6emr6402028e87.34.1716799730853; Mon, 27 May 2024 01:48:50 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716799730; cv=pass; d=google.com; s=arc-20160816; b=B5sy4i1QqWcOgnYAskDxNMc0vd0FreLp/23IJ5HZ73GV7K+AxOowXx/2omYIs+MmbB c3AG5VvhoB/WpauV6tieMmRGDli1WpKmUMwkc/swMAzQq4n4JGKHfcC1nBBGSoJh85eh z3wyxbimDFMMZq2dRL7+je6HOOUM3zlCmmaLI5VLQ8h+ss1JlKITto/f9xxw+fTP/fWg 3XLVwF7/JPraNWa+9txr061zXk3O5W+9Dd94WujUPXTgaMGbJeHGpbPmQycSA04oiAzH YbiDsQuNSEpHkS3pmEmIFWyxYcfghD7MVXYRVitzeuGYTRKVP0rYsvWDoE/X0uN0kc4R hanA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:references:in-reply-to:subject:to:from; bh=bZYzuXbFfVwHbaSn/DSsXwyxmh5RTLuHP7T+9RttdJ0=; fh=r4ENiFzv8sfsaHjEaC5Eod/Y/wWo58HiAtKc2y9c0KQ=; b=qR2p3obm27VR5QxBw2TwdsfdPP4yuR2j8tOZr1YM+pn2N3LCMFAZSLqC7GyEyriGG3 MNoPH0QiKhEVgJmNrhceIIOMFmdCDEfDQlIivILRSciZF2z7nwNOrkSduhDmNH4QJ+bP CwX0K4cI1wWb3h9a+0tjmkvZj9+0acaZzrHvRyOljzqJFFsQIQBS1JCYJ3U7Bk+ri6KL 2Etw77XhkmFztk0n86N/hT2gk/aOYPqPZBmOx4rD1Oglry3P8qy/CDeKvn2a2uvyrv2r d+vaDxHpZcy62wywsyCUkr6KMB6u7kRJ8LR3TXPL5oetF9TdrHAbbDDrOBlONma2qFaM H5ng==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-8077-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8077-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a626cc3754esi377873366b.296.2024.05.27.01.48.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 01:48:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8077-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-8077-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8077-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 91CFC1F22BA2 for ; Mon, 27 May 2024 08:48:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3BFC95FDA5; Mon, 27 May 2024 08:48:06 +0000 (UTC) X-Original-To: linux-wireless@vger.kernel.org Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C52705FEE6 for ; Mon, 27 May 2024 08:48:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716799686; cv=none; b=qtvnsFt6T72m3THTXCp3CoUnwufG4fvFsB9kR3fd6KT6L7qLOADK63RVw6loHN7HBlA0VGvUagSIYt9E6X15cxS3zSJckGI0LKF1hu933PjuiRjgYd1g8FyGqR38xi4PxRM2S5YltAvsLRF/o16zR6wLYSUMrTMBhkYngRNCDS8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716799686; c=relaxed/simple; bh=3cYSNLp8pCzBJiAmAG/iEnFmzQiNyZFh5MRjYQh50yk=; h=From:To:Subject:In-Reply-To:References:MIME-Version:Content-Type: Message-ID:Date; b=LhjG17+hqKIPYdirnJAnDHI6yE6+xH4ihOvJiM84QEC+xNvnwF+V9xgHQcydVP7CR+/Kpd4iyTk+aeqsvDS6aKXkAViqE6EMdohL4CUMmWynVizdwdjq3TWUm9NDTzNhgZ0N0HfTfOvSD7sfchOeYO2OU1ZYbxrNf/vrUCGe2PI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 44R8lwoX7956409, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 44R8lwoX7956409 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 27 May 2024 16:47:58 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 27 May 2024 16:47:58 +0800 Received: from [127.0.1.1] (172.21.69.94) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 27 May 2024 16:47:58 +0800 From: Ping-Ke Shih To: Ping-Ke Shih , Subject: Re: [PATCH] wifi: rtw89: 8852c: correct logic and restore PCI PHY EQ after device resume In-Reply-To: <20240521040139.20311-1-pkshih@realtek.com> References: <20240521040139.20311-1-pkshih@realtek.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Message-ID: <28823fb3-88c6-4acd-9bfb-350292d4d163@RTEXMBS04.realtek.com.tw> Date: Mon, 27 May 2024 16:47:58 +0800 X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) Ping-Ke Shih wrote: > PCI PHY EQ value is missing after card off/on, so update the value after > device resume. The original commit only updates once at probe stage, which > could lead problem after suspend/resume. > > The logic should be read a value from one register and write to another > register with a mask to avoid affecting unrelated bits. > > Fixes: a78d33a1286c ("wifi: rtw89: 8852c: disable PCI PHY EQ to improve compatibility") > Signed-off-by: Ping-Ke Shih 1 patch(es) applied to rtw-next branch of rtw.git, thanks. 9e305a6f01ad wifi: rtw89: 8852c: correct logic and restore PCI PHY EQ after device resume --- https://github.com/pkshih/rtw.git