Received: by 2002:a89:d88:0:b0:1fa:5c73:8e2d with SMTP id eb8csp2192789lqb; Mon, 27 May 2024 10:44:12 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUV3FetZgJ/or8khup9E1ZI0QRvn6v4sCVitEbagMItnbVNLN6l8wwviYZOWZHKBZWqFqQOwXtcHkOV5KKQJqdT3ZCMRR0CxxpXBHETbA== X-Google-Smtp-Source: AGHT+IHf+kuy/e1lmXsGYs3VrJ4NMaMpQ9F21ut4aUbCi2TxQ9v0ypEPPni1aZORtKrVMkkNVDYM X-Received: by 2002:a17:902:cf09:b0:1f4:6fad:ba59 with SMTP id d9443c01a7336-1f46fadbf0dmr98091275ad.14.1716831852133; Mon, 27 May 2024 10:44:12 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716831852; cv=pass; d=google.com; s=arc-20160816; b=RJTEcbhHjKkN2KRee14FRkPb0dL4jvdiSRdXXvMLow4AMahGTrqEzgcjecFTj3Xh+r O67J8C0UKbIDGqZrMwXds00lRUFgsgUpwJeKM6ZsCpbnx86duNJy1kCaCCShqlLNnAfx O9jHZEoiFIItWO+9qCeQmAbYEsSfBdYQcXrupYqqih5r0oMWUNj4d/TGAaY4+ZJuSFq5 3tdzQmRnEO7Y8aAOtfvBg9aQWCX1loBqo5Xkks83frGGbjvc+ECqabFFHb7dZTiIv3/C Uac/1X245CJIqKMfGraZwVikyz796mc5lFQekAGjMvzoRIwg4cVvWbJs7Txv/Bnm2khW uQjw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=SBlDgzF6mpmZ1Onln0HIXGug87tsPK6zVBEDdeQb8p8=; fh=MKzRl0YfVcJ/lfVYjE90AeMxxsD9A+cYGQv0rrVmTfs=; b=AYCgJfWevwgIZf11MoxpEMLdT6tzMKo80GB5w70dOCHkKgvjKMdz9dk5MxZRcuMMkp 6omAsnJjQq1HGVKnNdc+zVu+pQIcBcmLouVYhopPiOGxH2eGsGLXTjEc8HJzJQ9vzSOJ 971K89HMEximh0+08HmE6stcZ63a1g/1JLywiSP+UwVgROOMaKtbTYwyiE8pT7reH3U2 kylPv/oqX2WL4PuwtuSw+Rhx3tpZckZF3T/aIVlctTiLNw1p7eg4x0yTfxIhCqlPZ9HD cECtZDK35NoSjWqVeZsI/Zi+ANlQDUtQ/jDWbMprgqLnqRLvSW3+yet6r86YwwzqEizO XoDQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=sRW98aIf; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-8143-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8143-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c9b7af3si65327445ad.460.2024.05.27.10.44.11 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 10:44:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8143-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=sRW98aIf; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-8143-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8143-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 54ED12824E7 for ; Mon, 27 May 2024 17:44:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B063C155CA5; Mon, 27 May 2024 17:44:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="sRW98aIf" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF72E26AE7 for ; Mon, 27 May 2024 17:44:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716831848; cv=none; b=b8AmlG569o8dkzThaF7fU8Kab7wPGxgTfC3/0Vb413fe1DO1Z+mWKmS5spLUCbzmlkg4edOm2hyqerktogGe7ESxYdrhA69XDnqCRNhc1uf7ORBtlMr1PhKLNUwNFLC+dPHPEPiV+yJK448a8912V+FV4DosxDZl8ZDwYoKNKcw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716831848; c=relaxed/simple; bh=SBlDgzF6mpmZ1Onln0HIXGug87tsPK6zVBEDdeQb8p8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=eTUQNc1jzW3y44ZdxE92lKy/GsqDtr2i47X1FerKp0VLP6/VqR2j/djrRCoQJzQtWAJyVjFY7PBmNs+dw7qcz61GEsO7pdSD+Id+DDt+5ruSaVJfqhaoI6m0hhvVrYeO8VnZ95Ue1MWLGc9AdoKv/0xIJ+xfJqzcLKn/bqDvFeg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=sRW98aIf; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=SBlDgzF6mpmZ1Onln0HIXGug87tsPK6zVBEDdeQb8p8=; t=1716831844; x=1718041444; b=sRW98aIfg5UPjDv9iW6sjg1kxr6iSoJwIZrhcsWWrvXMz3K tj9dRJRIiiubJsmYHGgk7qZ6tdI0KEWmxHp2kBsuVYSUOeMtywBLOfjI+ojk6QNiym6TYlPsdZccv tCaWWpfamSv91PhdnluQKTvOEqklzHtFlX1htwq1ljUuhNKSgy24czwpF55mRuJ7Jsm0v9KepR3hc DA0qmHcfqJeV1MtbyH1K42m9Vj7kVOY6wxh7qOluPxzcv9L7QHACgF4t42HhavjoAmCHNdrM3JTOP tr5UuXP4ScMpXRZO4A+rkYLvxt5yl8W3Rghjg9JXD8jiQZrQ970HIRJmQtsyo27w==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1sBeO8-0000000D0C9-1i2Y; Mon, 27 May 2024 19:44:00 +0200 Message-ID: <56d1c2f223c032b0003029cc4956f1cfffea86ca.camel@sipsolutions.net> Subject: Re: [PATCH] wifi: mac80211: add input validation to sta_stats_decode_rate() From: Johannes Berg To: James Dutton Cc: linux-wireless@vger.kernel.org Date: Mon, 27 May 2024 19:43:59 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Mon, 2024-05-27 at 18:14 +0100, James Dutton wrote: >=20 > You mention "certainly not any pointers or the band enum!". > How certain are you about that statement? I ask because received wifi > packets can and do result in unwelcome values for the pointers here. >=20 I really don't see how? Certainly the pointer is _always_ going to be defined by the driver calling this, and I've yet to see any hardware that actually uses nl80211 band enums directly. johannes