Received-SPF: pass (google.com: domain of linux-wireless+bounces-8190-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240527173454.459264-1-marcin.slusarz@gmail.com>
 <20240527173454.459264-2-marcin.slusarz@gmail.com> <7427b534f5e64abf8a31a80082d4b6e1@realtek.com>
In-Reply-To: <7427b534f5e64abf8a31a80082d4b6e1@realtek.com>
From: =?UTF-8?Q?Marcin_=C5=9Alusarz?= <marcin.slusarz@gmail.com>
Date: Tue, 28 May 2024 12:53:39 +0200
Message-ID: <CA+GA0_tud4wLBKCokQNwB_3jULTPfnS14XmaLHomGMSOLhKszA@mail.gmail.com>
Subject: Re: [PATCH 1/2] wifi: rtw88: use RTW_FLAG_RUNNING for deciding
 whether to enter/leave IPS
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, =?UTF-8?Q?Marcin_=C5=9Alusarz?= <mslusarz@renau.com>, 
	Larry Finger <Larry.Finger@lwfinger.net>, Kalle Valo <kvalo@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

wt., 28 maj 2024 o 05:56 Ping-Ke Shih <pkshih@realtek.com> napisa=C5=82(a):
>
> Marcin =C5=9Alusarz <marcin.slusarz@gmail.com> wrote:
> > From: Marcin =C5=9Alusarz <mslusarz@renau.com>
> >
> > Needed by the next patch that disables power off operation for one chip=
.
> >
> > Signed-off-by: Marcin =C5=9Alusarz <mslusarz@renau.com>
> > Cc: Ping-Ke Shih <pkshih@realtek.com>
> > Cc: Larry Finger <Larry.Finger@lwfinger.net>
> > Cc: Kalle Valo <kvalo@kernel.org>
> > Cc: linux-wireless@vger.kernel.org
> > ---
> >  drivers/net/wireless/realtek/rtw88/ps.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/realtek/rtw88/ps.c b/drivers/net/wire=
less/realtek/rtw88/ps.c
> > index add5a20b8432..f9fbc9b3174b 100644
> > --- a/drivers/net/wireless/realtek/rtw88/ps.c
> > +++ b/drivers/net/wireless/realtek/rtw88/ps.c
> > @@ -26,7 +26,7 @@ static int rtw_ips_pwr_up(struct rtw_dev *rtwdev)
> >
> >  int rtw_enter_ips(struct rtw_dev *rtwdev)
> >  {
> > -       if (!test_bit(RTW_FLAG_POWERON, rtwdev->flags))
> > +       if (!test_bit(RTW_FLAG_RUNNING, rtwdev->flags))
>
> RTW_FLAG_POWERON is to maintain power state (i.e. ips) of WiFi card, and
> prevent entering/leaving IPS twice suddenly. Changing this is confused to=
 me.

I explained it in the other thread as a reply to Bitterblue.