Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp133007lqb; Tue, 28 May 2024 10:47:05 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXMdm6g2/QhK7AjX5qdUqetNjat3Es2DxLTTQEQBaEWv8JyLm4eOTebJZaPhaNbFN8gBNIfWTTA9c1swUolLXfQLMVWqdvHv35R0FJ1Pg== X-Google-Smtp-Source: AGHT+IGVSQwtEz2nV9f3XxSL6hzs/ebcKiumMq0wL4VbOWiyuRacTY2Do18ZtwEGsoLCVrVBU/nJ X-Received: by 2002:a17:902:da91:b0:1f3:7f0:74d with SMTP id d9443c01a7336-1f4486c6241mr198711865ad.11.1716918425254; Tue, 28 May 2024 10:47:05 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716918425; cv=pass; d=google.com; s=arc-20160816; b=V6Hvo8BBwBObwuHcMB4dBb5v2ctUVAwUaSGds9gee9e5Yd0cKx4NEO1YoFuoFGDLWC kD8axtWBxyzT6/ml0oGQuVL/EPZlMckqFHihL1TdwPBJaCWToZYSVcz7elREZLxAM/Eo 6U/sGLKxayoZw/V7jJWrqofgpsAoj0Vp2aVyR/XiuJiA5231xFu/juMZ6HbOT4KLry41 cGmEuGTUBZjv46HZaX1B3WAmyEJSavb5qiiHNupiUnbfTrSXj/4Uk0tZfDJyoNJ5CzPg KAyik/ksNfwrSa4SfwEYexAkr+x0BkEjwMxuSEc7z/3zUWOmk+gL8x5QAfMbKRx7Pz/P hqzg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=f7+MmbYJweCFJZ6FptiJK5ft9rfNuytH0xsHp7M7F+U=; fh=q0pWxAdL0cyDcfHi0eFkTCBsBNeBmItsjEnoI8WnNeM=; b=d/rLSDUjC5jW0c6v8oKM7JbK5yrkVSf98CEYplhHiWXhPhR/rynExCuilY1BHG0Zgu qstk/wK7N1G3ImNrKwj/IGZ03UDCQJn1lYY7W3T3gkoQkhAIukENDM7ybar6g50XZC3L Cz9P4xUwfDe8SlAnbFbZ2TTDBmeHdPnp0mX6/41KMg9u56a0qxW98W1rINVOmcFGbcYG WRow3IRBGgrmWf+3DsTOh/7ZRnbedmk/3BOPXw2sGzDMmmtBunvOzufl6cVAnWZ89c+D TxEkyEAefzCRsspP4n1B0A7HbkJOjZVI8mjycZzWz/dS7WvUu7coTH8xjXXUYGLRbUcA M37A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SB6n8E0D; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8216-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f44c78923asi84280635ad.78.2024.05.28.10.47.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 10:47:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SB6n8E0D; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8216-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8216-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id F0CB328189B for ; Tue, 28 May 2024 17:45:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 214ED24B2F; Tue, 28 May 2024 17:45:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SB6n8E0D" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0DD71B806 for ; Tue, 28 May 2024 17:45:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716918346; cv=none; b=CfDzvWy47OnXzPOehaGbTVIi2CoK8dyagQ5TBOWFcWiMMAxYu6YvsKGWsAbYLg9r5iOn13vZ9gNDGXTayz4oB00IN01q77na1NJtiAstx10lDZIkRpICR4CKvtEPjFZnQMG9M+mlxTOJ3YK8U9osnWAsw5/Cw/jZLa5cP12IePA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716918346; c=relaxed/simple; bh=sKLWwnpnlmhE+bUX9QrAVOLuHKIQAriHb2GHbk54UC0=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=RmDetnEzjW7LBULkVEpqoBlBpJC+SAk5q1EWckHDOBPaqhCxuEexn0fhSSEzeNqn+K7P7dEbsdMl9t1qBd+Gn5VYHO7xZTjIol61MOkVsgWSQOgSahlnoEmloLMmOMGqCSVxHU++uNnAg/LE4fo4n+F2xJMCBvgGgDv0wtyBRIY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SB6n8E0D; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DADD4C3277B; Tue, 28 May 2024 17:45:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716918345; bh=sKLWwnpnlmhE+bUX9QrAVOLuHKIQAriHb2GHbk54UC0=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=SB6n8E0DKc2y1A29J2akEghPSSOAngxwmBGoXhGOx//9nROxUl+sCay3NiBchHkwz YqHx/qi7pByY+rsVhd+EdikmbSGv6WC6xLqGpZgRGFt7X/G6p4kCMQ6pBO+V803UFx tLd45rGxgrwt7NkmuvqX9CF3lBBUphGfLCdpUY9+NW+hpPxTxU1nANhzOaBlao2LYg j3v3fPn14KUZRoAF1RMctGf/H46VZJzncOmsMZ59Mz5aP2BWim4gL1v4XDx/8xkhrB iiW3NxxPt1jRYkzo2DXdpxpouP5+3v7jTuCu7C30fu72i/p87tsI0kypNvSAirpJrB 8VDZZ+18bu2ow== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath12k: fix wrong definition of CE ring's base address From: Kalle Valo In-Reply-To: <20240524024021.37711-1-quic_bqiang@quicinc.com> References: <20240524024021.37711-1-quic_bqiang@quicinc.com> To: Baochen Qiang Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171691834316.1700985.14768410364524258045.kvalo@kernel.org> Date: Tue, 28 May 2024 17:45:44 +0000 (UTC) Baochen Qiang wrote: > Base address of CE ring is defined as u32, currently this works > because DMA mask configured as 32 bit: > > #define ATH12K_PCI_DMA_MASK 32 > > However this mask could be changed once firmware bugs are fixed > to fully support 36 bit DMA addressing. So to protect against any > future changes to the DMA mask, change the type of the fields that > are dependent upon it. > > This is found during code review. Compile tested only. > > Fixes: d889913205cf ("wifi: ath12k: driver for Qualcomm Wi-Fi 7 devices") > Signed-off-by: Baochen Qiang > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 0ae570703754 wifi: ath12k: fix wrong definition of CE ring's base address -- https://patchwork.kernel.org/project/linux-wireless/patch/20240524024021.37711-1-quic_bqiang@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches