Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp133325lqb; Tue, 28 May 2024 10:47:43 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUfaX3d1cVvZnowBReDrFt48VbDbuV6dH5ZspQJlfYmBjiFsH3PNEU5F5Ju/xPyIAxGMCzBPYlc+w3D2hGva1/J4a9M6jtfBje/LAgflw== X-Google-Smtp-Source: AGHT+IEjl4WZuj2f0qa3RO2/gkaPPC3GKMTv9ls2gqripJ+Iyp+ZkZKee83c9NmDoyZeEy5t4M6O X-Received: by 2002:a05:6a20:394d:b0:1af:6541:8a08 with SMTP id adf61e73a8af0-1b212d081e8mr13816951637.20.1716918463526; Tue, 28 May 2024 10:47:43 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716918463; cv=pass; d=google.com; s=arc-20160816; b=O1mF27Hlzdzi0BL8cOWZ2IudlY3kPhjim0zk4klkE/5JSJLTdnPgv8u+j0HWOq1L96 gunOg3EG2E7h2EmmQLkps4e9mzNvbkVxAO3kogPkEc6JXlI6dXsMydgphPoub1r9QNlh vuFgoMwDb0q2VmCjao+2pSBzm6ddZfJ/Yr5iLmvOKXStbd5RgdtEqWhP1Hvg1ZcygTGa wJkzKKA7D4o/LNQybwR1vNlb4N8BTl+4Sx1enM1og/6a0MLrNAzgdnQjMXhlOM9O8O/A kzWWH1K2wPYxejhOmZqL0LhDjw/EJiFPD0vbb7O7AX4xqI0IbQcBGwi2sI4r9Xz5ObAa DKMA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=cuP3dZqtVjw/D1dWPcEdQp8vFCx/YS4v9UuinTL0t7E=; fh=tPHBA95q4A2JsKJMw3mMqQ5Xsp/Qmg3wcY5CiIlDe3k=; b=eALxWt1YM9QkQB72KFIpIj7v1eE+oHZUjMKNm3KzP96mJYuz/kh1SLTN7rYd6B+PuU F+EeqGDm2rDGi3z7cIMkMny/7I28vpyE1n/2+K0j7gK4iMmXqZJ4SufJzyNl01tPuBHO 23S0WcVXwxbdCeWntDT6Ir4vNrtL1oiz+f0CHbTIV2KJJUt4daTZNAhtccJ7Hzf6gOEL Prcbil7nUMeZImVpPSJHELLtAeedpKkLfpNb6CvSPXhS7Q4+A6+gWd3JbZqH0UumEfQP kcAXea3aRRBqxZ+zcyXZjOsHgPKu3L1bepaH7flJ15y8SRd6oL9Fzw0TXMiSTxyiavpC udfg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IHotNmS6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8214-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8214-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d9443c01a7336-1f4960c83f7si42329645ad.363.2024.05.28.10.47.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 May 2024 10:47:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8214-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IHotNmS6; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8214-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8214-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 41AD7B233B9 for ; Tue, 28 May 2024 17:44:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B3047481A5; Tue, 28 May 2024 17:43:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IHotNmS6" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E16B481A3 for ; Tue, 28 May 2024 17:43:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716918235; cv=none; b=a97h4LkF6B7jWK/zAFSQsPjtlWp8YXr7i+RJeE6uRqPha9CmHXu5ILI/1uopnZnU2vWEIXFqZcDLZLq91uXRQ+AB/nDFdruGdkIK5Hfm9tyhdioqUaPSVsr9KwzTnBLsFRW5Rw4NID9pUhxOHVSxl/eYYvOj2y9aeDeS8nPRlbI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716918235; c=relaxed/simple; bh=acMf32fu0JN28eSlBB0qI0jOAiIbnSOa9UfPdAOD10o=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=o8HdV6EbWGIrDvrend6mUNL5Zo/8RZRkNI0ZVFYVzoB9tOM50ZbANefLgFJowR3LCCTz7THKLRAoQfNjBcpKBuU1uPoU1/klGJ3grruvTHOIOv3KJ1u5UOJ3qV1S7OIRjReUD70c29SMEYe4w9RxuAxM++m0FXttrQO3rkeV2XI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IHotNmS6; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 421FDC3277B; Tue, 28 May 2024 17:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716918235; bh=acMf32fu0JN28eSlBB0qI0jOAiIbnSOa9UfPdAOD10o=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=IHotNmS6iLNBAJLqukMUe67QExDQ5+rTAQE43QRz51r5YDgALRLNvI+UZ1TosINDB jVqW+R6OmgDfXH0eP5mE+QeDX5NiprilwRL9jFiE9+Zs7sK/Xw2Cb3evi27V3NzfUi ycanzFwTH5AGOVYylaDVSar4rwwlyEmlTYn11JxE0mbW1vsBYddU1JaetWwSIcdD9u EYn6QxgnvgPKg6LX3dCfF/yxf9HhPAe3bAJnSUKhUoVAa2NJkhUEytzI8QRksUa9PJ xmo8ONR+UC255qAbBHWVl8s27BuerQ+NmEHP+WkHxUFWXc3ykC0zsO+PlQA+dMhPbr /HhWFGVWHpH2w== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath11k: fix wrong definition of CE ring's base address From: Kalle Valo In-Reply-To: <20240524021558.34452-1-quic_bqiang@quicinc.com> References: <20240524021558.34452-1-quic_bqiang@quicinc.com> To: Baochen Qiang Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171691823254.1700985.17999890257962892911.kvalo@kernel.org> Date: Tue, 28 May 2024 17:43:54 +0000 (UTC) Baochen Qiang wrote: > Base address of CE ring is defined as u32, currently this works > because coherent DMA mask configured as 32 bit: > > #define ATH11K_PCI_COHERENT_DMA_MASK 32 > > However this mask could be changed once firmware bugs are fixed > to fully support 36 bit DMA addressing. So to protect against any > future changes to the DMA mask, change the type of the fields that > are dependent upon it. > > This is found during code review. Compile tested only. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Baochen Qiang > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 5714e25f1d18 wifi: ath11k: fix wrong definition of CE ring's base address -- https://patchwork.kernel.org/project/linux-wireless/patch/20240524021558.34452-1-quic_bqiang@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches