Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp703680lqb; Wed, 29 May 2024 08:12:53 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW9rMiAhSm4erFwzQNCZV1+lpIMbpk5pV5nuPIiYFsgX8hjlOA3CzDciId5WUlcfAYEhwUe5dv0RqiKTQNybrFEawrtfNXCVzzQc0hSMw== X-Google-Smtp-Source: AGHT+IFdCmeYMhrKlXTgTE93tkic2hKbyVmOjAEqAqqpfJzTbYusV/oK4nmVKPFP0HK2r+KV7ekP X-Received: by 2002:a05:6a00:4ace:b0:6f4:3c65:d05a with SMTP id d2e1a72fcca58-6f8f42b8adfmr15508584b3a.30.1716995573057; Wed, 29 May 2024 08:12:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1716995573; cv=pass; d=google.com; s=arc-20160816; b=CPM6vWEzJpxJtv5FXRHOYJ8Jh+NXoIobcK8vlblfxvasPZedrtS5MZSpwJrOOYC227 ksJ0NUcouvuGDTkw37DLXgiNXamu67ZWWMSuLwj/elVrszNfPEStQL88yDd7ArYfwPQh kSTw+0tVlqtV7rDD+QIUz9nZT13q9HBMEcm6aI2r4wPO8YKfZFi45xqTx4YbEPxOGh7E 2lyQDpCZ2LbOhxKIkppBlatrtm+QmGHngNxh6QpHPCiZQ5JN37cS6V7tEqZM2GLk5Ram MKq03lcEzUIpKMBmxdYeGWRtkcWghFPddAM37CDaCGaqViUV9kVQoAo+wDtByR6v+OHB 4bUg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=LKlh9hVOnB/K2o7RLmzS0uBIBkUJWNr7avAUzdtD2pY=; fh=D5cqU3J7fbX8E8MHMW2j2n4TkAfYr5F0f+LthG8QKqU=; b=lGFfP7uOI+VxT/v+FLO382kRpzdO5e+ELfEL2KSvLLjjKNC2klj20yElTfcL+qojMm OUHvI6oESRomWtkXe/+Y2XBJyrb38UlfDTNp/LuNEMEVECg7xVls6IRGKD67sUCjoc33 CIj/ge/ZYFrPLK4j7ZyCPNGVpMA0/RR7c1eFMovp9zkqLQxUtkp5oTpD7ureFO/ZxYgi 67pQQBqEU+W6Y3Q0TjTZ2lE/ZvucJ1rxNvjefFS63KD28MFf83+z0HqqgKmkBlRqpRvq 3BlWdwp3uNBuMjD8vVzxLuQmxsoEFIH33CajU3JWhFfzrlE4yo51zZGMK+eAsHqnfPyo xGTg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=hY4Edtuy; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-8267-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8267-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 41be03b00d2f7-6822779bc6bsi10520799a12.268.2024.05.29.08.12.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 08:12:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8267-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=hY4Edtuy; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-8267-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8267-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 18DE7B217AC for ; Wed, 29 May 2024 14:55:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1162015ADAA; Wed, 29 May 2024 14:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="hY4Edtuy" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E350D27E; Wed, 29 May 2024 14:55:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716994505; cv=none; b=kXQWHXVGNjk0KJYF13rsCaItsXLypSNUcGaqQlu+oSxcJD6m9+TmSoWz+NOyrTdRuWAomVC/SJnCEaMFPLQylEiHOxhHMvOCgBjNoVcKrvNSetFyM1ucSJH2ujvCvxvZwMDBeazpfA9BkX25UpwuWDqqlXONgHYFOdfBluLWMCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716994505; c=relaxed/simple; bh=LKlh9hVOnB/K2o7RLmzS0uBIBkUJWNr7avAUzdtD2pY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=NtxAR5OtaI02VZfS2X3D6pPcL87InXfOImgJk5kScgAbs/SWACGM0BOF74JFci/i7L4UhHO6T8ukDIADxzIrowAVVJAdE4k37WefK/pdVcRcK2B/9vFo+Un+yRygBv4adn/P6jnsFIfrvd30KndsvNe19Qzd1OiaEJjA2YRnEw4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=hY4Edtuy; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=LKlh9hVOnB/K2o7RLmzS0uBIBkUJWNr7avAUzdtD2pY=; t=1716994503; x=1718204103; b=hY4EdtuyiN/2SnkNKjYKgRnvz7ND5tMCviUZdFx5oTeaWIw pdt6xQFveEUXPuGx6IgekDy1h3Waa/LxwsGj4kZwvv3DaGQI5UxuVUYiqbtvdo+b6364qkFQotCVn eGQyi6k44TkYSNuFfxvh5igLnGXw5KxQkPgzAbFI2stOTnyl3CoboTezTiesQ/CpTFLnCK7xU/OSv RTWUQBYgX9zt1HurbKmz3lqR/y8thxjQdIujnYB5ZndfJC5/KMNtN7J+P2YAzx7TDqtqjTdMQj+UK 4E8Kx1J5qPUeU88mxoGgMFhHJne/iqkbyGwizjoPY16DYgSc5wuIDg4/a29/rW+g==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1sCKhZ-0000000H44c-3tbZ; Wed, 29 May 2024 16:54:54 +0200 Message-ID: Subject: Re: [PATCH v2] wifi: mac80211: Avoid address calculations via out of bounds array indexing From: Johannes Berg To: Kenton Groombridge Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Kees Cook Date: Wed, 29 May 2024 16:54:51 +0200 In-Reply-To: <20240517145420.8891-1-concord@gentoo.org> References: <20240517145420.8891-1-concord@gentoo.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Fri, 2024-05-17 at 10:54 -0400, Kenton Groombridge wrote: > req->n_channels must be set before req->channels[] can be used. >=20 I don't know why, but this patch breaks a number of hwsim test cases. https://w1.fi/cgit/hostap/tree/tests/hwsim/ johannes