Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp803190lqb; Wed, 29 May 2024 10:55:15 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW6fhTWYufV8S1JBAYXmCwtLj74hF0fwvJrtFaB/r3pkXrlQncQRdAnEy6Ycdf/D/isEYeomAhVgKLr1kJKPAkTNHXVWRjdmfAXT0Exjg== X-Google-Smtp-Source: AGHT+IG+QSj7YZwPdGmTuFPW8kgfqHY7jZQ2pMNicXWd7w4lTWPWdO7JwaTGYQ0LjnSFc8E3lI9M X-Received: by 2002:ac2:47f1:0:b0:52b:78c8:13cc with SMTP id 2adb3069b0e04-52b78c815d7mr843240e87.11.1717005315076; Wed, 29 May 2024 10:55:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717005315; cv=pass; d=google.com; s=arc-20160816; b=0A/97XcWCXXDw7pegOHWQW2F52mk9lIWk06Fn6BF71usi9cAFrmPiW04/WYKFlo5yO YtyFmEXpDorsTGxW0L4RsjrNaz0UKlBS0O0yX/rPD2gu9v0V2j0bVeEVvOXnZ4vCrogI 9Bm/u+UilwJ/lUBzTnsJbhu5NmoYmqPJxv9h1TYfbX8W7I53wBTk1Owd02GnERL2ZY4R gZ19z+kOo02ElxvVlIbh5gHscv5KkgInNzCmG2nXmelr7b3HqpJGflyI3JOufdXyn5S7 OzSN0fStidkwZlrJny1OF66w7GUWNv+5tHaCsJFmMFt5NW3JrTvbkakJgIikZ9uhPEDO hQ/A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=8EGBGXRWDXHmr+52KMSdLqQ2aEKgcwz/IJoIyjye57U=; fh=BSOt9/g59z4YCndMXdHoCqYnaOCOftIop8Ul3+13f7I=; b=Z9CcrZlsE3osraNJfElPuFtkauh9w23RgqmBcDrK3b1YebPSiwY0Ix35NcwvH0PzpH Er0RiTN0t2byk5AnVrbEBm1EzaYH50oU6v/4qwAySpHU9ylPvu9wetMU7c+8VLIVHjEh U1q7HwYftHhlreFn6aBBolyBRn7z+FHY7xIAe/gN0FmoG0WrEXBRpvZ4Qfg0E4/C58ng zzVrSnxsd1HBvCrAZKQVNigYolvFVh6RPW/Z5+XReDGxwcwymj/uNOV6sZSlzirxQsru vvnM4CIBguEy5P/DOVu5mXbwitmlDwQ6RGYDp9BSSVY7eyzen6CV4AgYDEekLYaRX6Po m+AQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JrWVtk6z; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8277-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8277-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57869c05d34si5368111a12.348.2024.05.29.10.55.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 May 2024 10:55:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8277-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JrWVtk6z; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8277-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8277-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 9BC5D1F2294F for ; Wed, 29 May 2024 17:55:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 118EF15B551; Wed, 29 May 2024 17:55:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JrWVtk6z" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF055DDA1 for ; Wed, 29 May 2024 17:55:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717005311; cv=none; b=Fbul8yoo5N4OeI0ESud9ZRLTTcONjvm1AG5RFNFFjJ9lfMn4IwY+rGkGLUOmaWBrjwFIC8/IDLMYakvdHYZ3QHX2Bz+RtoSil7QkClEAbt6tiPRL63PJioWGHF66N7K38TRBbH+tc1s2FwXy8cXgBLRgoGW3xCEQlIfgllbeFXc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717005311; c=relaxed/simple; bh=fbsACgXOaS6r9JjfiBziDzgumtxSq46X0N+/fT+6TAk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=m+lJkRg/lKdUYjD3remcAvwl6fi6Zfw3YQYp5SKVAUHUvngiRcSTn0SPwOjbYQTmndsbcPCLdl400GAJFpgKH035xKKaiBL4VwYtkMZm2cyGsikbGirOeBgxImoGO118QhJ+86A3YoR7s8Vxd4YDCCZLsLt0aMaI2gTWNmng650= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JrWVtk6z; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CB11C113CC; Wed, 29 May 2024 17:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717005310; bh=fbsACgXOaS6r9JjfiBziDzgumtxSq46X0N+/fT+6TAk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=JrWVtk6zNNHuyf+pKQbeT0+Nvny6kOlslLoWjVNlNFEtVU1uj+oLPsCHZ+hh8KH6F 8sZOKKQ6yvoz6GAAZRgHHDrhmu/aWSmsTK7CbtOdNs74RXQ3k6R4fq4Z+CLmIeBwId Xr8FDCsIyiCJVt6ZDfzAGQIDGXrY9shc9pdxPdZEpQrUrwcVINsvv5gazrVSORhu0Z B24HVvD4YEhYzsSYWgDhP+A4RL7TaI6pJzqzfmnwk49giiE4IAVesUgYnYyTNelDUJ JImGnZ6AYXt8b4zGBC2z9N3iQmX7KXLoSZ5A7pvPt8k9Z7FsLAuexyt1WsjhXCAb2H +ehC2tsvZGflw== From: Kalle Valo To: Bitterblue Smith Cc: "linux-wireless@vger.kernel.org" , Ping-Ke Shih Subject: Re: [PATCH] wifi: rtlwifi: Ignore IEEE80211_CONF_CHANGE_RETRY_LIMITS References: <1fabb8e4-adf3-47ae-8462-8aea963bc2a5@gmail.com> Date: Wed, 29 May 2024 20:55:07 +0300 In-Reply-To: <1fabb8e4-adf3-47ae-8462-8aea963bc2a5@gmail.com> (Bitterblue Smith's message of "Wed, 29 May 2024 20:19:47 +0300") Message-ID: <87o78omrk4.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Bitterblue Smith writes: > Since commit 0a44dfc07074 ("wifi: mac80211: simplify non-chanctx > drivers") ieee80211_hw_config() is no longer called with changed = ~0. > rtlwifi relied on ~0 in order to ignore the default retry limits of > 4/7, preferring 48/48 in station mode and 7/7 in AP/IBSS. > > RTL8192DU has a lot of packet loss with the default limits from > mac80211. Fix it by ignoring IEEE80211_CONF_CHANGE_RETRY_LIMITS > completely, because it's the simplest solution. > > Link: https://lore.kernel.org/linux-wireless/cedd13d7691f4692b2a2fa5a24d44a22@realtek.com/ > Cc: stable@vger.kernel.org # 6.9.x > Signed-off-by: Bitterblue Smith Ping, should this go to v6.10? If you agree, ack and assign it to me on patchwork. I'll then take it to wireless tree. But feel free to take it to rtw-next as well, your call. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches