Received-SPF: pass (google.com: domain of linux-wireless+bounces-8285-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Ping-Ke Shih <pkshih@realtek.com>, <linux-wireless@vger.kernel.org>
CC: <shichaorai@gmail.com>
Subject: Re: [PATCH] wifi: rtlwifi: handle return value of usb init TX/RX
In-Reply-To: <20240524003248.5952-1-pkshih@realtek.com>
References: <20240524003248.5952-1-pkshih@realtek.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain
Message-ID: <6c92777d-1f82-40de-97ef-38516ac9e9ce@RTEXMBS04.realtek.com.tw>
Date: Thu, 30 May 2024 10:53:11 +0800

Ping-Ke Shih <pkshih@realtek.com> wrote:

> Handle error code to cause failed to USB probe result from unexpected
> USB EP number, otherwise when USB disconnect skb_dequeue() an uninitialized
> skb list and cause warnings below.
> 
> usb 2-1: USB disconnect, device number 76
> INFO: trying to register non-static key.
> The code is fine but needs lockdep annotation, or maybe
> you didn't initialize this object before use?
> turning off the locking correctness validator.
> CPU: 0 PID: 54060 Comm: kworker/0:1 Not tainted 6.9.0-rc7 #1
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.2-0-gea1b7a073390-prebuilt.qemu.org 04/01/2014
> Workqueue: usb_hub_wq hub_event
> Call Trace:
>  <TASK>
>  __dump_stack lib/dump_stack.c:88 [inline]
>  dump_stack_lvl+0x116/0x1b0 lib/dump_stack.c:114
>  assign_lock_key kernel/locking/lockdep.c:976 [inline]
>  register_lock_class+0xc18/0xfa0 kernel/locking/lockdep.c:1289
>  __lock_acquire+0x108/0x3bc0 kernel/locking/lockdep.c:5014
>  lock_acquire kernel/locking/lockdep.c:5754 [inline]
>  lock_acquire+0x1b0/0x550 kernel/locking/lockdep.c:5719
>  __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline]
>  _raw_spin_lock_irqsave+0x3d/0x60 kernel/locking/spinlock.c:162
>  skb_dequeue+0x20/0x180 net/core/skbuff.c:3846
>  rtl_usb_cleanup drivers/net/wireless/realtek/rtlwifi/usb.c:706 [inline]
>  rtl_usb_deinit drivers/net/wireless/realtek/rtlwifi/usb.c:721 [inline]
>  rtl_usb_disconnect+0x4a4/0x850 drivers/net/wireless/realtek/rtlwifi/usb.c:1051
>  usb_unbind_interface+0x1e8/0x980 drivers/usb/core/driver.c:461
>  device_remove drivers/base/dd.c:568 [inline]
>  device_remove+0x122/0x170 drivers/base/dd.c:560
>  __device_release_driver drivers/base/dd.c:1270 [inline]
>  device_release_driver_internal+0x443/0x620 drivers/base/dd.c:1293
>  bus_remove_device+0x22f/0x420 drivers/base/bus.c:574
>  device_del+0x395/0x9f0 drivers/base/core.c:3909
>  usb_disable_device+0x360/0x7b0 drivers/usb/core/message.c:1418
>  usb_disconnect+0x2db/0x930 drivers/usb/core/hub.c:2305
>  hub_port_connect drivers/usb/core/hub.c:5362 [inline]
>  hub_port_connect_change drivers/usb/core/hub.c:5662 [inline]
>  port_event drivers/usb/core/hub.c:5822 [inline]
>  hub_event+0x1e39/0x4ce0 drivers/usb/core/hub.c:5904
>  process_one_work+0x97b/0x1a90 kernel/workqueue.c:3267
>  process_scheduled_works kernel/workqueue.c:3348 [inline]
>  worker_thread+0x680/0xf00 kernel/workqueue.c:3429
>  kthread+0x2c7/0x3b0 kernel/kthread.c:388
>  ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147
>  ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
>  </TASK>
> 
> Reported-by: Shichao Lai <shichaorai@gmail.com>
> Closes: https://lore.kernel.org/linux-wireless/CAEk6kZuuezkH1dVRJf3EAVZK-83=OpTz62qCugkpTkswj8JF6w@mail.gmail.com/T/#u
> Tested-by: Shichao Lai <shichaorai@gmail.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

9c4fde42cce0 wifi: rtlwifi: handle return value of usb init TX/RX

---
https://github.com/pkshih/rtw.git