Received: by 2002:a05:6500:1b8f:b0:1fa:5c73:8e2d with SMTP id df15csp1406060lqb; Thu, 30 May 2024 09:12:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW3uIsH9aO5jiZ4JWt9Q64EZPHwnLc47XIAQI9HjRrIaqpMkyvCOhSrD0LrWCL01cXmwRSfSViRcAu/f6AstXt75L5XRaEGYQTP4xpW0Q== X-Google-Smtp-Source: AGHT+IFTZFRP8OjVGzmugiQDar5zeWcVdnSv1W7LIx2eEnNodYjNIN5lN52tP0pyGBvnUhUyFuQt X-Received: by 2002:a17:903:41c6:b0:1f4:befa:7a44 with SMTP id d9443c01a7336-1f6193f8931mr27608415ad.1.1717085577311; Thu, 30 May 2024 09:12:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717085577; cv=pass; d=google.com; s=arc-20160816; b=M3/0sWlTfF+N3r6jbufi3eDPByJhZTQT52v4aahZQq1+M1qgixncpnys1gHSvdtsdO arBSmiNVU+sww/EKKoQ84BQB7FA/saKtku3jvtQ08di8E0lDaUEBbZyfsefSP66e590+ PsA+Nxv+nDyP2PWekhiLpxPqnQfqGhMtTlLJusGRj75uqxoOX0Gg6BT/korVsN+FAIC6 EnN0/Ee0CBOWyt6KvcuuBw/j9fEP3jDuHdhRWGturgQkznbkEmY/rYwwMq8cQZko4DWl JlOplypzVOzjVxAoEcp1hDB27Z4wuNZwzKlmdIg9AEQ0zM9zJ3GCr6PJ/CWAUoYjYq6c yVmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=DotFDQJII63j/t0pQuZL/g0ddw3jSvtU5hZEgf/theU=; fh=q0pWxAdL0cyDcfHi0eFkTCBsBNeBmItsjEnoI8WnNeM=; b=ZUjtlD4ktE0dJ2zTIKarf6Rp2JxLcwqu7aqB+by6JfwVjzI7um5atFh80Z3XmQLUs4 3h0FATsj1V53P4KKdpkk7mg1uBg5nWY3TOrNdxGyC5ouShoJD2lflYyzzwMkAszC51xq T60IgKtBj69HB7OT3bT+MbR/pFa4VdxnpZFC/fB+dN2KNaMoiLAmdkbcpDxDqkzJ+aeC Iv9q2NinjYXd9NLRmlSiic1PWW9NtPqPFj8CTiyE2f8uRrNdqWFfXsQkRLS5RlI2OIKc lqkSPU5M8qA8DGd4iM59BlAJe27nXkpQ0J0eY9ZQuG6/7knlUoke94O/BQtVkLynvhUM ZmDw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W76rWAWo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8319-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8319-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id d9443c01a7336-1f6173cc45fsi17838595ad.41.2024.05.30.09.12.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 May 2024 09:12:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8319-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=W76rWAWo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8319-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8319-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 7D282B28322 for ; Thu, 30 May 2024 15:49:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C22161EA8D; Thu, 30 May 2024 15:49:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W76rWAWo" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CDF21DA23 for ; Thu, 30 May 2024 15:49:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717084170; cv=none; b=L5o/7kaFziC2XTvMzhX4lnNd/6uMNNR/Yw7CBoZjpecmmLODp7OVp4ABhVq/qz6nQUSCx7a8zS/GjOXrz2ZG6M8ub/425CTmTlEa0jDU88ItD+m1I8QDJExe8ts9D60DWSuBiZu08C5mQrs5FQPsduPCm4UzsjnTP7PqKc5QV+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717084170; c=relaxed/simple; bh=0mrtFxmnKphhdbbAOAMZrrK6ThPiZ89bJ1wLJ4t9xeo=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=FCaE2Fnkm39Pzif8WdiR0aRaxgWDaO5Zs79iMPqB6/JRkxU/31U/OB6+m3Sx/Yg1SNEBcvDrkG5TYRkqDsR60zobQmucyVj88SEeIsfQIpv6ITKzYkKTM/W3YqpuvY/xx8yIsnOPmHrKTqDsbFoUCi9jGWaj/H4Nw76wTvpuMg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W76rWAWo; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2AE0BC2BBFC; Thu, 30 May 2024 15:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717084170; bh=0mrtFxmnKphhdbbAOAMZrrK6ThPiZ89bJ1wLJ4t9xeo=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=W76rWAWoP3T8RGwrFN/CxV0OdpVHAqWicn7MredWG0uzT6yQpW7Yja1EnaHXfSJWU 7ydZFyB2pKrbuFjMPMwAfZG+6OUA2qkwdllIvCCI436XIHFhekbWO89oQhX7wk67KB F0uEgeeCiMdYm949G62X9iOH2IZ9MtT7MVudtHvCm6cCqj+/hmwyC+mS9/4lw7WCHv wUPhYIwaoC0KAEyk+7Y3jMwvy1qiy7vgSnzyjT1x24oDfCDNdCn+Rk5fjfqHOOi74N i5hztsvCq6pb0X5L33ynTbQmDZoQy9vboF5jviz3cxoqRObZJ2QlatGIxuYy+Kcznh QfU5IzLQac5Zw== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: ath12k: fix memory leak in ath12k_dp_rx_peer_frag_setup() From: Kalle Valo In-Reply-To: <20240526124226.24661-1-quic_bqiang@quicinc.com> References: <20240526124226.24661-1-quic_bqiang@quicinc.com> To: Baochen Qiang Cc: , , User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171708416720.182911.5669999040960213709.kvalo@kernel.org> Date: Thu, 30 May 2024 15:49:28 +0000 (UTC) Baochen Qiang wrote: > Currently the resource allocated by crypto_alloc_shash() is not > freed in case ath12k_peer_find() fails, resulting in memory leak. > > Add crypto_free_shash() to fix it. > > This is found during code review, compile tested only. > > Signed-off-by: Baochen Qiang > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 3d6004154318 wifi: ath12k: fix memory leak in ath12k_dp_rx_peer_frag_setup() -- https://patchwork.kernel.org/project/linux-wireless/patch/20240526124226.24661-1-quic_bqiang@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches