Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp648366lqh; Fri, 31 May 2024 11:53:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXZJzkFK6NyX4mYIvad1weYq6SFn5L3yJji8uMqJ1S9R6dM21Jwezrz/tnl1marOdA46OMZ13I0owveXxatCJR+Y1q+s1w8mKycXIhcow== X-Google-Smtp-Source: AGHT+IFUEM3Po2x+mvEx8y+OlyaKkteyOP/hQvwNFAwlrg7W/u2oKXgtFEfBTYqhGFkrEVg3j9vS X-Received: by 2002:a17:90a:1f83:b0:2bf:8fbc:bd4e with SMTP id 98e67ed59e1d1-2c1dc56dd43mr2491994a91.8.1717181620753; Fri, 31 May 2024 11:53:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717181620; cv=pass; d=google.com; s=arc-20160816; b=VexUE3rLuxE/eYnoKeNgWdNJrntSFE3kaxLiepc5NrniJMuvx84MWDKaLVjdy6TrTC 5CyjyFb6i2U4x4weBUF1TBzviu/NTM8mdqL5wzw3Rphz1SDAMjE8/85pdAdhodA9NcDJ fh1Rd9PzYmGbVABDlbLb8Q5IRVDOnOhzVMEMTXSUmOwsAIOD19/6j37Xy5MAiOwP862M qcmWAkkAvqydXRWr/s5VkxbhzwxuFF3FXVKSn+x6L8srt9CiU/6BJI75nl15Df93+B1Z 1OjkpXlNx7PSeg3pEudcgSH1PRfrxqoy3CehtlTrKt+MNIDzR5J6Epkn3zCtf13kUFe7 /1Jg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:message-id:in-reply-to:date:references:subject:cc:to :from:dkim-signature; bh=/LQQwooe3duzYCgvytDLcrM0kPik8Pu6V+lEgmxcMLc=; fh=7k1BpC5ftOLvdMRsnPSEVGSdnUs1fo8iKL/5UOdzDOg=; b=eYZlj6VpUf4apRYzKHawJL9qmVjZmsfc95aqmzr5ObD9cEzmRAYU4mSBv5HSOZDL5f xZlwZSsaJbnWQxoCVMTvs1Fjflqn2hBt6EQHE3sqDIx4InrC7mXTfCZlijcNdEjQo/DN i9naZ+LkrmXA8xOX6Ayy5JqJtmk0uajF5SIj2UMIxtsT7/uvfZHUqOGqWy69uxJ9gw2L HgQF2VioUhT1sw8/mjP6AWIplLT4ok7dT29ecKuYpeMeeOmSXSECPMk7gefNbbDtGed4 KylktgOK/7GPC72APa7KPrHwKwoC29HEYPPrkkxroSaxvtVt2QbsqqMRBmOGCcwNasYB bYZg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LPU2yyuK; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8362-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8362-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id 98e67ed59e1d1-2c1c6481545si1805586a91.87.2024.05.31.11.53.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 11:53:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8362-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=LPU2yyuK; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8362-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8362-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D4256B2281A for ; Fri, 31 May 2024 18:53:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 927D57E78B; Fri, 31 May 2024 18:53:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LPU2yyuK" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CCA17E761; Fri, 31 May 2024 18:53:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717181610; cv=none; b=W4jm0eq++NEXv+5UBt8brub9Lk+e/uYv7SAiq5OByUj9ODwKi0y2d4LPeOZLV+QE5kLqVpiZFYLDwYcYUo5jBChYhGS3UasZ22h/caUZvvKdFLJcLcPDQZb9jUAPKKggfbvMpsRPYnklelK70V3YWFVHB4Y18EcFvtuFPAnxdOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717181610; c=relaxed/simple; bh=kP2teycQbL2Gc6/fKZ6aB8TWymQ7VtmJws0fyRjuoSs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=QpVd5S9qxuCTuObxuiVBJLyjR8az3756BIZndaOxYPebQ6WmycfbHuLsN8XxXquVwAS6HV80cok97cD3aFOc5Ec7vcCFAFkfkQasn+4BY6DQMiKF1abldf0fMUukfWihCPt3T5krZbpkAC/03/WxoWfG6trTwEiYIidPu4tTxxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LPU2yyuK; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05CCCC116B1; Fri, 31 May 2024 18:53:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717181610; bh=kP2teycQbL2Gc6/fKZ6aB8TWymQ7VtmJws0fyRjuoSs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=LPU2yyuKc1kxS15QMNDL0ebEIhqNUtLH5hw1khLndbJVeXI/e4OBBbK7z3kn+9OhP BT5PD/PIsBAdW4rDlLBe3gQjqFShgjLw6TvJoqd6zUH8r7IvMwaf72SCgQ9kQhsRMu 56XdZg8e2r2leNQZ8wfNsNpMrykucZ+gUXN91EOZNHmyaGMh/rTxR179x5AtQRwhxC MoUbH1oGToEwEhUo+KbEKgPmQQ7xMUAMhjCtLYC8ngeeDd4bp3i6JbLdL+spBaWCR8 cN2/tDvITUgArD5GbLNmMb0pB+ZGXNc23+SutWhroGl0hggOT1SrIuPW6y1QV+W018 u1AUCaZI/Y/pg== From: Kalle Valo To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Loic Poulain , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, Arnd Bergmann Subject: Re: [PATCH 02/12] wifi: wcn36xx: make use of QCOM_FW_HELPER References: <20240521-qcom-firmware-name-v1-0-99a6d32b1e5e@linaro.org> <20240521-qcom-firmware-name-v1-2-99a6d32b1e5e@linaro.org> Date: Fri, 31 May 2024 21:53:25 +0300 In-Reply-To: <20240521-qcom-firmware-name-v1-2-99a6d32b1e5e@linaro.org> (Dmitry Baryshkov's message of "Tue, 21 May 2024 12:45:22 +0300") Message-ID: <87ed9hvmmy.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Dmitry Baryshkov writes: > Make the driver use qcom_fw_helper to autodetect the path to the > calibration data file. > > Signed-off-by: Dmitry Baryshkov Not a fan of one sentence commit messages. It would be nice to explain a bit more in the commit message, for instance answering to the question 'why?' and maybe provide a short example how this is supposed to work? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches