Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp949364lqh; Sat, 1 Jun 2024 03:09:18 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVfp5XE2qbatkaL8H8H+nHCy3tTKAFT8yyQ9bOu5Gbg27il2cSnCbWgfnGC6Xg1tS1cpDgKuXll/mtrhMDQYcCrZtwUp35tiBNxohSoBg== X-Google-Smtp-Source: AGHT+IEIHlv4cXEysRIQlfILg8ljM24qSqVxFYvZG1ekRyIhiulL8nYiGQFqhVrokKobxvEdvF/E X-Received: by 2002:a17:906:3917:b0:a5a:2d30:b8c1 with SMTP id a640c23a62f3a-a681fa6a8dbmr292700766b.14.1717236557926; Sat, 01 Jun 2024 03:09:17 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717236557; cv=pass; d=google.com; s=arc-20160816; b=inmA079GqCcV7GyAln4MCFk7mCttnipYrpskbw1C+KPn+LdM9OQm9SpUD0vyaw8Pr7 r6dQvUHPDrsCMnuveBTIcTGOkEFsmk+oNSFC7RVuB193QGrdqazG+fmO2pbxD2GKF8eG DRSrSOtzxCkJbbcQfsEAutA5Rpwia5LB2/DVl0KKfuFKcsD/RsIJLyuxEiPU9EkBpOXQ gIgRTVJ8Ykb//fnytRwIi9vMA95zBi1DcsTK+RZWHypvjC8ECoPyjpREgH+7UtNRJ+HA JXJOU/gXbplQWY/tYpNvoCQp7IXXI444hBmhUuma5PQf6h6NGAqftSPZvazB2xRpU6pa uOcw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=sa9CQ3Xcuq5GcTxHekh0I6YZDm1OtHgA3zwjRD9w/4I=; fh=SbWCB1DGlb7lSDHV6wN/ycLHitkXXOIKLl8Q7XSti9k=; b=0jqdL4Gd6ra70AxafPXjCimVnsSc2JgD7FvuWs3YSAxGvyn6DDUqgK9AGon0l3rCwY UGFTSvcT/pp1znSFssmxUsoa3loNYiCdzfXwnkghmTT6m1yKjaeQ6IukDWpWw5z1aYXf lwyOiLFD2nQLRxhrqSLDC6OZ6wTIpGfQvFo/D+P4nKSb6O3Vmvii9GE/HvSoqRytl8AE fNzFyVlk4fWbEA4HAj6WiGng3j1RoP7t8fjzmB5lRVZwt2Zo6TcBRYKSmKjqtX6CrCqp 0LU2qBP+Ev4TCQxVCOql9N4kycjcqqmDXMZ2yI5vmx6igrKQ+JRlbKUC8H2kqXW3lIv1 Ps/Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NYo6EkAv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8372-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8372-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id a640c23a62f3a-a67eb723516si181222666b.969.2024.06.01.03.09.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 03:09:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8372-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NYo6EkAv; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8372-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8372-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 960291F21BFC for ; Sat, 1 Jun 2024 10:09:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 202B578C75; Sat, 1 Jun 2024 10:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NYo6EkAv" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBB2F14EC40; Sat, 1 Jun 2024 10:09:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717236552; cv=none; b=DIxDFDSnU99jijlM4o294DIBIzT9V6qA+xoiLv4gQytixpOVKDdNP8d96ixvPdVk96JHN9wtuQ3j+UnHFh2a+Kyxw5cWPblcCBXAFSSpBUoIC4Jbla4G1vBKToG+SW3KB8ppFdeLXaK3Nu128TprvNfbGpU9OMrJuzJUevicyO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717236552; c=relaxed/simple; bh=eg7kSV+oZNUijIr+n8b0PdQe/EUyo6Zlq8g8R/fM6rk=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=mfRWN2vc0FAupYmj8tlya30PCowC3JSDbwTgSE7iJmkPYuDWzx5zp/4yZQpo/CQAQ4bSLnQF4razuoEweMbyO+DHIhv+zOedQRHr3cte3DExqzusx9OCSY1FRYW+oPXIBQ4RzWW8/eO6htBvDMSxvyEak3DE917HW4HdR+fxcFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NYo6EkAv; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC8D1C116B1; Sat, 1 Jun 2024 10:09:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717236551; bh=eg7kSV+oZNUijIr+n8b0PdQe/EUyo6Zlq8g8R/fM6rk=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=NYo6EkAvZo0JzdwSsvsSMHY2GLZLqVDnuQ6e7WxF6HW0DjhhCYNBtlZr1AJYhfZRV wlII111ot1aUIcc04aO6cUqarzHFyLnxzYAJUIIW2EHngyaC+PJ96Mro7WG/tA7kQt Rt4RyTkOcwBKV8UGugO5ionsNb/pc7OY7wIpABtdxTHm0idw520vQfjJbZWfrOOKu6 LOri+nJsX2VAaaSYbbCoQycCCDWT2/zwW2ugQnsraHaGyl1L83vpwfqIQCXAuEuRfX yD3v6zrjJ1BpLMH9aRqWnvHkUKAnu7B8SKyPm+jJuCH4MA6YbKC6UF33cestpSK4ax XTpnELiEv7k/w== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v2] wifi: brcm80211: use sizeof(*pointer) instead of sizeof(type) From: Kalle Valo In-Reply-To: References: To: Erick Archer Cc: Arend van Spriel , Krzysztof Kozlowski , Ulf Hansson , Christophe JAILLET , Yajun Deng , Greg Kroah-Hartman , Alan Stern , Dmitry Antipov , Johannes Berg , Arnd Bergmann , Jonas Gorski , Artem Chernyshev , Kees Cook , "Gustavo A. R. Silva" , Justin Stitt , Erick Archer , linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171723654505.1034023.720377583197621246.kvalo@kernel.org> Date: Sat, 1 Jun 2024 10:09:06 +0000 (UTC) Erick Archer wrote: > It is preferred to use sizeof(*pointer) instead of sizeof(type) > due to the type of the variable can change and one needs not > change the former (unlike the latter). This patch has no effect > on runtime behavior. > > At the same time remove some redundant NULL initializations. > > Acked-by: Arend van Spriel > Signed-off-by: Erick Archer Patch applied to wireless-next.git, thanks. dcb77f854ae0 wifi: brcm80211: use sizeof(*pointer) instead of sizeof(type) -- https://patchwork.kernel.org/project/linux-wireless/patch/AS8PR02MB7237FF1C2E880D1231684D708BF02@AS8PR02MB7237.eurprd02.prod.outlook.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches