Received: by 2002:a05:6500:2018:b0:1fb:9675:f89d with SMTP id t24csp951864lqh; Sat, 1 Jun 2024 03:15:45 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCXiZA3ow7jcOLpS9+nIif1iHQw/z2ZN0KNVQPZrVcKpsIOCx5LdPDp4POw24VQ+Ml3WMwhpd9polOnhNpPDKeXg0Ya2O2fy8N+kF94FEw== X-Google-Smtp-Source: AGHT+IHizzewSCuEYolICKM/dQI4r6pho3KzpuWfMPhC3b8/wcUTKdjMC/a6+iKK5AVYG5/GZGE8 X-Received: by 2002:a17:902:d512:b0:1f4:998e:823d with SMTP id d9443c01a7336-1f6370c1d87mr49906865ad.67.1717236944733; Sat, 01 Jun 2024 03:15:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717236944; cv=pass; d=google.com; s=arc-20160816; b=XHo+3BQdqKACWZSs4NcYqTtzIhHjG4oxZcAbqbH0lt4Ea4LEP/9jzukUjf+KdNYFyh pKccRi8EG3WsdpIye9fiYuVAWdfgpLe65eBE961LMMtz3BvzuI4c14q9IuWi0uqtRUC5 ajxl8xvNqhQa3wTvr/wNFJobArQ/xR1qCwjGXS3tUYIHCXFB7SNvCnxH7YPXGnIVH7Ex wf8ChVxtRYGQVoQGqRiLLxeUbRuXG/FR9zwUwos92ahi92c2X4bdHa7N3E4bdtGnVSPX 49lwp/9jUlI8PiZ7Sc3miagfnUCABZKVgm7U6LS20DfBNIThBGtcnqyhWHX9R+f1RArI CzsA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=Kf8HNl1BbxKzURlKAg32AtnooufwVoBu9gWHECkvKJA=; fh=BSOt9/g59z4YCndMXdHoCqYnaOCOftIop8Ul3+13f7I=; b=bti7JRvgOFD/GacahaboXKLZNKcCQ4IywBGL7pL1iG9ahh/K6E6Pc3PN0Uu9FygZfX T565cLWE/Ze9TooI2ithb3Ya3so4AU/N4uyq8WMCUQMeria/2i0/5sKHiBehzovYSDUP os3Ny+HIUs3/fEyk+HJhy+UOxJSdpAJrOgZEUpukgUgRBOkhlLbuyV7iKm+kMNLozZ/y aKrbNQ77H9MxRtgBY+bPW2d6lMTBhzd8UoQafjJSCAdbfOr3fKibd7Tic6OL/PGB2u3i j3sqRkomN4jh/6uIUCRIhsXGy/PxL0l+mDswJoXWIxwBRD3S4a3WAlJDsW6RDjnKmlNo /dZw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kGcUA2bY; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8374-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8374-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d9443c01a7336-1f63241acb2si32152635ad.615.2024.06.01.03.15.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Jun 2024 03:15:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8374-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=kGcUA2bY; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8374-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8374-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id B317DB22A77 for ; Sat, 1 Jun 2024 10:15:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D5033AD59; Sat, 1 Jun 2024 10:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kGcUA2bY" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1323846C for ; Sat, 1 Jun 2024 10:15:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717236935; cv=none; b=fxa7B6ZCSEoLzRAsvZz6S4E5fzRGyBIf5Z2L+aVK6G3BGEMM6Ywgj/5iY7yfMzFqhG6ktga0XMNOZGlBIJqt+qkfglbu82LfHAjLmkKIBH4a6GSp/xHE+A6s2oJKs4u6Q2Vc7mZ4RBjjeKQ0Vmfrm2UDpFQwua+zRjKG3tpeQ/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717236935; c=relaxed/simple; bh=I+urqZeqP/RJ589i7U6evxXFo+gBeJpw521+t1ZTQew=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=TJmnnUhwLMe3TNIrxLlzQGLJKJnlzV7GWKrI7WEZPz6WndEFKAqK8qw8ygDKmQP9vlGZpOBVyYhHOIAzLYm3E3Ffl3YM9QY113VmbjojppC4xQoL+sFeVB1p2hbCXgySfFTJkRc0dmB+12gLEFGlQUlVV1WYQAQmGhI7rJAJArA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kGcUA2bY; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67E8BC116B1; Sat, 1 Jun 2024 10:15:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717236935; bh=I+urqZeqP/RJ589i7U6evxXFo+gBeJpw521+t1ZTQew=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=kGcUA2bYJkvqrZHmt3Jlntzeon9lvBggQJ0WvVKRqdPD3xqXg1Rsr0iDQJzk/MQwK sxUqJpOJKYQY82hlLfLIjBInOyStMAcIQVMVCmCiasyWO3nqpJ4TKr3J3eKcd0X9Zv 4uhnfoOisbuQTlPu/UXcVZJs3om4Fz6lcg0ljNsj1BmdXoAY9U8SJhZxVfY7ZJ0cub gL3EvesW7hVPucik1I4n0ekEvQ3zDHdFKPiM15MOrE7Yq2NvFIVJGNj0Q3wE0PX5fQ J47YcEVX6fYCWpwxjqu2kpTNCWkj3aKwYRtHOSy+pk5h7+fovcgX2vygv7xVjxVcPh nmNlnG1bYv7TQ== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wifi: rtlwifi: Ignore IEEE80211_CONF_CHANGE_RETRY_LIMITS From: Kalle Valo In-Reply-To: <1fabb8e4-adf3-47ae-8462-8aea963bc2a5@gmail.com> References: <1fabb8e4-adf3-47ae-8462-8aea963bc2a5@gmail.com> To: Bitterblue Smith Cc: "linux-wireless@vger.kernel.org" , Ping-Ke Shih User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171723693285.1122510.13353583356130532921.kvalo@kernel.org> Date: Sat, 1 Jun 2024 10:15:34 +0000 (UTC) Bitterblue Smith wrote: > Since commit 0a44dfc07074 ("wifi: mac80211: simplify non-chanctx > drivers") ieee80211_hw_config() is no longer called with changed = ~0. > rtlwifi relied on ~0 in order to ignore the default retry limits of > 4/7, preferring 48/48 in station mode and 7/7 in AP/IBSS. > > RTL8192DU has a lot of packet loss with the default limits from > mac80211. Fix it by ignoring IEEE80211_CONF_CHANGE_RETRY_LIMITS > completely, because it's the simplest solution. > > Link: https://lore.kernel.org/linux-wireless/cedd13d7691f4692b2a2fa5a24d44a22@realtek.com/ > Cc: stable@vger.kernel.org # 6.9.x > Signed-off-by: Bitterblue Smith > Acked-by: Ping-Ke Shih Patch applied to wireless.git, thanks. 819bda58e77b wifi: rtlwifi: Ignore IEEE80211_CONF_CHANGE_RETRY_LIMITS -- https://patchwork.kernel.org/project/linux-wireless/patch/1fabb8e4-adf3-47ae-8462-8aea963bc2a5@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches