Received: by 2002:ab2:7903:0:b0:1fb:b500:807b with SMTP id a3csp696073lqj; Sun, 2 Jun 2024 18:46:53 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW4E2gXWmbTqJQyt+3Df3NGLPH0Ifi+xl1ioOayKXmIMek9RTKTsJevJSprD3dwdbwWtM5VPdVUFaUa43R7O+mLdMa/SaUnd24lXAyWcA== X-Google-Smtp-Source: AGHT+IFse7d9fomo8dn0vjkAmaaUtbvh50gAzvB2Et6fmiLLtdqb2GGUhOva7ZUoS+Nvjz8R7jNv X-Received: by 2002:a05:6512:7b:b0:52b:8843:b084 with SMTP id 2adb3069b0e04-52b896bfa33mr5345227e87.47.1717379213358; Sun, 02 Jun 2024 18:46:53 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1717379213; cv=pass; d=google.com; s=arc-20160816; b=kmRLeWM5x/CoIZG/cosgwY9+kmzei2RaHQAduUH4+m+vOVJLkH0sv7SrnJUSwAbzpw iJw5CUUlzhfjN2aNrHNoye08m80s4DmAN9WFjSEJjm1swyOlZ3IQrRdyBT3zHjn4o9j1 z/AIrIgAxYgmCdj6khBdyicrOwfwa/2NXmp1UU3EL3cyjjL/ss59oQW9i+RhBzPncFOo iGz+iBZ0wvUjIuL5tf6wmTzrXqaz3/Bm65wkRc1FfMuWnIBuvyOLPaePgnFYZGUSZODM ktilgzlvI9zCjlDV+FvqJbY+nLVGrA+QggIOgkGFj7yRburZhAXCD+pey3f3n6m9EdY1 PLAA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:references:in-reply-to:subject:cc:to:from; bh=JzZqmtmmHg/I268vwTlReKgu3QJRHorQmIhdwTx+Aik=; fh=1bSMKS7ciU81bcI8d0Gl934GxkCgd6PirofYWHsjkHM=; b=UNDhheDvkCPdyn3jm6LwSM6ysdM6mM3OKhsBqQtch6ucrHg4XBGl/TRwqvxtgc1SJt sq0qm5DowbvueLLJTzmCgeKxT+r8lAFw9RpvcWXy+NBwo/eAnvFflx2rV0Xurt3cf+1K giB0hhXMsK06b3jkpprvQrf3+jhoF+dKEymxqSMCa0sziKKNfUG1rlKQpmRbuSa7B5c/ G2BT3Sj9sItfDi0dnnep/+qGKCeMXWS8xR1PxcPxuH1tW0UaDz2W6Fo8ZYN6qW5bBsJk +MeXRCSBvH71niF3Ghb//QCQRn/8xR5uUTk3xCq7LJokvn6bXpEQPZQCrvS1PDB3X6/m VJuw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-8388-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8388-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id 4fb4d7f45d1cf-57a31cb411bsi3555796a12.612.2024.06.02.18.46.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jun 2024 18:46:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8388-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=realtek.com); spf=pass (google.com: domain of linux-wireless+bounces-8388-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8388-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 052ED1F219D4 for ; Mon, 3 Jun 2024 01:46:53 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 15AC015C9; Mon, 3 Jun 2024 01:46:49 +0000 (UTC) X-Original-To: linux-wireless@vger.kernel.org Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDCEE631; Mon, 3 Jun 2024 01:46:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717379209; cv=none; b=IAx61accnckjszzjZWvquJdSv1+G9LKm86zQwuqh5U4lZCYeNjrw+7GFXHuzVfQhEEIjxNSlsr+oqZ1SS6jCsk5XMEgbwn9hTBzbvowg+e9+uhlIGT8ABWqrS5uYf/9Y4WT97S8MfMP/uIVzC+0eZkfMq3iV8ZNVV01qHmxdblQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717379209; c=relaxed/simple; bh=MBEvYpJ3XNUQU+0R0PKIw0/tcECMjyn8VNsz2Mp0e6A=; h=From:To:CC:Subject:In-Reply-To:References:MIME-Version: Content-Type:Message-ID:Date; b=sQl5lUSeNn9SIqI7U0TvXElsk7HWB3PyLQ5RUnsuUI2eBVOUL2zZ6cHZdBiu3fvVVSKhEzhcizt05rqIB2M49vKB9/kH5L6lE4nTtmRr+MWLS/pOHXuJK4j7Wp92rpeb7o9MyNGIYpkZZcu3DcogRmnnRm7repKo7S4Fs6Rmcx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 4531kY6f92151776, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36505.realtek.com.tw[172.21.6.25]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 4531kY6f92151776 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 3 Jun 2024 09:46:34 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXH36505.realtek.com.tw (172.21.6.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Mon, 3 Jun 2024 09:46:34 +0800 Received: from [127.0.1.1] (172.21.69.94) by RTEXMBS04.realtek.com.tw (172.21.6.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 3 Jun 2024 09:46:33 +0800 From: Ping-Ke Shih To: Jiapeng Chong , CC: , , , Jiapeng Chong , Abaci Robot Subject: Re: [PATCH v2] wifi: rtw89: chan: Use swap() in rtw89_swap_sub_entity() In-Reply-To: <20240529020244.129027-1-jiapeng.chong@linux.alibaba.com> References: <20240529020244.129027-1-jiapeng.chong@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Message-ID: Date: Mon, 3 Jun 2024 09:46:33 +0800 X-ClientProxiedBy: RTEXMBS02.realtek.com.tw (172.21.6.95) To RTEXMBS04.realtek.com.tw (172.21.6.97) Jiapeng Chong wrote: > Use existing swap() function instead of keeping duplicate source code. > > ./drivers/net/wireless/realtek/rtw89/chan.c:2336:32-33: WARNING opportunity for swap(). > > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9174 > Signed-off-by: Jiapeng Chong 1 patch(es) applied to rtw-next branch of rtw.git, thanks. 9373ed280651 wifi: rtw89: chan: Use swap() in rtw89_swap_sub_entity() --- https://github.com/pkshih/rtw.git