Received-SPF: pass (google.com: domain of linux-wireless+bounces-8407-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <43680bd3c444da4c1b4e55b4ee4c7043c1186ccd.camel@sipsolutions.net>
Subject: Re: [PATCH v3 6/8] wifi: ath12k: support ARP and NS offload
From: Johannes Berg <johannes@sipsolutions.net>
To: Baochen Qiang <quic_bqiang@quicinc.com>, Jeff Johnson
	 <quic_jjohnson@quicinc.com>, ath12k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org
Date: Mon, 03 Jun 2024 09:36:38 +0200
In-Reply-To: <af326e49-df6e-4574-9562-44b6aee10abd@quicinc.com>
References: <20240530072714.25671-1-quic_bqiang@quicinc.com>
	 <20240530072714.25671-7-quic_bqiang@quicinc.com>
	 <ccf9791b-e050-4844-8c37-35873fb3fcaf@quicinc.com>
	 <17721436-19fb-4337-9058-b20f4df2792c@quicinc.com>
	 <af326e49-df6e-4574-9562-44b6aee10abd@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-05-31 at 13:11 +0800, Baochen Qiang wrote:
>=20
> On 5/31/2024 11:42 AM, Baochen Qiang wrote:
> > > > +static void ath12k_wow_prepare_ns_offload(struct ath12k_vif *arvif=
,
> > > > +					  struct wmi_arp_ns_offload_arg *offload)
> > > > +{
> > > > +	struct inet6_dev *idev =3D arvif->idev;
> > > as noted above does it make more sense to get the netdev associated w=
ith the
> > > arvif and then use in6_dev_get(net_device) to get the inet6_dev rathe=
r than
> > > caching the pointer from the ipv6_addr_changed() callback?
> > Ah.. I didn't note that we can get inet6_dev in such a way, just though=
t the only way is to cache it in ipv6_changed() callback.
> >=20
> > will get it using the following in next version:
> > 	struct ieee80211_vif *vif =3D container_of(arvif)
> > 	struct ieee80211_sub_if_data *sub_if_data =3D container_of(vif)
> > 	struct net_dev *ndev =3D sub_if_data->dev
> > 	struct inet6_dev *idev =3D in6_dev_get(ndev)
> Just found that ieee80211_sub_if_data is internal to mac80211, so not pos=
sible to get netdev in this way.
>=20
> any other ideas on how to get netdev?

You can go via the wdev.

johannes