Received-SPF: pass (google.com: domain of linux-wireless+bounces-8424-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 3 Jun 2024 15:15:14 +0200
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-kernel@vger.kernel.org, Kalle Valo <kvalo@kernel.org>, 
	linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com
Subject: Re: [PATCH 2/6] wifi: brcmfmac: use 'time_left' variable with
 wait_event_timeout()
Message-ID: <zelrtyr4kv75cfrt2ije3ifjdmaqy25zm4sa774w7v5sa5soy2@qvufjqml47m3>
Mail-Followup-To: Wolfram Sang <wsa+renesas@sang-engineering.com>, 
	Arend van Spriel <arend.vanspriel@broadcom.com>, linux-kernel@vger.kernel.org, Kalle Valo <kvalo@kernel.org>, 
	linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com
References: <20240603091541.8367-1-wsa+renesas@sang-engineering.com>
 <20240603091541.8367-3-wsa+renesas@sang-engineering.com>
 <08985c11-3652-4699-81d9-8a6769b061da@broadcom.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <08985c11-3652-4699-81d9-8a6769b061da@broadcom.com>


> I feel this type of changes fall into the category of bike-shedding. Peop=
le

I have two motivations for this change: One may be bike-shedding, yet
"if (!timeout) return -ETIMEDOUT" looks stupid to me.

> should know how wait_event_timeout() works and then a variable name does =
not
> really matter.

And for a new developer, I am quite sure the change will help to
understand how wait_event-family() works. Especially given that
wait_event_interruptible() returns 0 if condition is true and
wait_event_interruptible_timeout() returns 0 if condition is false.

> > Fix to the proper variable type 'long' while here.
>=20
> But it may have useful side-effects to go over the code with fresh look.

:)

> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>

Thank you!