Received-SPF: pass (google.com: domain of linux-wireless+bounces-8434-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
From: Kalle Valo <kvalo@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>,  Dave Jiang
 <dave.jiang@intel.com>,  Bjorn Helgaas <bhelgaas@google.com>,
  linux-wireless@vger.kernel.org,  ath11k@lists.infradead.org,
  regressions@lists.linux.dev,  Jeff Johnson <quic_jjohnson@quicinc.com>,
  linux-kernel@vger.kernel.org,  linux-cxl@vger.kernel.org,
  linux-pci@vger.kernel.org
Subject: Re: [regression] BUG: KASAN: use-after-free in
 lockdep_register_key+0x755/0x8f0
References: <20240603165342.GA685076@bhelgaas>
Date: Mon, 03 Jun 2024 21:29:47 +0300
In-Reply-To: <20240603165342.GA685076@bhelgaas> (Bjorn Helgaas's message of
	"Mon, 3 Jun 2024 11:53:42 -0500")
Message-ID: <87wmn5ubfo.fsf@kernel.org>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain

Bjorn Helgaas <helgaas@kernel.org> writes:

> On Sat, Jun 01, 2024 at 11:39:03AM +0300, Kalle Valo wrote:
>
>> Kalle Valo <kvalo@kernel.org> writes:
>> 
>> > Dan Williams <dan.j.williams@intel.com> writes:
>> >
>> >> Kalle Valo wrote:
>> >> [..]
>> >>> >> The proposed fix for that is here:
>> >>> >>
>> >>> >> http://lore.kernel.org/r/66560aa9dbedb_195e294b0@dwillia2-mobl3.amr.corp.intel.com.notmuch
>> >>> >
>> >>> > I get "Not Found" from that link, is there a typo?
>> >>> 
>> >>> I found this fix from for-linus branch:
>> >>> 
>> >>> # PCI: Fix missing lockdep annotation for pci_cfg_access_trylock()for-linus
>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=for-linus&id=f941b9182c54a885a9d5d4cfd97af66873c98560
>> >>> 
>> >>> But at least that doesn't fix my crash.
>> >>
>> >> Sorry for the broken link I mistakenly used a message-id from an
>> >> internal thread with the intel.com reporter. However, it is moot now
>> >> because the new direction is to revert the lockdep infrastructure:
>> >>
>> >> https://lore.kernel.org/r/171711745834.1628941.5259278474013108507.stgit@dwillia2-xfh.jf.intel.com
>> >>
>> >> (that link works...)
>> >
>> > Thanks, that links works :) I did a quick test with the three patches
>> > and I didn't see any crashes anymore. But to be confident I need to run
>> > overnight tests, I'll provide my Tested-by after that.
>> 
>> Ok, I'm now quite confident that the issues I saw are solved so:
>> 
>> Tested-by: Kalle Valo <kvalo@kernel.org>
>
> Thanks for reporting the issue and testing the fix!  Can you please
> respond with your Tested-by to the actual patch(es) you tested?

Not easily as I'm not subscribed to linux-pci list and I haven't
researched how to import mbox files to my mailer :) So feel free to
ignore my Tested-by tag in this case.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches