Received-SPF: pass (google.com: domain of linux-wireless+bounces-8450-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC: Kalle Valo <kvalo@kernel.org>,
        "linux-wireless@vger.kernel.org"
	<linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 5/6] wifi: rtw89: use 'time_left' variable with wait_for_completion_timeout()
Thread-Topic: [PATCH 5/6] wifi: rtw89: use 'time_left' variable with
 wait_for_completion_timeout()
Thread-Index: AQHatZbao81hPkddpUyWjWsMJ9aM8rG2wuZA
Date: Tue, 4 Jun 2024 00:35:27 +0000
Message-ID: <1fca9d83960442b0b637d4e9586766bf@realtek.com>
References: <20240603091541.8367-1-wsa+renesas@sang-engineering.com>
 <20240603091541.8367-6-wsa+renesas@sang-engineering.com>
In-Reply-To: <20240603091541.8367-6-wsa+renesas@sang-engineering.com>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> There is a confusing pattern in the kernel to use a variable named 'timeo=
ut' to
> store the result of wait_for_completion_timeout() causing patterns like:
>=20
>         timeout =3D wait_for_completion_timeout(...)
>         if (!timeout) return -ETIMEDOUT;
>=20
> with all kinds of permutations. Use 'time_left' as a variable to make the=
 code
> self explaining.
>=20
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Acked-by: Ping-Ke Shih <pkshih@realtek.com>