Received-SPF: pass (google.com: domain of linux-wireless+bounces-8477-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Ping-Ke Shih <pkshih@realtek.com>
To: Kalle Valo <kvalo@kernel.org>
CC: Wolfram Sang <wsa+renesas@sang-engineering.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 5/6] wifi: rtw89: use 'time_left' variable with wait_for_completion_timeout()
Thread-Topic: [PATCH 5/6] wifi: rtw89: use 'time_left' variable with
 wait_for_completion_timeout()
Thread-Index: AQHatZbao81hPkddpUyWjWsMJ9aM8rG2wuZAgACAOVeAAAvlsA==
Date: Tue, 4 Jun 2024 08:57:44 +0000
Message-ID: <1483c59d26174defb6fb0886a7375ef0@realtek.com>
References: <20240603091541.8367-1-wsa+renesas@sang-engineering.com>
	<20240603091541.8367-6-wsa+renesas@sang-engineering.com>
	<1fca9d83960442b0b637d4e9586766bf@realtek.com> <878qzlt9aa.fsf@kernel.org>
In-Reply-To: <878qzlt9aa.fsf@kernel.org>
Accept-Language: en-US, zh-TW
Content-Language: zh-TW
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Kalle Valo <kvalo@kernel.org> wrote:
> Ping-Ke Shih <pkshih@realtek.com> writes:
>=20
> > Wolfram Sang <wsa+renesas@sang-engineering.com> wrote:
> >> There is a confusing pattern in the kernel to use a variable named 'ti=
meout' to
> >> store the result of wait_for_completion_timeout() causing patterns lik=
e:
> >>
> >>         timeout =3D wait_for_completion_timeout(...)
> >>         if (!timeout) return -ETIMEDOUT;
> >>
> >> with all kinds of permutations. Use 'time_left' as a variable to make =
the code
> >> self explaining.
> >>
> >> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> >
> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>=20
> BTW Ping, you can also take it directly to your tree if you want. But if =
you
> want me to take the patch, then please assign it to me on patchwork (ie.
> change 'Delegate to' to 'kvalo'). My preference is to take it to your
> tree, smaller risk of concflicts that way, but up to you.

I will take it to my tree.=20

Ping-Ke