Received-SPF: pass (google.com: domain of linux-wireless+bounces-8496-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 4 Jun 2024 14:53:58 -0400
From: Kenton Groombridge <concord@gentoo.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, 
	pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, 
	linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, 
	Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v2] wifi: mac80211: Avoid address calculations via out of
 bounds array indexing
Message-ID: <cx2oet5b5lavjywcbf7u4c32krtoglvt3xbe2sxac55e36iibw@lrd5iuhtxz2g>
Mail-Followup-To: Johannes Berg <johannes@sipsolutions.net>, 
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, 
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 
	linux-hardening@vger.kernel.org, Kees Cook <keescook@chromium.org>
References: <20240517145420.8891-1-concord@gentoo.org>
 <d1fea590e53cb1b00dc64f4f8a4c8aec84610401.camel@sipsolutions.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="u4dunbaywfh6hyso"
Content-Disposition: inline
In-Reply-To: <d1fea590e53cb1b00dc64f4f8a4c8aec84610401.camel@sipsolutions.net>


--u4dunbaywfh6hyso
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 24/05/29 04:54PM, Johannes Berg wrote:
> On Fri, 2024-05-17 at 10:54 -0400, Kenton Groombridge wrote:
> > req->n_channels must be set before req->channels[] can be used.
> >=20
>=20
> I don't know why, but this patch breaks a number of hwsim test cases.
>=20
> https://w1.fi/cgit/hostap/tree/tests/hwsim/
>=20
> johannes

Pardon my absence.

I'm also not sure why these tests are failing. Unless I'm missing
something, the runtime behavior of these code paths shouldn't have
changed significantly.

FWIW, I have been running this patch on real hardware and connecting to
Wi-Fi networks with it for the past couple weeks without problems.
Though, I see that these tests are probably testing Wi-Fi modes that I
am not using.

--=20
Kenton Groombridge
Gentoo Linux Developer, SELinux Project

--u4dunbaywfh6hyso
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEP+u3AkfbrORB/inCFt7v5V9Ft54FAmZfYsNfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNG
RUJCNzAyNDdEQkFDRTQ0MUZFMjlDMjE2REVFRkU1NUY0NUI3OUUACgkQFt7v5V9F
t54qNw//YhiRFppe9p3LZ2rWSH2ANit9/KoWnRDidGoCAiVwfzWshSxXBhSt51pg
HFF6TbdPnpbRE80APNY/PHmbDm0U+kRq8+6B/OCHcop2Yl3DktBc3Yn4uhUCosl7
r9lwUAOtUB4npMM1r+FeXkHxWgW8cZRn8T50DlpVeQN+23f0g5uzIbrZqYKCFucb
mmxVXrSpkB4qgSGOUiMpsGBk73yyrsGSujH1df5eaclp4uvebGys7lhApdRmJg0u
A0T42vwe7Uf+snt35W6BdAD+jiY/2WnEUCPnesPbde3maYYnCPZyzPUtPshScHk0
WJA2LtDk9bSAE/OTwV2GfHdvensMp+ck7CEac1Ub1/INtZU+DJTv4Pa8wFGyUOvt
edcXsvu4IOYx6ZtGc26z+IqnbLH2XNwNN3LvsabV3fUOtKLfQ7P47cg0C12AcEMZ
MX8Qdy0yhZnYfdlaSNDUlKgiy7V0v0j8xc0lqXrlmy1b3R2Nor72SolyKUSmd8+a
+BC3FvzE5H6U7alhW5QpbdZvBaPUThwxDa/8IaIMNjHrh+BWaTEJ9dv7VAerGB6H
OONq7eX4lsut95clnch6wf3CSYAgkDZFqKh0oLKv+vh+GxkgPNMp9Rt6UOUkcR7T
9DIDzMVcV/ZNopIHznAP8rLKNf9DEOZ7mdJiW8n0anc7leMoTBo=
=Do6D
-----END PGP SIGNATURE-----

--u4dunbaywfh6hyso--