Received-SPF: pass (google.com: domain of linux-wireless+bounces-8577-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <00555ae56b4193f47d32550440829d1c542534f6.camel@sipsolutions.net>
Subject: Re: [RESEND PATCH v2] iwlwifi: mvm: adding check if the thermal
 firmware is running
From: Johannes Berg <johannes@sipsolutions.net>
To: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>, 
 miriam.rachel.korenblit@intel.com, kvalo@kernel.org,
 rafael.j.wysocki@intel.com,  daniel.lezcano@linaro.org, dmantipov@yandex.ru
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Wed, 05 Jun 2024 20:39:39 +0200
In-Reply-To: <20240605183710.66016-1-trintaeoitogc@gmail.com>
References: <20240605183710.66016-1-trintaeoitogc@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-06-05 at 15:37 -0300, Guilherme Giacomo Simoes wrote:
> In the dmesg is showing the message "failed to read out thermal zone"
> as if the temperature read is failed by don't find the thermal zone.
>=20
> After researching and debugging, I see that this specific error is
> occurrenced because the thermal try read the temperature when is started,
> but the firmware is not running yet.
>=20
> For more legibiliti i change the tt.c for return EAGAIN when this was occ=
urrence.
> After this change, in my computer I compile and install kernel in /boot
> and in my dmesg the message "failed to read out thermal zone" is not show
> any more.
>=20
> I would like to thanks for Rafael Wysocki <refael.j.wysocki@intel.com> an=
d
> Kalle Valo <kvalo@kernel.org> for your suggestions in my first patch.
>=20
> Signed-off-by: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wi=
reless/intel/iwlwifi/mvm/tt.c
> index 8083c4b2ab6b..68ab9966330c 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> @@ -620,8 +620,14 @@ static int iwl_mvm_tzone_get_temp(struct thermal_zon=
e_device *device,
> =20
>  	mutex_lock(&mvm->mutex);
> =20
> -	if (!iwl_mvm_firmware_running(mvm) ||
> -	    mvm->fwrt.cur_fw_img !=3D IWL_UCODE_REGULAR) {
> +	const int res =3D iwl_mvm_firmware_running(mvm);

const is useless, but you should not have variable declarations in the
middle of the function (per kernel convention)

johannes