Received-SPF: pass (google.com: domain of linux-wireless+bounces-8719-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Sat, 8 Jun 2024 09:59:17 +0100
From: Simon Horman <horms@kernel.org>
To: Breno Leitao <leitao@debian.org>
Cc: kvalo@kernel.org, linux-wireless@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	sbhatta@marvell.com,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH wifi-next 2/2] wifi: mac80211: Remove generic
 .ndo_get_stats64
Message-ID: <20240608085917.GL27689@kernel.org>
References: <20240607102045.235071-1-leitao@debian.org>
 <20240607102045.235071-2-leitao@debian.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240607102045.235071-2-leitao@debian.org>

On Fri, Jun 07, 2024 at 03:20:44AM -0700, Breno Leitao wrote:
> Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
> configured") moved the callback to dev_get_tstats64() to net core, so,
> unless the driver is doing some custom stats collection, it does not
> need to set .ndo_get_stats64.
> 
> Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
> doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
> function pointer.
> 
> In this driver specifically, .ndo_get_stats64 basically points to
> dev_fetch_sw_netstats(). Now it will point to dev_get_tstats64(), which
> calls netdev_stats_to_stats64() and dev_fetch_sw_netstats().
> netdev_stats_to_stats64() seems irrelevant for this driver.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Simon Horman <horms@kernel.org>