Received-SPF: pass (google.com: domain of linux-wireless+bounces-8791-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <3fbb5317d9ff33ef1b60ca8297537335ce86a79d.camel@sipsolutions.net>
Subject: Re: iwlwifi: Regression after migrating to 6.6.32
From: Johannes Berg <johannes@sipsolutions.net>
To: Fabio Estevam <festevam@gmail.com>, miriam.rachel.korenblit@intel.com, 
	kvalo@kernel.org
Cc: Jakub Kicinski <kuba@kernel.org>, linux-wireless
 <linux-wireless@vger.kernel.org>, linux-kernel
 <linux-kernel@vger.kernel.org>
Date: Tue, 11 Jun 2024 14:52:56 +0200
In-Reply-To: <CAOMZO5A7+nxACoBPY0k8cOpVQByZtEV_N1489MK5wETHF_RXWA@mail.gmail.com>
References: 
	<CAOMZO5A7+nxACoBPY0k8cOpVQByZtEV_N1489MK5wETHF_RXWA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-06-11 at 08:46 -0300, Fabio Estevam wrote:
>=20
> [    6.995391] ------------[ cut here ]------------
> [    7.373564] WARNING: CPU: 3 PID: 136 at
> /drivers/net/wireless/intel/iwlwifi/pcie/rx.c:269
> iwl_pcie_rxmq_restock+0x158/0x178 [iwlwifi]
>=20

This warning happens if DMA mapping/allocation returns a page that's not
page-aligned??

                rxb->page_dma =3D
                        dma_map_page(trans->dev, page, rxb->offset,
                                     trans_pcie->rx_buf_bytes,
                                     DMA_FROM_DEVICE);

(or similar places), where rxb->offset will always be 0 unless
rx_buf_bytes is set to 2048, but that can only happen if the amsdu_size
module parameter is set to 4 (=3D2k) but that's not even supported any
more?

Maybe make this WARN_ONCE(...) with a string that has more info on the
addresses.

johannes