Received: by 2002:ab2:69cc:0:b0:1fd:c486:4f03 with SMTP id n12csp544251lqp; Tue, 11 Jun 2024 11:45:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWgkEMikzl2mtgKWs5xN/Qkay7npSY4Xryl0mAZNMWTlL0bdKMW/1pCYe2Gp0Kz1f+sLWwGYQ5vYJJKxJX5NFhnxSsy2TU0sjBwg3Ti9A== X-Google-Smtp-Source: AGHT+IGuSfhSqXAToZEps3a4+MyUEeZQwS0E1+bAc0Hf5XTY9wpawY7BMuqXt3l5oYkVVgLzznB5 X-Received: by 2002:a05:6870:9721:b0:254:948e:bf08 with SMTP id 586e51a60fabf-254948ec101mr10078538fac.31.1718131535886; Tue, 11 Jun 2024 11:45:35 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718131535; cv=pass; d=google.com; s=arc-20160816; b=iaE/dFRjtbJMrjiPd67/gvJSnZBKoyBbPhn9vKT9kHz6iWJUJFvNoHZ1Vn+9GM8wUC DwRlsEeO3wmd3HL0/uFv6XjW57ckhxkesu/f6yogUPZiybW+TEai72cigGoXdhCv6AGw oE9rXIcXlDYsxrAdKN1sm4Vlhv8ugYTBz3P+OxGq83j5IpHltQTHOLqmGoT0EqMTPu4H PhJFNvXdSywTSwDDEoEygwBeSOea64RwTSKqJIripwfbScEuxvI605gD4mi51/OyHLML Q3flyP9+7At/cBXfB7XfWm1CVSbyM4aigAo76e0Aw1XNaNuYEi+t/FzKpy8vbNcCxASx IpIg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=date:message-id:user-agent:cc:to:references:in-reply-to:from :subject:content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:dkim-signature; bh=egxilELPCmP/W4KhrWj5PVa92XuPUKSqDx/SxrW4fvw=; fh=xS3MFtb588Oi5FG/nJUmUhHCAm7CYoNVr6cBc+ppuSE=; b=Pk1OWWjb0eUdgNEFGZInFXn5dq1heEFQCl5IcxY4f2DvY1faW3mIC4KUg6/TXRPAc/ YUIdyUxwyzx3cl+sEDX53qStzTP/dkcoVsYAIVEGSNsY5+oit4dLUyQuOkjh2ahJq1kK /tbMmqfRijpQSW02nMIlbvN7QfMIXs/XCuuuObThcaTn96sscq8To7J+bF/POBYFphAR H+Lt5j9ATFatKRCOiILh28TAEZKvWWNXFKQ10gv8rQQBBXADs4xTtCmM319H1M3Ekq5u t8F4RagsqXaZ6YifHD+SFr3SjNbFilqi2df2e+CM1rFul047ev8BjtamDwWesyQzhWma FF9A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BBhojCS5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8812-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8812-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-44038b66808si128480021cf.635.2024.06.11.11.45.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 11:45:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8812-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BBhojCS5; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8812-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8812-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id E7FC31C25395 for ; Tue, 11 Jun 2024 18:45:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id EA6DF5820E; Tue, 11 Jun 2024 18:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BBhojCS5" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C68456DD08 for ; Tue, 11 Jun 2024 18:45:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718131512; cv=none; b=Pbt4nBimDnBIsdeUklnP1BHf0YKKLt2pw4Fa/g2vPa/0ERg2waN/ZZ/dnL8Fu5u/jof2Jh4aQ2V0zHUSNdKpwQ8I73ze/Ibt6hX5gBnjsrCItzXvhU/LIWSfaQDcMo2Wn5cwSO6bQkonfzk7Am+EEXR7nL7ZsHSuQK12AjP5gAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718131512; c=relaxed/simple; bh=LB+xYWiQgFmIvjz06NaeaI39lPvfaqivVpjZ+4IalEo=; h=Content-Type:MIME-Version:Subject:From:In-Reply-To:References:To: Cc:Message-ID:Date; b=MZgGocBLSn3Gw/cskMV3AZGuJDr/Cw94T8Ds+q28afKsecATQYoLAI5KHJOPK+cElSWIh8l6+zBS3o19i/7mB61YgjKWlM3EzBMDXhYVg8eb1H0ZsedL/cxK4Sjb4YnxIf+ApHvYRK2QMkrvqM6XsJ89ZnC6e3Xe0MD4VnLYJaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BBhojCS5; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C575C2BD10; Tue, 11 Jun 2024 18:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718131512; bh=LB+xYWiQgFmIvjz06NaeaI39lPvfaqivVpjZ+4IalEo=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=BBhojCS5D61lD363LS9h3qLSju+haMi6m0YyMKxom16DzSY5mcrLaYaLL3rTqBeF/ yyRfJN4mjMfvxjrwYhExUELea0lRKDcroBufcqgbZS42VHU+ZpnPUCiaXqpCpEV9ZM +6IBjxTyZ7vT2xZgtQKv2eZ4uGolj50DO0r//pufW2npVrO3ZdEax3+bnl16VxBbPJ z9Mnr1VEEOXiQtrPI5FZdGYAYOQiAQzlkiS4TNJ1SkKUagEBwFjiqpUwlwn62ZKkDv UyBIZMIc1CbPZtjCXBGMpR2disJTOitw6DecMsUdX1n2AEsQnntUR3jhWrNQUz1ZjY Jn6JioJXvpzIg== Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH 1/3] wifi: ath12k: fix per pdev debugfs registration From: Kalle Valo In-Reply-To: <20240529043043.2488031-2-quic_adisi@quicinc.com> References: <20240529043043.2488031-2-quic_adisi@quicinc.com> To: Aditya Kumar Singh Cc: , , Aditya Kumar Singh User-Agent: pwcli/0.1.1-git (https://github.com/kvalo/pwcli/) Python/3.11.2 Message-ID: <171813150979.3564613.3522946420612603449.kvalo@kernel.org> Date: Tue, 11 Jun 2024 18:45:11 +0000 (UTC) Aditya Kumar Singh wrote: > Function ath12k_debugfs_register() is called once inside the function > ath12k_mac_hw_register(). However, with single wiphy model, there could > be multiple pdevs registered under single hardware. Hence, need to register > debugfs for each one of them. > > Move the caller inside the loop which iterates over all underlying pdevs. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Fixes: f8bde02a26b9 ("wifi: ath12k: initial debugfs support") > Signed-off-by: Aditya Kumar Singh > Acked-by: Jeff Johnson > Signed-off-by: Kalle Valo 3 patches applied to ath-next branch of ath.git, thanks. 8dd65ccbdf91 wifi: ath12k: fix per pdev debugfs registration 4e1eff38d37a wifi: ath12k: unregister per pdev debugfs 5a16da9cfb40 wifi: ath12k: handle symlink cleanup for per pdev debugfs dentry -- https://patchwork.kernel.org/project/linux-wireless/patch/20240529043043.2488031-2-quic_adisi@quicinc.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches