Received-SPF: pass (google.com: domain of linux-wireless+bounces-8832-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <6a88e0d3e47ebbd1f0f383094e4804a627c41870.camel@sipsolutions.net>
Subject: Re: [REGRESSION][BISECTED] wifi: RTL8821CE does not work in monitor
 mode
From: Johannes Berg <johannes@sipsolutions.net>
To: Ping-Ke Shih <pkshih@realtek.com>, Thorsten Leemhuis
	 <regressions@leemhuis.info>, Savyasaachi Vanga <savyasaachiv@gmail.com>, 
 Christian Heusel <christian@heusel.eu>
Cc: Kalle Valo <kvalo@kernel.org>, "linux-wireless@vger.kernel.org"
	 <linux-wireless@vger.kernel.org>, "regressions@lists.linux.dev"
	 <regressions@lists.linux.dev>
Date: Wed, 12 Jun 2024 09:07:00 +0200
In-Reply-To: <5318640d6eb74301b1fbf6d9385ba69e@realtek.com>
References: 
	<chwoymvpzwtbmzryrlitpwmta5j6mtndocxsyqvdyikqu63lon@gfds653hkknl>
	 <a51f223f-18ac-4d67-9120-8da1c169b7eb@leemhuis.info>
	 <809d2332-625e-4a46-a77e-ca2e49b0d651@leemhuis.info>
	 <0e65ca6b471b4186a370b9a57de11abe@realtek.com>
	 <36c1f49acfcc2cc16c7e54ffeb76f1e93cb96e91.camel@sipsolutions.net>
	 <5318640d6eb74301b1fbf6d9385ba69e@realtek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-06-12 at 00:56 +0000, Ping-Ke Shih wrote:


> > Just got pinged (sp?) about this, can you share the driver fix so I can
> > take a look what the issue is about?
> >=20
>=20
> Please reference patch below. I copy this idea from rtw89 [1], which the =
main
> stuff is to add WANT_MONITOR_VIF and case NL80211_IFTYPE_MONITOR in add_i=
nterface().=20

Ah, OK, but that gives me a hint. Yes, I see the issue now.

OK it's not trivial and it might leave ath12k still not working (though
not sure it ever did before? or maybe I'm missing something...), but I
think I can fix this. Let's see.

johannes