Received-SPF: pass (google.com: domain of linux-wireless+bounces-8850-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <42e6c6ec01df0de6c1bf8b7610758d0f1ef8ae7c.camel@sipsolutions.net>
Subject: Re: [PATCH v1 1/2] net: rfkill: Fix a wrongly handling error case
From: Johannes Berg <johannes@sipsolutions.net>
To: quic_zijuhu <quic_zijuhu@quicinc.com>, davem@davemloft.net, 
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, 
	emmanuel.grumbach@intel.com
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Date: Wed, 12 Jun 2024 12:14:38 +0200
In-Reply-To: <9ab68c04-b33f-4f76-a563-2bc9d6c01401@quicinc.com>
References: <1717771212-30723-1-git-send-email-quic_zijuhu@quicinc.com>
	 <1717771212-30723-2-git-send-email-quic_zijuhu@quicinc.com>
	 <5d901b213389c38eb5bd1df37cb8a1c3d82ebba5.camel@sipsolutions.net>
	 <9ab68c04-b33f-4f76-a563-2bc9d6c01401@quicinc.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-06-12 at 18:12 +0800, quic_zijuhu wrote:
> On 6/12/2024 4:15 PM, Johannes Berg wrote:
> > >=20
> > > use pr_err() instead of WARN()
> > > for this error case handling.
> >=20
> > I don't see anything wrong with the WARN here, it's the user/driver
> > calling it completely incorrectly.
> >=20
> the function is a kernel API

Sure.

> and it is handing invalid user input.

No.

johannes