Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp342482lqp; Wed, 12 Jun 2024 03:18:36 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWE1oAL0dXSZmgspYZqPy7YNy+7py0HymbXu90+v9+AuGSgDNz0GOfHgZB85p3oKfRa+WxZdGZdtd2+jWn8PVKpW37fl123MyjWOG8j5g== X-Google-Smtp-Source: AGHT+IENrwtdEttMPsmxPub+LtDr5nIqFhNjkiq8DI7poGUoGc6o7jvWvR/yCFWvkfxusN9WXA5y X-Received: by 2002:ac8:5795:0:b0:440:89a6:104c with SMTP id d75a77b69052e-4415ac068f0mr10052741cf.40.1718187516202; Wed, 12 Jun 2024 03:18:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718187516; cv=pass; d=google.com; s=arc-20160816; b=e8Wpz4008CZsaaSWiLt2dCOdBGF33YhrAzzhKDNmqC4aWBUJCQDIbg0sq8vICHiXGr YUVZWzhfsaOqlSFZRc323wL69IbsXSnBsGLDVLZSQgu3uTL78iudBeOnwSRv2pE1HmsW 3pW7zPWeqLkvqXG9jifNDAS4Wyoo01d9+GtDOB3kL7ftpeyYkP7igYCLds34NONRF3IC iig0VV8zOuBMf301iJmG1lyC44Pa4g4GcCUUHTLXhUqhuvtXFP2vfLfghaAGR7ePpWWq UOh33e9G6+wPKfM05HnshAjqbr91t96RSFsVHQq/9mgfPuzmjnPRSbqmzuYN8LmMgQCu ekQw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:references:in-reply-to:date:cc :to:from:subject:message-id:dkim-signature; bh=QoKr8XZXzNuef2wlPvrF3LDsADwFdLosggnu1NKj0nY=; fh=TgNRlKFLBLtq+uoOf409PYAgGvKQePnEo/f6eS7eOjY=; b=fv+WWIqxeFmSAclRI+yr6/+dx2k+d16tDhnXZDXDZJv3WEStMPveaiLqF2pNjuAUPh sgPioA0/G7P624vGiDpuGXH4k3jV8ntAJbWyrImh8ZpTnR6vPXpWWYCSzabLC5FGddII Gc9Z994PnC8PVtFT/NWCAvmw4NjUazqbh9kk3GK4eMxEYd3uCkpqUgm7P8YwIHKWCeWx 9LRCa5uJ9KMD5JrToy2f/gKKXK60oIY0Ow/fRAQP3mfdVyGRjbr1ODYAGjStTczCRmly UbiNl4pNtN+SEIA3tORLW26wXOAfMsc0rlB3mUxORD0rtwlxN5yCggxQr2p0U1Ae3mIZ OiEA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=S6lf2Rer; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-8851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8851-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d75a77b69052e-440521b932fsi111382111cf.700.2024.06.12.03.18.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 03:18:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@sipsolutions.net header.s=mail header.b=S6lf2Rer; arc=pass (i=1 spf=pass spfdomain=sipsolutions.net dkim=pass dkdomain=sipsolutions.net dmarc=pass fromdomain=sipsolutions.net); spf=pass (google.com: domain of linux-wireless+bounces-8851-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8851-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=REJECT dis=NONE) header.from=sipsolutions.net Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9C30D1C208CC for ; Wed, 12 Jun 2024 10:18:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 63E8315250F; Wed, 12 Jun 2024 10:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b="S6lf2Rer" X-Original-To: linux-wireless@vger.kernel.org Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06A27145FE9; Wed, 12 Jun 2024 10:18:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=168.119.38.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718187500; cv=none; b=NYoFEzw8t7B5yWYpEUAQcT8bK/1ZBsDywR3n/3CKi5tdakRnpS6uHk0fQ130ekSHq5toQHCuM0LdVljoD+mcU7OH3MA6QsVpZld864ZzH/SqBkvuovp8Ytwb15GxYGJl4f6luW5o1JmKhBhgpg13yqXZKWcwpubNXfelI64ZRpc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718187500; c=relaxed/simple; bh=QoKr8XZXzNuef2wlPvrF3LDsADwFdLosggnu1NKj0nY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=FjXo4EnoT9sLsdvrEzQvoljbBX7ZKL0oQhgqYZfUDBp0rNFGLqjD02UtQCw1/5l137zGbr3WFrQPCZ5oL9aX0SD3ZufSoU9RDgw0t1OZxei0oXJ72cyS34FPfsdaYRalGXI+VMlKGZKoqSOzzxYevpRDilLvBuU65Px+5zyyZ+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net; spf=pass smtp.mailfrom=sipsolutions.net; dkim=pass (2048-bit key) header.d=sipsolutions.net header.i=@sipsolutions.net header.b=S6lf2Rer; arc=none smtp.client-ip=168.119.38.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sipsolutions.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=QoKr8XZXzNuef2wlPvrF3LDsADwFdLosggnu1NKj0nY=; t=1718187499; x=1719397099; b=S6lf2Rerhr57B3E4SyWP9OsbuVjPmt06eL6ecTfhRcAQx8n 8ZMsuwtvZ/caoF5hGpINVZpvb1aXlTDR+bX8ljPsPmPWWXo+GkhVTQEkRToG8KqVS0v/qT+r0YB3w kkHU5drRrunxP3apGJ24KIC4zzJwdf+uWRPHVN4uY1RpcTF3f2d0D72y2aTtAnZkeGJTDjIo09Wc6 WdZI+Dk+BFeTiwD2P5jCcTnShOQrEYG5Z9on7Sx8ZGYGzBcZQ1SzAF3Xpl18XZz+46nQ0ODXGqdcu pi1rXfYlfOWc83M9Oc6gbBnWg1nubtzKVSVNdhYn4jot2yyTero87mPKI8/4txCQ==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.97) (envelope-from ) id 1sHL3U-0000000A9cB-2LVP; Wed, 12 Jun 2024 12:18:12 +0200 Message-ID: Subject: Re: [PATCH v1 2/2] net: rfkill: Fix a logic error within rfkill_set_hw_state_reason() From: Johannes Berg To: Zijun Hu , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, emmanuel.grumbach@intel.com Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org Date: Wed, 12 Jun 2024 12:18:11 +0200 In-Reply-To: <1717771212-30723-3-git-send-email-quic_zijuhu@quicinc.com> References: <1717771212-30723-1-git-send-email-quic_zijuhu@quicinc.com> <1717771212-30723-3-git-send-email-quic_zijuhu@quicinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-malware-bazaar: not-scanned On Fri, 2024-06-07 at 22:40 +0800, Zijun Hu wrote: > Kernel API rfkill_set_hw_state_reason() wrongly gets previous block state > by using its parameter @reason as reason mask. >=20 > Fixed by using @reason_mask as reason mask. >=20 Actually, this *introduces* a bug. I'll leave it to you to figure out what that is, I'm not convinced that you're actually doing *anything* useful here. johannes