Received-SPF: pass (google.com: domain of linux-wireless+bounces-8857-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <fa7c2aeef854f89eeb03a01a21a8d511417c92b6.camel@sipsolutions.net>
Subject: Re: [RFC v3 6/8] wifi: mac80211: extend ifcomb check functions for
 multi-radio
From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@nbd.name>, Karthikeyan Periyasamy
	 <quic_periyasa@quicinc.com>, linux-wireless@vger.kernel.org
Cc: quic_adisi@quicinc.com, ath12k@lists.infradead.org
Date: Wed, 12 Jun 2024 14:05:43 +0200
In-Reply-To: <096940e3-713a-4533-ab0f-e82bd647e205@nbd.name>
References: 
	<cover.386a66ec6a89750d4890f63f0d28582a52b838b5.1717696995.git-series.nbd@nbd.name>
	 <bc603fc671010bb720e75881ef0e22d81ec6e2eb.1717696995.git-series.nbd@nbd.name>
	 <a337de2e-fe3e-18ed-b55b-9ea2cd21baed@quicinc.com>
	 <1f32cb6c-6be8-4e3d-8e8f-2d3c728875a9@nbd.name>
	 <479752f5-221d-746b-7513-ba27ef547ac1@quicinc.com>
	 <096940e3-713a-4533-ab0f-e82bd647e205@nbd.name>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Fri, 2024-06-07 at 13:04 +0200, Felix Fietkau wrote:
> > >=20
> > > Use the sum of the number of interfaces from each radio instead of th=
e=20
> > > maximum.
> >=20
> > Oh, then legacy user have misconception of the global interfaces
> > advertised and try to fail for the allowed limits.
>=20
> Sure, but that might be an issue either way until user space is updated=
=20
> and users start looking at the per-radio ifcomb data.

I'm kind of with Karthikeyan here - this could be understood as a
regression, since you're now telling userspace something you can't
actually do.

> The global data is simply not enough to describe the details of the=20
> radio split.

Obviously, but that doesn't mean the global data as advertised in the
existing attributes must be *wrong*. It could be a subset, and the
superset data is only available to new implementations.

johannes