Received-SPF: pass (google.com: domain of linux-wireless+bounces-8884-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 12 Jun 2024 15:31:56 +0200
From: Christian Heusel <christian@heusel.eu>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ping-Ke Shih <pkshih@realtek.com>, 
	Thorsten Leemhuis <regressions@leemhuis.info>, Savyasaachi Vanga <savyasaachiv@gmail.com>, 
	Kalle Valo <kvalo@kernel.org>, 
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "regressions@lists.linux.dev" <regressions@lists.linux.dev>
Subject: Re: [REGRESSION][BISECTED] wifi: RTL8821CE does not work in monitor
 mode
Message-ID: <3a6b3ea1-986f-4066-8408-cdb56e095d41@heusel.eu>
References: <chwoymvpzwtbmzryrlitpwmta5j6mtndocxsyqvdyikqu63lon@gfds653hkknl>
 <a51f223f-18ac-4d67-9120-8da1c169b7eb@leemhuis.info>
 <809d2332-625e-4a46-a77e-ca2e49b0d651@leemhuis.info>
 <0e65ca6b471b4186a370b9a57de11abe@realtek.com>
 <36c1f49acfcc2cc16c7e54ffeb76f1e93cb96e91.camel@sipsolutions.net>
 <5318640d6eb74301b1fbf6d9385ba69e@realtek.com>
 <6a88e0d3e47ebbd1f0f383094e4804a627c41870.camel@sipsolutions.net>
 <7869b9b29b6796c95fd5af649e4bd6696e56dcaf.camel@sipsolutions.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="2e2w45cfz5ro3syf"
Content-Disposition: inline
In-Reply-To: <7869b9b29b6796c95fd5af649e4bd6696e56dcaf.camel@sipsolutions.net>
UI-OutboundReport: notjunk:1;M01:P0:CyJIKlqnMh8=;5fUCl+DeNHJnKEsBPEdqjAi9g9B
 +7XosA2TnxJpvl4GK9bmEnuF9bZMl0GoD5wiKRHBsId2Klgdn61iTFHwSsTQaKq3JM4TIPD0/
 sUC+azNgeKNtFdLJJVjDIWvjBNjY3Dx2xRxE5/pX58QcoRUtBd7r84O0nNhTes78Q7MLtZpry
 sNEhN8Gj9LiC6qRICLzGB3bH3f0vgRrNeHpJJD0QYp35dufbzAD3A7dseVGSpn5ilOuRSClMC
 cS64KHtCbFUEg0w0dFKxUk5Xh0/29QIUqyR4q8fOOjhLKsQW4YIn++Sm4xNAC/vXBgz58iOWP
 MQsUNtTPG9LIX9sjJe/HN6hG4RnQseVznKPecveBozC8xjrvQ41fxRBzzbB9xGzazwqI8+p9J
 ImJFWAVAnw5cj8cIyXn8sl249G5MpptvdePFrRwnZLXVVr9HQp12qxbrIkCD0yzZn07XYAJmU
 dfIirG6hehFHAau+XsOk6eurZ9REzwhllJq63IuQDc8iHrqJeHzL5ozpiuJgpwzZ6EG/Qpqkj
 AaWX1iz6Dc4cFZ87kWm+NpbXAZXmXkG96NFLiCZQMvoaojV8yjQ9bXeMVNCbukNo4AWEzZQUx
 V/oVfTvBRvONdMvz6TPG2iYmIUKOanQwFKrbuVlAOiUTjy0b9WNnrTrmehyr3SoC84U9+STHD
 C6tUo52KSTN0A8AX+LOGdkhDrud4RzxtSlLGTF6be0P7aIwEb1RQQCwmpO+TgCaScA2Xwd7lW
 HST1x4MFXQC6k1ZyInKHhp+KhnSNGCNWH1aBgu2EkG9nF1snU1U4MY=


--2e2w45cfz5ro3syf
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 24/06/12 09:58AM, Johannes Berg wrote:
> On Wed, 2024-06-12 at 09:07 +0200, Johannes Berg wrote:
> > On Wed, 2024-06-12 at 00:56 +0000, Ping-Ke Shih wrote:
> >=20
> >=20
> > > > Just got pinged (sp?) about this, can you share the driver fix so I=
 can
> > > > take a look what the issue is about?
> > > >=20
> > >=20
> > > Please reference patch below. I copy this idea from rtw89 [1], which =
the main
> > > stuff is to add WANT_MONITOR_VIF and case NL80211_IFTYPE_MONITOR in a=
dd_interface().=20
> >=20
> > Ah, OK, but that gives me a hint. Yes, I see the issue now.
> >=20
> > OK it's not trivial and it might leave ath12k still not working (though
> > not sure it ever did before? or maybe I'm missing something...), but I
> > think I can fix this. Let's see.
> >=20
>=20
> I don't have any of the affected hardware, could someone test this?
>=20
> https://p.sipsolutions.net/619a4ce4a197b2b4.txt
>=20

This also [fixes][2] the issue for the initial reporter on our
bugtracker:

Tested-by: Savyasaachi Vanga <savyasaachiv@gmail.com>

The test was done using 6.10-rc3 as base + the proposed patch from the
previous email.

Cheers,
chris

[2]: https://gitlab.archlinux.org/archlinux/packaging/packages/linux/-/issu=
es/54#note_191037

--2e2w45cfz5ro3syf
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb3ea3iR6a4oPcswTwEfU8yi1JYUFAmZpo0wACgkQwEfU8yi1
JYX5IQ//RU63RMmDQkSoJE8Gdx2X6OvhNwE4VhP9HtMfwm0KuVbiqZEYaDNPiaMv
THAJBPeXCoccjHe5a5anejye1ofgOOn9KdOMF2iin/s1045xGLSELzY1RMVtb9Dx
JT1Et0zY+LdwODfjF4FWB9wc36DeDCr+2uxDRh2mp+8PBFFD8S5ND+kA/F5ysh1L
OBeOCQK1kLE4xrzqQ4NsP/9D9vnb/Ufs1XeBFy9/XXiVCuCtQMeLg4+GilF6xpp+
zkgO3n8iXVKW2XwZJkNtghv9+ak8ZJN4BbYrKlxnuV29dE4uTm4zQwVYzDDepdd7
Fe6K7Wx6/jiOTuY6MX+tHTECDhNF9+dqN6MyTMQTzE+QU8yEO5+xsr9yxJlkCgbe
WXF7JcqNidoDmrtBnUMdJxadWqlNLwdLd3jyT7lGis8X/FwvWmHY9c4m23n82v6T
XWagElaR1uxLEYM+fGembET6Pd9i3qIbCbD3fEcJ4IH+c7DZHWEgzVEaOOdcyNxa
XHgRpRshk81QhVBG/qKLKOpr0cZbbPodWygm71HcrUA22i9Ga8rmKH6ufzi3osON
jB4Qpd8MOHJ4UjjM+7UFVnb8X9ei+pxCKC23Sdj/UnZXIBmpgzu2DKXGotmma3rC
TzK5q1VpY2LX0/UGawmbtRCwA2Yj4eZsUxZH+++nEM1emquWQ0U=
=iVDo
-----END PGP SIGNATURE-----

--2e2w45cfz5ro3syf--