Received: by 2002:ab2:6c55:0:b0:1fd:c486:4f03 with SMTP id v21csp637469lqp; Wed, 12 Jun 2024 11:28:39 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW+2TGnbYKhNnukOwRf91D3a7fWYi7p1Jvt606HqOSmC+y1oIjzf5NYj4b5ifC5qVpdRmdgm6EPJJ0xIdAOHULp5sAZSYiBuaHfg2IG+g== X-Google-Smtp-Source: AGHT+IGrKhrliPZrFrHaOasE6s03gjyMf+ueto9Oom1pwSAOkUju0lB3Ghey3uGtci1ho7+LHYS8 X-Received: by 2002:a05:6358:54a2:b0:19f:6172:54ce with SMTP id e5c5f4694b2df-19f69d542cemr329301755d.17.1718216919455; Wed, 12 Jun 2024 11:28:39 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718216919; cv=pass; d=google.com; s=arc-20160816; b=jznsxFwM5Mrhl2b2EVSHnPAdcJTa+bkY5q/WyyXgANbzqlZrNuP/ioHdd5D2Aeuhsg d+iBHJHH7DPqwzEgPFCjzX5j/J+8IV77IMBjspBw7ejwYpGfA06Kagtp6zSlllPf+B/y MfNmdNJn6oODjsKYrUaNC0J1JoQmumKpEc3lrqPb4ieXRolyaxQSnwTGJYQqHvrNidYZ 5mcEPICiUj3kLoqB4BcJjdZowT+Z9QjSPvUU5ILfQPcple5RFNjZocL5U9off01o9bRY 2sZ2Bw4KW7sAsV8LdHV3bnz4NgFRLD2DMkleIjZz4OY6bN9AurSs6/Vg99lmd07W0dSQ CKDw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XYlWybt6ZFATWCTQLN/85nbpyFBL6X8LoYCRiBwx+Pk=; fh=TOLgH00/kO57WeYRo4Vm0vY3gC04+u5uVBju9yjuIGU=; b=rSOMwDeFcHu/zl2Fh9Np/T6GM79BhA7A77rSGRx/4uwXhhESMX0yVlW7GJ0ISBUOj0 rR/yAVwpFsixtqVmm/5e+nfMD9+EfoOhfVbUov1WHCux6xuCMrHAhUfCUGzo70Eg4spx Bft/RE7hPtU6wIRMeuKSJAWpDpnIB9l9BZHVXB9RizmjYF+OGY0y1NRS74CCgd9w/NUM EXWnRc086GJ4uqqcE0q8DYTSULrxmIw0lrBPWDfKGbzEMVLNVpvQro3KYPgXgvtphCtJ 3B54WAxmsBDFV71vG6CMoNEuf0UHnJqaBJFPbWJrRsnzVQ6YZ3EobqX4L/Xuii3cKWXi TCKw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ddpy3LFX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8891-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8891-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-6e52bd4133dsi9118859a12.485.2024.06.12.11.28.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 11:28:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-wireless+bounces-8891-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ddpy3LFX; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-wireless+bounces-8891-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-wireless+bounces-8891-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D6D9F2835FF for ; Wed, 12 Jun 2024 18:28:38 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2310F40867; Wed, 12 Jun 2024 18:28:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ddpy3LFX" X-Original-To: linux-wireless@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7DCF3FE2A; Wed, 12 Jun 2024 18:28:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718216915; cv=none; b=ewaREUR7EFS7AaqVNAr+Dx3HJfMfcdoma53Rj479OlcocDfnWWpd0LzL1QfbRzC8U0qcconbuXA6HZMHW04cruOu9Zp9my7kUdR97Gn+XUIKLKjbm7Cw3jFyiKgXcgRJ64dwwy1Y1fK/l+o9TChxnVGyJ9/FdhrfShhxREWZiGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718216915; c=relaxed/simple; bh=NJeqqnsIfUMhlSi06vIIKPHNE2ykrkcvFQ48tdRGhsA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=fq4iZ7hCt99U5OfAl4lLxoSCTS9LnIFIZItFEYCZ0Q5Ypv2Ae+JESr7AB34S7J0xof3bu/cBRRd2fcOl3P6ra0b7zfzcHF3iseReWINIt2hT9fPF1hUDhrs+hYTfFv7gWpm4sptyvKQJDkWEZ5QxpPWHEupr4GhEX1hyl+LjjVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ddpy3LFX; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5CE7CC116B1; Wed, 12 Jun 2024 18:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718216914; bh=NJeqqnsIfUMhlSi06vIIKPHNE2ykrkcvFQ48tdRGhsA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ddpy3LFXn9c98MKv3p1z9yzC/k7fp2NoQZCwQ1Bp3h+rc35Aj+5XYZpEUKKZ724ju y9ZVcyK1HprCeVdIqNoKJZA4N3pV2QBPcSSYx5JVzTca/Va89RiIqfN0iHQoRB5v22 4P3VgoYjRQ0YRiOTFBQRUENT3jTcTYpRVcLHbZDkmjvl5fr0ovC4LYgtA8l9Bo4qNi sj6e2NiHBaBOFoXtpyO9MS/O51xFBlLGWQtlXXkxqasrMderNVfzK0R8HW3Fi9nd5v VqL2s2J+83NWAWDiaNO7RZLtHBTbLgANwd7LPwPmWBvnlcaNkfDGkoiSy+OXB4oGcu z4C8Bg0Ko80zg== Date: Wed, 12 Jun 2024 11:28:33 -0700 From: Kees Cook To: Johannes Berg Cc: Kenton Groombridge , davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v3] wifi: mac80211: Avoid address calculations via out of bounds array indexing Message-ID: <202406121127.FB2E58C2@keescook> References: <20240605152218.236061-1-concord@gentoo.org> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jun 12, 2024 at 10:20:41AM +0200, Johannes Berg wrote: > On Wed, 2024-06-05 at 11:22 -0400, Kenton Groombridge wrote: > > > > Co-authored-by: Kees Cook > > Signed-off-by: Kenton Groombridge > > > > Wait ... I don't know what Kees did here, but seems then he should sign- > off too. > > Kees? I had helped mainly in private emails with Kenton. I'm fine with whatever tags people want. :) Signed-off-by: Kees Cook and/or Reviewed-by: Kees Cook (Though note the email address change just to keep checkpatch happy about Co-authored-by vs S-o-b mismatches.) Thanks! -- Kees Cook