Received-SPF: pass (google.com: domain of linux-wireless+bounces-8894-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <a7a5655f6a62c5795fdfa02e528cc1d93fb6949c.camel@sipsolutions.net>
Subject: Re: WPA3 support for mac80211 drivers
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>, Larry Finger
	 <Larry.Finger@lwfinger.net>
Cc: linux-wireless <linux-wireless@vger.kernel.org>
Date: Wed, 12 Jun 2024 21:08:09 +0200
In-Reply-To: <a648b5b187e2d01cd1dc47b6737c95ddc25259ae.camel@sipsolutions.net>
References: <9b10768c-9fe7-40d9-a0b9-27d11a5e0e48@broadcom.com>
	 <a648b5b187e2d01cd1dc47b6737c95ddc25259ae.camel@sipsolutions.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.2 (3.52.2-1.fc40) 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-06-12 at 20:56 +0200, Johannes Berg wrote:
> On Wed, 2024-06-12 at 20:51 +0200, Arend van Spriel wrote:
> > Hi Johannes, Larry,
> >=20
> > I got a query from a brcmsmac user about support for WPA3. I had no ide=
a=20
> > what would be needed and actually assumed/hoped mac80211 would take car=
e=20
> > of it. My first attempt was looking in patchwork for other mac80211=20
> > drivers adding WPA3 and found this one interesting enough:
> >=20
> > https://patchwork.kernel.org/project/linux-wireless/patch/2020052615590=
9.5807-2-Larry.Finger@lwfinger.net/
> >=20
> > It only sets flag IEEE80211_HW_MFP_CAPABLE in hw->flags. So I suggested=
=20
> > to do the same in brcmsmac. Unfortunately no success so can you think o=
f=20
> > anything else that would be required from brcmsmac.
>=20
> You need the correct ciphers too (at least BIP, possibly GMAC)

No wait, you said brcmsmac, and it doesn't even have HW crypto?!

Then it seems like it should just work, does wpa_s have errors?

johannes