Received-SPF: pass (google.com: domain of linux-wireless+bounces-8990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: David Lin <yu-hao.lin@nxp.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
CC: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"briannorris@chromium.org" <briannorris@chromium.org>, "kvalo@kernel.org"
	<kvalo@kernel.org>, "francesco@dolcini.it" <francesco@dolcini.it>, Pete Hsieh
	<tsung-hsien.hsieh@nxp.com>, Francesco Dolcini
	<francesco.dolcini@toradex.com>
Subject: RE: [EXT] Re: [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP
 mode
Thread-Topic: [EXT] Re: [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP
 mode
Thread-Index: AQHakVah/NlfkBV8NUyUKYHJ747D+LHEcWiAgAJqJoA=
Date: Fri, 14 Jun 2024 02:06:45 +0000
Message-ID:
 <PA4PR04MB9638C0A141C53CC2F5898DA1D1C22@PA4PR04MB9638.eurprd04.prod.outlook.com>
References: <20240418060626.431202-1-yu-hao.lin@nxp.com>
 <20240418060626.431202-3-yu-hao.lin@nxp.com>
 <Zmmeg15YQtiChZ70@pengutronix.de>
In-Reply-To: <Zmmeg15YQtiChZ70@pengutronix.de>
Accept-Language: zh-TW, en-US
Content-Language: zh-TW
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?Ssk7rpWxtlbDNsf8uGSYSglMdclKKXXTNQNz8uZbcJlHoMtNh/IawpO7yUZT?=
 =?us-ascii?Q?h5MiIUM0hPfGzqtIuqa5zcIdTlP/jg4AWt1+925IypQhvdOPvuo14yFE3sLf?=
 =?us-ascii?Q?4LZDmaHFuQr+fHQAu92gmU7jmF4Hw9VvFcRAlBKOZ/PY0+/9ooLDOlm4qYRG?=
 =?us-ascii?Q?ooZU39Ky+AQ/NIFzww+psroK1Ev8EOewyGGG8PJQLdiKSbfsaItDq/lBOH3N?=
 =?us-ascii?Q?sAuYJGNJY3Zl8oMw72nvTwn43gCALQuUGGNjEWoeXBWR0ma2eDaFjqO/AqNC?=
 =?us-ascii?Q?XuIcEA70OO1a46ouFsdHpGDbo2H9hC2e2Av5Irpce5x4VtGBQuBVqRlMDVWs?=
 =?us-ascii?Q?/e+iRdbRnCl3gyWuNRsv2zukhRxfm/GRVeFN3llmCMIVJwBxT/efNKirDU2w?=
 =?us-ascii?Q?bPKWyJuIVXIFdQv5EkYddlelM6XtKMc5c+FlKPPC/iP7eUeTTHw8X8OgryA7?=
 =?us-ascii?Q?jKs8viZ8tOdx8hRsQ2JvinGIuKuF/r765qhqEKQRtOqrMdhXXsF5iJEZ2vp8?=
 =?us-ascii?Q?Wg2NduMnxh79vWhIuYVmuiBJLzS52QpQ/ZYHz+1qMeBNycPkbB1Yx5l5UErT?=
 =?us-ascii?Q?3vJTKHI8iBlsrALcrEbbqjmfuqsYb1+6BP6homS7txZV098MgwxLAZbc4nB7?=
 =?us-ascii?Q?CIEn0Jjl04xhaEidjTDM0bT2AMIL5xooxOt8MDgjAPTCQaILKx84kvpVMeJ6?=
 =?us-ascii?Q?64V4dcHxsDo/0437Z0X1rySXqMkHe60dBPbAJgkRVxqfI9vTO2GF+avJ9TDX?=
 =?us-ascii?Q?+K4N8uB3gPzovJ3IHb47ntUZiwNjs7k+QE8INSDwo8MUtL1pU2jG2ZO0swAL?=
 =?us-ascii?Q?Qf6mJBGKBVi4Ogi9Bi+q61YyS2uGzCUT37Sq8yB5QYZ1AZkxe6ppYJM+a6XC?=
 =?us-ascii?Q?Gob0vChngGtf6RZrZ/9Xo161Bwoj21RtLJVD9YjrRt964UHLTBXBak4gVbTI?=
 =?us-ascii?Q?sh5vOd7p9UVua5Le6s1x94XviRNKjYLi5nMajoplou90kBElURAhnfLTTYYs?=
 =?us-ascii?Q?BTSbjNNXcjJP6Qgew5KmDkZxQaS+24U2CKbbcbiD14SJ9q80SzuaSduysnEK?=
 =?us-ascii?Q?fZZL1sDCJfg7oO5UboMdigMo7CNQnyyKiv00UQR6ZKPV+aKkSQU0K3+imTIr?=
 =?us-ascii?Q?APSafuCmL8u8QCy+bfC09AfOuTFpa8GlmHK4c0lxsDyVS3aKkZMlkTpeJcCo?=
 =?us-ascii?Q?YyCZQwcxCx2Dt99ndRW0lqm14gFd2KwQZGp2vHPzhJ4YtsW80Vq3WPgUi7Xn?=
 =?us-ascii?Q?OQxOueHRA+qOqQNblHjBrPO2V6R0667Tx0FVsn+I7khbHoAcgP4iocO84fK/?=
 =?us-ascii?Q?yTTYj1BkTiWYl1xtZZLlHLvoKw1Tu2D49csbe5Njzjw7KyFoV4zPIv7UzR9u?=
 =?us-ascii?Q?vPc4r3AthXyS0SWj8ylJpw045s9WQgSCXL9cZwD3tJaLEvrn6uyszyyuzR1B?=
 =?us-ascii?Q?eKQ2RgoaOx+CuVjL4G0MigLV1nYbEcNc0wq02Uk40NzUpJR2g2AnicARxnce?=
 =?us-ascii?Q?CqNwxPzS31EKvftpAQwDig2PViJQ42LtOpZXCZgknOiVEAFLuPJIf54eOQug?=
 =?us-ascii?Q?h258lmvEW51l8sGrTmDPTHJTI/wIuAXn3YZBIPYg?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-wireless@vger.kernel.org
List-Id: <linux-wireless.vger.kernel.org>
List-Subscribe: <mailto:linux-wireless+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-wireless+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PA4PR04MB9638.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 14df51b1-9650-4d5a-ea21-08dc8c16a48a
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2024 02:06:45.7087
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: HOHFzJAuM4Defp7/kHrFoFsBuIoPCA9HIDUuIrUFjQLd6X97cH0e1HiuuI70lD74b5fSgJO7MTqKuSMJjjLZ6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7596

> From: Sascha Hauer <s.hauer@pengutronix.de>
> Sent: Wednesday, June 12, 2024 9:12 PM
> To: David Lin <yu-hao.lin@nxp.com>
> Cc: linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org;
> briannorris@chromium.org; kvalo@kernel.org; francesco@dolcini.it; Pete
> Hsieh <tsung-hsien.hsieh@nxp.com>; Francesco Dolcini
> <francesco.dolcini@toradex.com>
> Subject: [EXT] Re: [PATCH v10 2/2] wifi: mwifiex: add host mlme for AP mo=
de
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>=20
>=20
> Hi David,
>=20
> On Thu, Apr 18, 2024 at 02:06:26PM +0800, David Lin wrote:
> > Add host based MLME to enable WPA3 functionalities in AP mode.
> > This feature required a firmware with the corresponding V2 Key API
> > support. The feature (WPA3) is currently enabled and verified only on
> > IW416. Also, verified no regression with change when host MLME is
> > disabled.
> >
> > Signed-off-by: David Lin <yu-hao.lin@nxp.com>
> > Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>
> > ---
> >
>=20
> > diff --git a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > index 491e36611909..073c665183b3 100644
> > --- a/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > +++ b/drivers/net/wireless/marvell/mwifiex/uap_cmd.c
> > @@ -72,6 +72,10 @@ int mwifiex_set_secure_params(struct
> mwifiex_private *priv,
> >                               bss_config->key_mgmt =3D
> KEY_MGMT_PSK;
> >                       }
> >                       break;
> > +             case WLAN_AKM_SUITE_SAE:
> > +                     bss_config->protocol =3D PROTOCOL_WPA2;
> > +                     bss_config->key_mgmt =3D KEY_MGMT_SAE;
> > +                     break;
>=20
> Shouldn't this be |=3D PROTOCOL_WPA2 and |=3D KEY_MGMT_SAE?
> Clearing the other flags when SAE is enabled looks wrong to me.
>=20
> Sascha
>=20

These fields are used for the configuration of FW, this is the correct sett=
ing.

David