2008-10-14 22:06:57

by Elias Oltmanns

[permalink] [raw]
Subject: Re: [PATCH] ath5k: Does not connect reliably on 2.6.27

"Nick Kossifidis" <[email protected]> wrote:
> 2008/10/14 Elias Oltmanns <[email protected]>:
>> Hi all,
>
>>
>> after a cold boot into 2.6.27, ath5k doesn't work on my machine. The
>> sequence
>>
>> # ifconfig ath0 up
>> # iwlist ath0 ap
>>
>> results in a message informing me that no list of APs is available for
>> that device.
[...]
>> The minimal patch to fix the issue for me is attached. However, I am
>> wondering whether the preceding writes to register 0xa228 should be
>> dropped or at least adjusted somehow. Perhaps those of you who know the
>> recently released HAL from Atheros can throw some light on the matter.
>>
>> Regards,
>>
>> Elias
>> ---
>> diff --git a/drivers/net/wireless/ath5k/hw.c b/drivers/net/wireless/ath5k/hw.c
>> index dc51b84..b1cec2a 100644
>> --- a/drivers/net/wireless/ath5k/hw.c
>> +++ b/drivers/net/wireless/ath5k/hw.c
>> @@ -862,7 +862,7 @@ int ath5k_hw_reset(struct ath5k_hw *ah, enum ieee80211_if_types op_mode,
>> data = 0;
>>
>> /* Just write 0x9b5 ? */
>> - /* ath5k_hw_reg_write(ah, 0x000009b5, 0xa228); */
>> + ath5k_hw_reg_write(ah, 0x000009b5, 0xa228);
>> ath5k_hw_reg_write(ah, 0x0000000f, AR5K_SEQ_MASK);
>> ath5k_hw_reg_write(ah, 0x00000000, 0xa254);
>> ath5k_hw_reg_write(ah, 0x0000000e, AR5K_PHY_SCAL);
>>
>
> I think i've fixed that (it's a buggy mask some lines above) on an
> earlier patch (the one that introduced AR2425 support) but i'll look
> into it again ;-)

Can you drop me a link or a commit + tree so I can test it?

Regards,

Elias