2009-01-12 12:24:58

by Jouni Malinen

[permalink] [raw]
Subject: [PATCH] nl80211: Fix documentation errors

Couple of '_ATTR's were missing and SEC_CHAN_OFFSET to CHANNEL_TYPE
rename was missed in couple of places.

Signed-off-by: Jouni Malinen <[email protected]>


---
include/linux/nl80211.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

--- wireless-testing.orig/include/linux/nl80211.h 2009-01-12 13:12:49.000000000 +0200
+++ wireless-testing/include/linux/nl80211.h 2009-01-12 13:14:19.000000000 +0200
@@ -47,7 +47,7 @@
* @NL80211_CMD_SET_WIPHY: set wiphy parameters, needs %NL80211_ATTR_WIPHY or
* %NL80211_ATTR_IFINDEX; can be used to set %NL80211_ATTR_WIPHY_NAME,
* %NL80211_ATTR_WIPHY_TXQ_PARAMS, %NL80211_ATTR_WIPHY_FREQ, and/or
- * %NL80211_ATTR_WIPHY_SEC_CHAN_OFFSET.
+ * %NL80211_ATTR_WIPHY_CHANNEL_TYPE.
* @NL80211_CMD_NEW_WIPHY: Newly created wiphy, response to get request
* or rename notification. Has attributes %NL80211_ATTR_WIPHY and
* %NL80211_ATTR_WIPHY_NAME.
@@ -84,7 +84,7 @@
* %NL80222_CMD_NEW_BEACON message)
* @NL80211_CMD_SET_BEACON: set the beacon on an access point interface
* using the %NL80211_ATTR_BEACON_INTERVAL, %NL80211_ATTR_DTIM_PERIOD,
- * %NL80211_BEACON_HEAD and %NL80211_BEACON_TAIL attributes.
+ * %NL80211_ATTR_BEACON_HEAD and %NL80211_ATTR_BEACON_TAIL attributes.
* @NL80211_CMD_NEW_BEACON: add a new beacon to an access point interface,
* parameters are like for %NL80211_CMD_SET_BEACON.
* @NL80211_CMD_DEL_BEACON: remove the beacon, stop sending it
@@ -362,7 +362,7 @@ enum nl80211_attrs {
#define NL80211_ATTR_BSS_BASIC_RATES NL80211_ATTR_BSS_BASIC_RATES
#define NL80211_ATTR_WIPHY_TXQ_PARAMS NL80211_ATTR_WIPHY_TXQ_PARAMS
#define NL80211_ATTR_WIPHY_FREQ NL80211_ATTR_WIPHY_FREQ
-#define NL80211_ATTR_WIPHY_SEC_CHAN_OFFSET NL80211_ATTR_WIPHY_SEC_CHAN_OFFSET
+#define NL80211_ATTR_WIPHY_CHANNEL_TYPE NL80211_ATTR_WIPHY_CHANNEL_TYPE

#define NL80211_MAX_SUPP_RATES 32
#define NL80211_MAX_SUPP_REG_RULES 32

--
Jouni Malinen PGP id EFC895FA


2009-01-12 12:58:47

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] nl80211: Fix documentation errors

On Mon, 2009-01-12 at 14:24 +0200, Jouni Malinen wrote:
> Couple of '_ATTR's were missing and SEC_CHAN_OFFSET to CHANNEL_TYPE
> rename was missed in couple of places.

Good find, thanks.

> Signed-off-by: Jouni Malinen <[email protected]>

Acked-by: Johannes Berg <[email protected]>

>
> ---
> include/linux/nl80211.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> --- wireless-testing.orig/include/linux/nl80211.h 2009-01-12 13:12:49.000000000 +0200
> +++ wireless-testing/include/linux/nl80211.h 2009-01-12 13:14:19.000000000 +0200
> @@ -47,7 +47,7 @@
> * @NL80211_CMD_SET_WIPHY: set wiphy parameters, needs %NL80211_ATTR_WIPHY or
> * %NL80211_ATTR_IFINDEX; can be used to set %NL80211_ATTR_WIPHY_NAME,
> * %NL80211_ATTR_WIPHY_TXQ_PARAMS, %NL80211_ATTR_WIPHY_FREQ, and/or
> - * %NL80211_ATTR_WIPHY_SEC_CHAN_OFFSET.
> + * %NL80211_ATTR_WIPHY_CHANNEL_TYPE.
> * @NL80211_CMD_NEW_WIPHY: Newly created wiphy, response to get request
> * or rename notification. Has attributes %NL80211_ATTR_WIPHY and
> * %NL80211_ATTR_WIPHY_NAME.
> @@ -84,7 +84,7 @@
> * %NL80222_CMD_NEW_BEACON message)
> * @NL80211_CMD_SET_BEACON: set the beacon on an access point interface
> * using the %NL80211_ATTR_BEACON_INTERVAL, %NL80211_ATTR_DTIM_PERIOD,
> - * %NL80211_BEACON_HEAD and %NL80211_BEACON_TAIL attributes.
> + * %NL80211_ATTR_BEACON_HEAD and %NL80211_ATTR_BEACON_TAIL attributes.
> * @NL80211_CMD_NEW_BEACON: add a new beacon to an access point interface,
> * parameters are like for %NL80211_CMD_SET_BEACON.
> * @NL80211_CMD_DEL_BEACON: remove the beacon, stop sending it
> @@ -362,7 +362,7 @@ enum nl80211_attrs {
> #define NL80211_ATTR_BSS_BASIC_RATES NL80211_ATTR_BSS_BASIC_RATES
> #define NL80211_ATTR_WIPHY_TXQ_PARAMS NL80211_ATTR_WIPHY_TXQ_PARAMS
> #define NL80211_ATTR_WIPHY_FREQ NL80211_ATTR_WIPHY_FREQ
> -#define NL80211_ATTR_WIPHY_SEC_CHAN_OFFSET NL80211_ATTR_WIPHY_SEC_CHAN_OFFSET
> +#define NL80211_ATTR_WIPHY_CHANNEL_TYPE NL80211_ATTR_WIPHY_CHANNEL_TYPE
>
> #define NL80211_MAX_SUPP_RATES 32
> #define NL80211_MAX_SUPP_REG_RULES 32
>